New issue
Advanced search Search tips

Issue 706494 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test fast/events/hr-timestamp/input-events.html is flaky

Project Member Reported by dtapu...@chromium.org, Mar 29 2017

Issue description

fast/events/hr-timestamp/input-events.html

is flaky because the floor is not being considered in the calculation.


This is a testharness.js-based test.
FAIL Event timestamp should be equal to the timestamp provided by the platform for mousedown assert_approx_equals: expected 18.040999999811902 +/- 0.005 but got 18.035000000000004
PASS Event timestamp should be equal to the timestamp provided by the platform for keydown 
PASS Event timestamp should be equal to the timestamp provided by the platform for touchstart 
PASS Event timestamp should be equal to the timestamp provided by the platform for click 
FAIL Event timestamp should be equal to the timestamp provided by the platform for contextmenu assert_approx_equals: expected 23.170999999820197 +/- 0.005 but got 23.165000000000003
PASS Event timestamp should be equal to the timestamp provided by the platform for wheel 
Harness: the test ran to completion.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c4770a055e01afcc6a687068694929bc048e702

commit 2c4770a055e01afcc6a687068694929bc048e702
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Mar 29 20:22:50 2017

Fix flaky hi-resolution event timestamp test.

Ensure the floor calculation is taken into account when running the
layout test. The calculation matches what is happening when e.timeStamp
is being returned.

BUG= 706494 

Review-Url: https://codereview.chromium.org/2784913002
Cr-Commit-Position: refs/heads/master@{#460517}

[modify] https://crrev.com/2c4770a055e01afcc6a687068694929bc048e702/third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86a9036f5ae27bdc2c0dfb710a26745ea2820644

commit 86a9036f5ae27bdc2c0dfb710a26745ea2820644
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Apr 04 15:03:31 2017

Fix flaky hr-timestamp/input-events.html

Add some additional precision fudge factor. The flakiness has been
reduced since change https://codereview.chromium.org/2784913002.

But now getting a few flakes likely due to precision issues.
assert_approx_equals: expected 42.56 +/- 0.005 but got 42.555

BUG= 706494 

Review-Url: https://codereview.chromium.org/2790173002
Cr-Commit-Position: refs/heads/master@{#461716}

[modify] https://crrev.com/86a9036f5ae27bdc2c0dfb710a26745ea2820644/third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html

Sign in to add a comment