New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706485 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 13
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Check in code for Mimo firmware updater

Project Member Reported by frankhu@chromium.org, Mar 29 2017

Issue description

We want to check in code for the Mimo firmware updater, which updates fw for DL, SiS and Realtek.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/mimo-updater/+/ddfd74f6363a8cce6ebeadeb380d9c2a09d9d68c

commit ddfd74f6363a8cce6ebeadeb380d9c2a09d9d68c
Author: Jen-Chieh Huang <jenchiehhuang@google.com>
Date: Tue May 02 02:18:15 2017

Initial MIMO updater(version from partner)

We add the build system and the related documents required by CrOS.
NOTE: license is a placeholder (will be fixed before landing)

BUG= chromium:706485 
TEST=build image for guado with this change
verify that MIMO and CrOS box are still working properly.

Change-Id: Ibef9680632b132c10f1c3564c13804256dcac3cf
Reviewed-on: https://chromium-review.googlesource.com/479643
Commit-Ready: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Tested-by: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[add] https://crrev.com/ddfd74f6363a8cce6ebeadeb380d9c2a09d9d68c/conf/99-displaylink-usb.rules
[add] https://crrev.com/ddfd74f6363a8cce6ebeadeb380d9c2a09d9d68c/mimo_fw_updater.cc
[add] https://crrev.com/ddfd74f6363a8cce6ebeadeb380d9c2a09d9d68c/LICENSE
[add] https://crrev.com/ddfd74f6363a8cce6ebeadeb380d9c2a09d9d68c/Makefile
[add] https://crrev.com/ddfd74f6363a8cce6ebeadeb380d9c2a09d9d68c/common.mk
[add] https://crrev.com/ddfd74f6363a8cce6ebeadeb380d9c2a09d9d68c/README.md

Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a33e2fddddc80bad7965dc454153f8ee2cd4fd9d

commit a33e2fddddc80bad7965dc454153f8ee2cd4fd9d
Author: Zhongze Hu <frankhu@google.com>
Date: Wed May 10 14:08:30 2017

Add SiS firmware updater ebuild

BUG= chromium:706485 
TEST=test with 'emerge-guado sis-updater' and verified the output
packages.

Change-Id: I0448b17e5b320650d239a9722fbc39ea43b49eec
Reviewed-on: https://chromium-review.googlesource.com/477498
Commit-Ready: Zhongze Hu <frankhu@google.com>
Tested-by: Zhongze Hu <frankhu@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/a33e2fddddc80bad7965dc454153f8ee2cd4fd9d/sys-apps/sis-updater/sis-updater-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/a175282b64829a1ca736001910fb217c8fbe593c

commit a175282b64829a1ca736001910fb217c8fbe593c
Author: Zhongze Hu <frankhu@google.com>
Date: Wed May 10 18:58:22 2017

Add user and group for CFM devices applications

Add a unified user and group for cfm peripheral firmware updaters
including Mimo(displaylink, sis, realtek) and huddly.

BUG= chromium:706485 
TEST=None

Change-Id: Ic0d449a9ef015b12713e68311c37bc1c08b7a10d
Reviewed-on: https://chromium-review.googlesource.com/493792
Commit-Ready: Zhongze Hu <frankhu@google.com>
Tested-by: Zhongze Hu <frankhu@google.com>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/a175282b64829a1ca736001910fb217c8fbe593c/profiles/base/accounts/user/cfm-firmware-updaters
[add] https://crrev.com/a175282b64829a1ca736001910fb217c8fbe593c/profiles/base/accounts/group/cfm-firmware-updaters

Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/a175282b64829a1ca736001910fb217c8fbe593c

commit a175282b64829a1ca736001910fb217c8fbe593c
Author: Zhongze Hu <frankhu@google.com>
Date: Wed May 10 18:58:22 2017

Add user and group for CFM devices applications

Add a unified user and group for cfm peripheral firmware updaters
including Mimo(displaylink, sis, realtek) and huddly.

BUG= chromium:706485 
TEST=None

Change-Id: Ic0d449a9ef015b12713e68311c37bc1c08b7a10d
Reviewed-on: https://chromium-review.googlesource.com/493792
Commit-Ready: Zhongze Hu <frankhu@google.com>
Tested-by: Zhongze Hu <frankhu@google.com>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/a175282b64829a1ca736001910fb217c8fbe593c/profiles/base/accounts/user/cfm-firmware-updaters
[add] https://crrev.com/a175282b64829a1ca736001910fb217c8fbe593c/profiles/base/accounts/group/cfm-firmware-updaters

Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/sis-updater/+/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09

commit f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09
Author: Zhongze Hu <frankhu@google.com>
Date: Wed May 10 21:24:37 2017

Add SiS firmware updater

The firmware updater is provided by SiS with some modification by Google.

BUG= chromium:706485 
TEST=Build image for guado and tested the functionality on chromebox.

Change-Id: I72c3726a65a1c2a3ce5cc4e262efea9f472f849e
Reviewed-on: https://chromium-review.googlesource.com/476935
Commit-Ready: Zhongze Hu <frankhu@google.com>
Tested-by: Zhongze Hu <frankhu@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/OpenShortData.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/LICENSE
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/Makefile
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/SiSTouchAdapter.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/SiSTouchDeviceName.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/version.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/UpdateFWParameter.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/MultiOpenShortResult.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/SisTouchFinder.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/module.mk
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/OpenShortResult.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/conf/99-sis-usb.rules
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/SiSTouchIO.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/.gitignore
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/ExitStatus.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/Parameter.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/ApplicationParameter.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/AegisSiSTouchAdapter.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/SiSLogger.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/csv_parser.hpp
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/MultiOpenShortData.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/README.md
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/OpenShortConfig.h
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/src/sis_fw_updater.cc
[add] https://crrev.com/f8cdd7917157bb744fcc4d79e7e56e5ae94c2b09/common.mk

Project Member

Comment 6 by bugdroid1@chromium.org, May 12 2017

Project Member

Comment 7 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/sis-updater/+/600840897bd02d32ceaa44c208aad71284d92c2d

commit 600840897bd02d32ceaa44c208aad71284d92c2d
Author: Zhongze Hu <frankhu@google.com>
Date: Tue May 16 03:51:36 2017

Fix Wformat-nonliteral problem in sis-updater

BUG= chromium:706485 
TEST=tested with 'emerge-guado sis-updater' and verified the output
binary.

Change-Id: Ieda99dfb648cfa0de9be84cf20ba31a9a252ae6c
Reviewed-on: https://chromium-review.googlesource.com/505457
Commit-Ready: Zhongze Hu <frankhu@google.com>
Tested-by: Zhongze Hu <frankhu@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/600840897bd02d32ceaa44c208aad71284d92c2d/src/SiSLogger.h

Project Member

Comment 8 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/mimo-updater/+/991ac72229fe57667d134b884abeb01a4fe0237e

commit 991ac72229fe57667d134b884abeb01a4fe0237e
Author: Jen-Chieh Huang <jenchiehhuang@google.com>
Date: Fri May 19 04:05:24 2017

Add the version polling mechanism for displaylink FW updater

BUG= chromium:706485 
TEST=build image for guado with this change
verify that MIMO and CrOS box are still working properly.
In addition, start the updater without any parameter, the
firmware version of the attached displaylink devices should
be displayed.

Change-Id: Ie114826447b16181447dd9d41c6dc5428a4c59ac
Reviewed-on: https://chromium-review.googlesource.com/491646
Commit-Ready: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Tested-by: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jiwoong Lee <porce@chromium.org>

[modify] https://crrev.com/991ac72229fe57667d134b884abeb01a4fe0237e/mimo_fw_updater.cc

Project Member

Comment 9 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3e906852e8ed6746cfd34144352846a50b3b05f0

commit 3e906852e8ed6746cfd34144352846a50b3b05f0
Author: Jen-Chieh Huang <jenchiehhuang@google.com>
Date: Fri May 19 04:05:23 2017

Add MIMO updater ebuild

BUG= chromium:706485 
TEST=emerge-guado mimo-updater builds successfully

Change-Id: Ifc00546f1348229295731e5e0031351693418634
Reviewed-on: https://chromium-review.googlesource.com/463706
Commit-Ready: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Tested-by: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[add] https://crrev.com/3e906852e8ed6746cfd34144352846a50b3b05f0/sys-apps/mimo-updater/mimo-updater-9999.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/712ff6b95ed3b7dabd1c0941b1b6fd98207d3a93

commit 712ff6b95ed3b7dabd1c0941b1b6fd98207d3a93
Author: Zhongze Hu <frankhu@google.com>
Date: Fri May 19 18:57:48 2017

security_AccountsBaseline: Add cfm-firmware-updaters user/group

The cfm-firmware-updaters user/group was added in:
https://chromium-review.googlesource.com/c/493792/

The autotest is updated in order to allow the presence of this user/group.

BUG= chromium:706485 
TEST=local build

Change-Id: I8f6ab0c915314d73e5da30bbdcb8ff8a8ea62ffe
Reviewed-on: https://chromium-review.googlesource.com/506526
Commit-Ready: Zhongze Hu <frankhu@google.com>
Tested-by: Zhongze Hu <frankhu@google.com>
Reviewed-by: Simon Que <sque@chromium.org>

[modify] https://crrev.com/712ff6b95ed3b7dabd1c0941b1b6fd98207d3a93/client/site_tests/security_AccountsBaseline/baseline.group
[modify] https://crrev.com/712ff6b95ed3b7dabd1c0941b1b6fd98207d3a93/client/site_tests/security_AccountsBaseline/baseline.passwd

Project Member

Comment 11 by bugdroid1@chromium.org, May 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/sis-updater/+/3cd8fe58f994440d2e5e6238e45611b9f2dc709c

commit 3cd8fe58f994440d2e5e6238e45611b9f2dc709c
Author: Zhongze Hu <frankhu@google.com>
Date: Sat May 20 01:03:02 2017

Fix problem in sis udev rules

Fix wrong minijail param format

BUG= chromium:706485 
TEST=built image and tested on chromebox

Change-Id: Ib4681bbeaaf5c65a7a5dbbeb016879003efa42ba
Reviewed-on: https://chromium-review.googlesource.com/509950
Commit-Ready: Zhongze Hu <frankhu@google.com>
Tested-by: Zhongze Hu <frankhu@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3cd8fe58f994440d2e5e6238e45611b9f2dc709c/conf/99-sis-usb.rules

Comment 12 by sque@chromium.org, May 20 2017

Cc: sque@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cb46a60e609ea190c7be8ca77e5e839a776768e0

commit cb46a60e609ea190c7be8ca77e5e839a776768e0
Author: Jen-Chieh Huang <jenchiehhuang@google.com>
Date: Mon May 22 23:30:18 2017

mimo-updater: Fix the udev rule name to make it run earlier

In this CL, we change the udev file name to make sure
the rule is run earlier than another displaylink rule
provided by the displaylink to install the device.

BUG= chromium:706485 
TEST=emerge-guado mimo-updater builds successfully

Change-Id: I2a7b27c5304eb316e20bb0440611544425449f83
Reviewed-on: https://chromium-review.googlesource.com/509956
Commit-Ready: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Tested-by: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/cb46a60e609ea190c7be8ca77e5e839a776768e0/sys-apps/mimo-updater/mimo-updater-9999.ebuild

Project Member

Comment 14 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/mimo-updater/+/12a4c0654dfb1b20936f82e6137e62fecc1049de

commit 12a4c0654dfb1b20936f82e6137e62fecc1049de
Author: Jen-Chieh Huang <jenchiehhuang@google.com>
Date: Tue May 23 23:56:54 2017

Change the rule name - to make the rule run before another rule.

In this CL, change the udev file name to make sure the rule is
run earlier than another displaylink rule provided by the
displaylink installation process.

BUG= chromium:706485 
TEST=emerge-guado mimo-updater builds successfully, and after power-on, mimo is working properly.
CQ-DEPEND=CL:509956, CL:*372588

Change-Id: I2a5d78e77b7f9820b65efcac4b3df36e1cd99fbc
Reviewed-on: https://chromium-review.googlesource.com/510052
Commit-Ready: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Tested-by: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[add] https://crrev.com/12a4c0654dfb1b20936f82e6137e62fecc1049de/conf/90-displaylink-usb.rules
[delete] https://crrev.com/991ac72229fe57667d134b884abeb01a4fe0237e/conf/99-displaylink-usb.rules

Project Member

Comment 15 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/mimo-updater/+/ca4b9d39936daa0e31a7d842b4a4c666cdf053ce

commit ca4b9d39936daa0e31a7d842b4a4c666cdf053ce
Author: Jen-Chieh Huang <jenchiehhuang@google.com>
Date: Wed May 24 21:24:04 2017

Modify the updater behavior when no update is needed.

In this CL, if the device firmware is not updated, the
device will not be rebooted. The way it is done is by
adding an extra state in the updating procedure. When
the firmware version matches the one in the CrOS release,
the mimo will not reboot.

BUG= chromium:706485 
TEST=emerge-guado mimo-updater builds successfully, and after power-on,
mimo is working properly.
CQ-DEPEND=CL:509956, CL:*372588

Change-Id: Iacf5bb7be0bfd976493e45d8a552372d65674671
Reviewed-on: https://chromium-review.googlesource.com/511663
Commit-Ready: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Tested-by: Jen-Chieh Huang <jenchiehhuang@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/ca4b9d39936daa0e31a7d842b4a4c666cdf053ce/mimo_fw_updater.cc

Comment 16 by erdi@google.com, May 26 2017

The MIMO updater packages use usb.h from libusb-compat. Its ebuild should have explicit dependency on libusb-compat.
Status: Assigned (was: Untriaged)
Status: Verified (was: Assigned)

Sign in to add a comment