New issue
Advanced search Search tips

Issue 706480 link

Starred by 1 user
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Mar 2017
Cc:
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

"jsexterns" are included in the generated extensions schema bundle

Project Member Reported by rdevlin....@chromium.org, Mar 29 2017 
revision 5964242ae4c92988b391db18328b162937f8da3b introduced "jsexterns" to extension schemas. Unfortunately, these are now being included in the generated bundle, which will slow down parsing time and add a little extra bloat.  We should remove them.

I should have noticed this in the cl that added them, but didn't. :(
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3911c42a8ec4d0f164a77ff99b723d2fde12754

commit a3911c42a8ec4d0f164a77ff99b723d2fde12754
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Mar 29 18:26:35 2017

[Extensions Schema Compiler] Don't bundle nocompile and jsexterns keys

BUG= 706480 

Review-Url: https://codereview.chromium.org/2782203003
Cr-Commit-Position: refs/heads/master@{#460463}

[modify] https://crrev.com/a3911c42a8ec4d0f164a77ff99b723d2fde12754/tools/json_schema_compiler/cpp_bundle_generator.py

Comment 2 by rdevlin....@chromium.org, Mar 29 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment