New issue
Advanced search Search tips

Issue 706473 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Failure to exit mirror mode from MD-settings

Project Member Reported by afakhry@chromium.org, Mar 29 2017

Issue description

Mirror mode has a lot of issues lately. Today while I was trying to repro b/35647845, I switched to mirror mode, and then tried to exit mirror mode by turning off its switch in MD-settings .... and nothing happened, the two displays (internal + external) continue in mirror mode.


Looking at the UI logs, we have an error for every time I tried to move the switch:

[6198:6198:0329/103544.135048:ERROR:CONSOLE(440)] "setDisplayProperties Error: Display not found.", source: chrome://settings/crispe

I'll get you more details as I investigate more.
 
Cc: malaykeshav@chromium.org
Can you also check whether or not we have the same problem with chrome://settings-frame? Thanks!

Yes, it's working fine with chrome://settings-frame.
Status: Assigned (was: Untriaged)
Labels: 59
Labels: -59 M-59
Labels: Hotlist-MD-Settings-Display
Status: Started (was: Assigned)
The error you saw is set here:

https://cs.chromium.org/chromium/src/chrome/browser/extensions/display_info_provider_chromeos.cc?type=cs&q=DisplayInfoProviderChromeOS::SetInfo&l=462

Somehow the display id sent from JS -> C++ is invalid.

I thought this might be related to  issue 707328  (which I encountered while investigating this), but I was able to reproduce it even after fixing that. Continuing to investigate this.

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8d1cf20deff6c710b6d096d228b65b5520c0c3c

commit a8d1cf20deff6c710b6d096d228b65b5520c0c3c
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Apr 05 17:35:30 2017

MD Settings: Display: Fix update order

BUG= 706473 
For minor string change:
TBR=rdevlin.cronin@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2789183002
Cr-Commit-Position: refs/heads/master@{#462132}

[modify] https://crrev.com/a8d1cf20deff6c710b6d096d228b65b5520c0c3c/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/a8d1cf20deff6c710b6d096d228b65b5520c0c3c/chrome/browser/resources/settings/device_page/display.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Chrome OS 9460.5.0/ 59.0.3071.15

Sign in to add a comment