Issue 706466 link

Starred by 2 users

Issue metadata

Status:	Assigned
Owner:	dcheng@chromium.org
Cc:	tkent@chromium.org thakis@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Blocked on:
issue 775741
issue 777595

Enable (more) clang plugin checks in Blink

Project Member Reported by dcheng@chromium.org, Mar 29 2017

Issue description

The Chrome clang plugin currently skips all of third_party/WebKit. While there's a flag to check WebKit as well, it's an all-or-nothing affair.

In the long run, we may want to enable all the plugin checks in Blink anyway, but we should have an incremental path for enabling the most valuable checks: `auto' is qualified as appropriate, override/final are used as needed, and possibly a couple others.

Comment 1 by dcheng@chromium.org, Mar 30 2017

Looking at the different warnings the plugin emits, this is my general thought of how we should do it:

IPC warnings
  enable: no IPC code in Blink, but just enable for consistency (so the list of ignored warnings is not so large)

Messages for virtual method specifiers:
  enable: use of virtual, override, final. 

Messages for destructors:
  disable for now: currently targeted at destructor issues for refcounted classes. Blink does use refcounting, but the checks would need to be updated. Enable once that's done.

Miscellaneous messages:
  enable: WeakPtrFactory ordering, auto deduced to pointer type
  disable: "last" enum value isn't actually last. Disabled for now, as it's still generally disabled atm.

Constructor/destructor complexity:
  disable for now: this might produce some binary size wins, but may cause perf regressions as well. Leave disabled and proceed carefully for enabling it.

Inline virtual body:
  disable: because Blink uses this a lot. If we re-evaluate and change our minds here, we can enable it later.

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aff6f114be3dea567abd0409e07ea7a394c7527

commit 6aff6f114be3dea567abd0409e07ea7a394c7527
Author: dcheng <dcheng@chromium.org>
Date: Tue Apr 11 20:26:12 2017

Refactor banned directory checking so Blink can opt into certain checks.

BUG=706466

Review-Url: https://codereview.chromium.org/2780113002
Cr-Commit-Position: refs/heads/master@{#463748}

[modify] https://crrev.com/6aff6f114be3dea567abd0409e07ea7a394c7527/tools/clang/plugins/ChromeClassTester.cpp
[modify] https://crrev.com/6aff6f114be3dea567abd0409e07ea7a394c7527/tools/clang/plugins/ChromeClassTester.h
[modify] https://crrev.com/6aff6f114be3dea567abd0409e07ea7a394c7527/tools/clang/plugins/FindBadConstructsConsumer.cpp
[modify] https://crrev.com/6aff6f114be3dea567abd0409e07ea7a394c7527/tools/clang/plugins/FindBadConstructsConsumer.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70a4c99d82f7f1bfff9371d915702cf923d14c9e

commit 70a4c99d82f7f1bfff9371d915702cf923d14c9e
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Sep 15 07:36:46 2017

chrome clang plugin: inline warning strings into diagnostic registration

Bug: 706466
Change-Id: I29a7fde7dcca0bf7dcfe6c9a9733e0b51dbfa7cc
Reviewed-on: https://chromium-review.googlesource.com/668148
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502187}
[modify] https://crrev.com/70a4c99d82f7f1bfff9371d915702cf923d14c9e/tools/clang/plugins/FindBadConstructsConsumer.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb72ecd8e0da9ad2a26e46ad9296225ea62135c

commit 2fb72ecd8e0da9ad2a26e46ad9296225ea62135c
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Sep 15 22:15:56 2017

chrome clang plugin: reduce the number of ways to report diagnostics

Most diagnostics are now emitted with ReportIfSpellingLocNotIgnored().
A few places (mostly the refcount warnings) emit warnings directly via
DiagnosticsEngine rather than via ReportIfSpellingLocNotIgnored(), but
they should be mostly harmless.

Bug: 706466
Change-Id: I036ec936709a7c401253aa9f13a63051562a50e1
Reviewed-on: https://chromium-review.googlesource.com/668201
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502400}
[modify] https://crrev.com/2fb72ecd8e0da9ad2a26e46ad9296225ea62135c/tools/clang/plugins/ChromeClassTester.cpp
[modify] https://crrev.com/2fb72ecd8e0da9ad2a26e46ad9296225ea62135c/tools/clang/plugins/ChromeClassTester.h
[modify] https://crrev.com/2fb72ecd8e0da9ad2a26e46ad9296225ea62135c/tools/clang/plugins/FindBadConstructsConsumer.cpp
[modify] https://crrev.com/2fb72ecd8e0da9ad2a26e46ad9296225ea62135c/tools/clang/plugins/FindBadConstructsConsumer.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6e32d44c0a65fe42815f283b8c21e5bf99b773c

commit a6e32d44c0a65fe42815f283b8c21e5bf99b773c
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Sep 19 04:05:59 2017

Add missing override to zucchini::LimitedOutputStream::StreamBuf dtor

Found when tweaking the classification heuristics used by the clang
plugin for the Blink rename.

TBR=wfh@chromium.org

Bug: 706466
Change-Id: I4f122a91b63994a10ac0575192c9fe85ee3ff3d7
Reviewed-on: https://chromium-review.googlesource.com/671884
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502779}
[modify] https://crrev.com/a6e32d44c0a65fe42815f283b8c21e5bf99b773c/chrome/installer/zucchini/io_utils.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b2f6fee2431924b8231846e7efd1584dfab2739

commit 7b2f6fee2431924b8231846e7efd1584dfab2739
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Sep 19 05:07:52 2017

Simplify SourceLocation classification and remove banned namespace check

The plugin was passing a clang::Decl* to ClassifyLocation() to classify
declarations in the blink or WTF namespace correctly. However, there is
now a set plan for the Blink file rename, so just check for the paths
directly. This simplifies the warning code by not requiring a Decl
to be passed around.

In addition, the plugin also implemented a check for banned namespaces
which checked for the C++ standard library public and implementation
namespaces. This is unnecessary since the plugin already knows how to
ignore warnings in system headers: removing this and relying on the
standard ClassifyLocation() check revealed one instance of inheriting
a class from the standard library and forgetting to mark the destructor
with override.

Bug: 706466
Change-Id: Ic12b1bc1fc47202026a2857b5eee10f5a7c3496d
Reviewed-on: https://chromium-review.googlesource.com/669711
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502782}
[modify] https://crrev.com/7b2f6fee2431924b8231846e7efd1584dfab2739/tools/clang/plugins/ChromeClassTester.cpp
[modify] https://crrev.com/7b2f6fee2431924b8231846e7efd1584dfab2739/tools/clang/plugins/ChromeClassTester.h
[modify] https://crrev.com/7b2f6fee2431924b8231846e7efd1584dfab2739/tools/clang/plugins/FindBadConstructsConsumer.cpp
[modify] https://crrev.com/7b2f6fee2431924b8231846e7efd1584dfab2739/tools/clang/plugins/FindBadConstructsConsumer.h

Comment 7 by dcheng@chromium.org, Oct 17 2017

Blockedon: 775741

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3874b35050fc9931eb494e33b321caa0c83719b

commit a3874b35050fc9931eb494e33b321caa0c83719b
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Oct 20 18:04:40 2017

Enable some clang plugin checks in Blink behind a flag

It turns out this flag already exists, so just reuse the
existing one. This also triggered a bug in source location
classification of generated files. The classifier has been
updated to check if something is a generated file before
checking if something is a Blink file. Legacy checks for
generated files in /geni/ and /xcodebuild/ have also been
removed, since those were used by make and xcodebuild,
which we no longer build with.

Bug: 706466
Change-Id: I41c1584d1e077b299c4fe3728f655b98e7e3a6e3
Reviewed-on: https://chromium-review.googlesource.com/724204
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510490}
[modify] https://crrev.com/a3874b35050fc9931eb494e33b321caa0c83719b/tools/clang/plugins/ChromeClassTester.cpp
[modify] https://crrev.com/a3874b35050fc9931eb494e33b321caa0c83719b/tools/clang/plugins/FindBadConstructsConsumer.cpp

Comment 9 by dcheng@chromium.org, Oct 23 2017

Blockedon: 777595

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23f7989bf5deeb36f18f101311ecb12d9c40665e

commit 23f7989bf5deeb36f18f101311ecb12d9c40665e
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 10:20:27 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/platform/loader

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mkwst@chromium.org

Bug: 706466
Change-Id: I939ac1278aba65190f8ab44125dabfacedfba766
Reviewed-on: https://chromium-review.googlesource.com/734764
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511075}
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/SubresourceIntegrityTest.cpp
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/FetchUtils.cpp
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/MemoryCache.h
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/MemoryCacheTest.cpp
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/RawResourceTest.cpp
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/Resource.h
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/ResourceClient.h
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/ResourceFinishObserver.h
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadSchedulerTest.cpp
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoaderTest.cpp
[modify] https://crrev.com/23f7989bf5deeb36f18f101311ecb12d9c40665e/third_party/WebKit/Source/platform/loader/testing/MockResourceClient.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff1802d927874b48e02c6dbe0a6122c2453b064a

commit ff1802d927874b48e02c6dbe0a6122c2453b064a
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 10:38:11 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/websockets

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=yhirano@chromium.org

Bug: 706466
Change-Id: I3fdd4c9427982fdc23579808ddf0d8a209d30e5f
Reviewed-on: https://chromium-review.googlesource.com/734841
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511076}
[modify] https://crrev.com/ff1802d927874b48e02c6dbe0a6122c2453b064a/third_party/WebKit/Source/modules/websockets/CloseEvent.h
[modify] https://crrev.com/ff1802d927874b48e02c6dbe0a6122c2453b064a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.h
[modify] https://crrev.com/ff1802d927874b48e02c6dbe0a6122c2453b064a/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp
[modify] https://crrev.com/ff1802d927874b48e02c6dbe0a6122c2453b064a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/ff1802d927874b48e02c6dbe0a6122c2453b064a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp
[modify] https://crrev.com/ff1802d927874b48e02c6dbe0a6122c2453b064a/third_party/WebKit/Source/modules/websockets/WebPepperSocketChannelClientProxy.h
[modify] https://crrev.com/ff1802d927874b48e02c6dbe0a6122c2453b064a/third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h
[modify] https://crrev.com/ff1802d927874b48e02c6dbe0a6122c2453b064a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f086f3e634b1d83a448ad794c3f59285c7aec38

commit 8f086f3e634b1d83a448ad794c3f59285c7aec38
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 10:40:05 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/filesystem

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=nhiroki@chromium.org

Bug: 706466
Change-Id: Ib411c75860de699901d7e9698149eabf54831c2b
Reviewed-on: https://chromium-review.googlesource.com/734724
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511078}
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DirectoryEntry.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DirectoryEntrySync.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/Entry.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/EntrySync.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/FileEntry.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/FileEntrySync.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/FileWriter.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/FileWriterBase.h
[modify] https://crrev.com/8f086f3e634b1d83a448ad794c3f59285c7aec38/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eb4abcd407c98ed6a6a8658242b2b629fdd2dd3

commit 6eb4abcd407c98ed6a6a8658242b2b629fdd2dd3
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 10:47:52 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/media_capabilities

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug: 706466
Change-Id: Idf97bde3ba26875425473bde4f269c8679a0213b
Reviewed-on: https://chromium-review.googlesource.com/734872
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511081}
[modify] https://crrev.com/6eb4abcd407c98ed6a6a8658242b2b629fdd2dd3/third_party/WebKit/Source/modules/media_capabilities/NavigatorMediaCapabilities.h

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f050f9c58efe6bf5e2ab9bda94fa20619df1114d

commit f050f9c58efe6bf5e2ab9bda94fa20619df1114d
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 10:56:45 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/background_sync

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=iclelland@chromium.org

Bug: 706466
Change-Id: I1929fa598485caa13ca07591eb9699d558000ad3
Reviewed-on: https://chromium-review.googlesource.com/734867
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511084}
[modify] https://crrev.com/f050f9c58efe6bf5e2ab9bda94fa20619df1114d/third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.h
[modify] https://crrev.com/f050f9c58efe6bf5e2ab9bda94fa20619df1114d/third_party/WebKit/Source/modules/background_sync/SyncEvent.h

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b56b9c5a02953eb2cb1b8ca57beb2c0e39a7cd9

commit 5b56b9c5a02953eb2cb1b8ca57beb2c0e39a7cd9
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 10:57:03 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/app_banner

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug: 706466
Change-Id: I24b4c77d7d99b05ea2b6373a2b7f1b0f597067a1
Reviewed-on: https://chromium-review.googlesource.com/734842
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511085}
[modify] https://crrev.com/5b56b9c5a02953eb2cb1b8ca57beb2c0e39a7cd9/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b2c1a17eec56749181d3eccfd1f78823ddee903

commit 6b2c1a17eec56749181d3eccfd1f78823ddee903
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 11:24:10 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/encryptedmedia

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=ddorwin@chromium.org

Bug: 706466
Change-Id: If6f6c503103382d33bb4e2e19fe05bc07e38e007
Reviewed-on: https://chromium-review.googlesource.com/734650
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511091}
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/MediaEncryptedEvent.h
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEvent.h
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.cpp
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/MediaKeysController.h
[modify] https://crrev.com/6b2c1a17eec56749181d3eccfd1f78823ddee903/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06708231f8bb976c650f6704917434d3a4bc8b75

commit 06708231f8bb976c650f6704917434d3a4bc8b75
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 11:31:16 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/public

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mkwst@chromium.org

Bug: 706466
Change-Id: I5ee97a6d67f0715b029cae5703baf5e2f0168675
Reviewed-on: https://chromium-review.googlesource.com/734652
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511092}
[modify] https://crrev.com/06708231f8bb976c650f6704917434d3a4bc8b75/third_party/WebKit/public/platform/WebCompositorMutatorClient.h
[modify] https://crrev.com/06708231f8bb976c650f6704917434d3a4bc8b75/third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h
[modify] https://crrev.com/06708231f8bb976c650f6704917434d3a4bc8b75/third_party/WebKit/public/platform/WebCryptoKeyAlgorithmParams.h
[modify] https://crrev.com/06708231f8bb976c650f6704917434d3a4bc8b75/third_party/WebKit/public/platform/WebGamepadListener.h
[modify] https://crrev.com/06708231f8bb976c650f6704917434d3a4bc8b75/third_party/WebKit/public/platform/WebVideoFrameSubmitter.h
[modify] https://crrev.com/06708231f8bb976c650f6704917434d3a4bc8b75/third_party/WebKit/public/web/WebFormElement.h
[modify] https://crrev.com/06708231f8bb976c650f6704917434d3a4bc8b75/third_party/WebKit/public/web/WebLocalFrame.h
[modify] https://crrev.com/06708231f8bb976c650f6704917434d3a4bc8b75/third_party/WebKit/public/web/WebView.h

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fffad02912b6b3bc3de6b188c95d3a127fcf3d70

commit fffad02912b6b3bc3de6b188c95d3a127fcf3d70
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 11:31:58 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/csspaint

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=ikilpatrick@chromium.org

Bug: 706466
Change-Id: Ic895797351a26d3c899f9e5e7ff47b29b0ba4e21
Reviewed-on: https://chromium-review.googlesource.com/734766
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511093}
[modify] https://crrev.com/fffad02912b6b3bc3de6b188c95d3a127fcf3d70/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h
[modify] https://crrev.com/fffad02912b6b3bc3de6b188c95d3a127fcf3d70/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h
[modify] https://crrev.com/fffad02912b6b3bc3de6b188c95d3a127fcf3d70/third_party/WebKit/Source/modules/csspaint/DocumentPaintDefinition.h
[modify] https://crrev.com/fffad02912b6b3bc3de6b188c95d3a127fcf3d70/third_party/WebKit/Source/modules/csspaint/PaintWorklet.h
[modify] https://crrev.com/fffad02912b6b3bc3de6b188c95d3a127fcf3d70/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.h
[modify] https://crrev.com/fffad02912b6b3bc3de6b188c95d3a127fcf3d70/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7

commit 6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 11:35:22 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/fetch

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=yhirano@chromium.org

Bug: 706466
Change-Id: Id60aaefb39320f8aa497a452092839507a3f656d
Reviewed-on: https://chromium-review.googlesource.com/735501
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511094}
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/Body.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandle.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandleTest.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/FetchDataLoader.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/FetchManager.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/FormDataBytesConsumer.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/FormDataBytesConsumer.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/GlobalFetch.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/MultipartParser.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumer.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumer.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/Request.h
[modify] https://crrev.com/6d8cec5fd8d901eccfa51cf69b3be11cd46d86b7/third_party/WebKit/Source/modules/fetch/Response.h

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d

commit 33fe04d8e59d2e1cc933de77b72f6fdbca530d3d
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 11:47:10 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/html/media

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug: 706466
Change-Id: Id1b87216e2eb2b042f00db92c01f6acf0083f0ef
Reviewed-on: https://chromium-review.googlesource.com/735503
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511096}
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.h
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/HTMLMediaElement.h
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/HTMLMediaElementTest.cpp
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/HTMLVideoElement.h
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/MediaControls.h
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/MediaCustomControlsFullscreenDetector.h
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/MediaRemotingElements.cpp
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/MediaRemotingElements.h
[modify] https://crrev.com/33fe04d8e59d2e1cc933de77b72f6fdbca530d3d/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.h

Project Member

Comment 21 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e30bda0b000277d43ff09f9736a20822d444d52d

commit e30bda0b000277d43ff09f9736a20822d444d52d
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 11:54:05 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/serviceworkers

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=kinuko@chromium.org

Bug: 706466
Change-Id: Ifebe5256fcabd50540f01d08ae5205c1eb113879
Reviewed-on: https://chromium-review.googlesource.com/734869
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511097}
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.h
[modify] https://crrev.com/e30bda0b000277d43ff09f9736a20822d444d52d/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

Project Member

Comment 22 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40d5e67c1f93f86b0788d1acd2772ea3c543133b

commit 40d5e67c1f93f86b0788d1acd2772ea3c543133b
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:00:38 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/permissions

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug: 706466
Change-Id: I56fec15ca0e68f03ceb5458271b78f45edb7d408
Reviewed-on: https://chromium-review.googlesource.com/734874
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511099}
[modify] https://crrev.com/40d5e67c1f93f86b0788d1acd2772ea3c543133b/third_party/WebKit/Source/modules/permissions/NavigatorPermissions.h
[modify] https://crrev.com/40d5e67c1f93f86b0788d1acd2772ea3c543133b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
[modify] https://crrev.com/40d5e67c1f93f86b0788d1acd2772ea3c543133b/third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.h

Project Member

Comment 23 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a4a3271df315ca189c9a5335e3bfc2656103804

commit 9a4a3271df315ca189c9a5335e3bfc2656103804
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:03:20 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/beacon

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=tyoshino@chromium.org

Bug: 706466
Change-Id: Ie7f66ceab2dff76e6cc3b6617e2c6a32ab309a55
Reviewed-on: https://chromium-review.googlesource.com/734765
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511101}
[modify] https://crrev.com/9a4a3271df315ca189c9a5335e3bfc2656103804/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.h

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cba5746702645eb2b4dbe05d3724f91b25f12771

commit cba5746702645eb2b4dbe05d3724f91b25f12771
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:04:44 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/imagecapture

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mcasas@chromium.org

Bug: 706466
Change-Id: Icc59ca96b2d5653fa410bf6d36454d0e88dff987
Reviewed-on: https://chromium-review.googlesource.com/734654
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511103}
[modify] https://crrev.com/cba5746702645eb2b4dbe05d3724f91b25f12771/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10c283fbe301cbbdfd8c0a719d7ced3170750f3f

commit 10c283fbe301cbbdfd8c0a719d7ced3170750f3f
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:06:36 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/vr

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=bajones@chromium.org

Bug: 706466
Change-Id: Ic214a1413b78cb9c527835f7c4c2f14d9337582e
Reviewed-on: https://chromium-review.googlesource.com/734873
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511105}
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/VRDisplayEvent.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/latest/VR.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/latest/VRDevice.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/latest/VRDeviceEvent.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/latest/VRFrameOfReference.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/latest/VRSession.h
[modify] https://crrev.com/10c283fbe301cbbdfd8c0a719d7ced3170750f3f/third_party/WebKit/Source/modules/vr/latest/VRSessionEvent.h

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d34fe234d2266f66788b2661355bdf573320765d

commit d34fe234d2266f66788b2661355bdf573320765d
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:07:28 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/html/forms

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=keishi@chromium.org

Bug: 706466
Change-Id: Ia6d2ca502fe7f6ee8d1bf80535272cf20b774b4e
Reviewed-on: https://chromium-review.googlesource.com/734658
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511106}
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ClearButtonElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ColorChooser.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ColorChooserClient.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ColorChooserPopupUIController.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ColorChooserUIController.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ColorInputType.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/DateTimeChooserClient.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/DateTimeChooserImpl.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/DateTimeEditElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/DateTimeFieldElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ExternalDateTimeChooser.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/FileInputType.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/FormData.cpp
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLFormControlElementTest.cpp
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLFormControlsCollection.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLFormElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLInputElement.cpp
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLInputElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLOptGroupElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLOptionElement.cpp
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLOptionElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLOutputElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLSelectElement.cpp
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HTMLSelectElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/HiddenInputType.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ImageInputType.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/InputTypeView.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.cpp
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/LabelableElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/LabelsNodeList.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ListedElement.cpp
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/ListedElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/RadioNodeList.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/RangeInputType.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/SpinButtonElement.h
[modify] https://crrev.com/d34fe234d2266f66788b2661355bdf573320765d/third_party/WebKit/Source/core/html/forms/TextFieldInputType.h

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/399b53a5f8e9a31a4958b10bfbdd5a4df159f9be

commit 399b53a5f8e9a31a4958b10bfbdd5a4df159f9be
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:10:01 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/installedapp

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mgiuca@chromium.org

Bug: 706466
Change-Id: Ib18f0324f2ee1a9766c0de68d14748a1d53a78d8
Reviewed-on: https://chromium-review.googlesource.com/734657
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511107}
[modify] https://crrev.com/399b53a5f8e9a31a4958b10bfbdd5a4df159f9be/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h
[modify] https://crrev.com/399b53a5f8e9a31a4958b10bfbdd5a4df159f9be/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.h

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa05b307f5f32a1fd28b2ed2324a9eea51ad365

commit efa05b307f5f32a1fd28b2ed2324a9eea51ad365
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:10:14 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/mediasession

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug: 706466
Change-Id: I98496c32f019f0ef2faa30efda53cf3177fc5d4f
Reviewed-on: https://chromium-review.googlesource.com/734870
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511108}
[modify] https://crrev.com/efa05b307f5f32a1fd28b2ed2324a9eea51ad365/third_party/WebKit/Source/modules/mediasession/MediaSession.h
[modify] https://crrev.com/efa05b307f5f32a1fd28b2ed2324a9eea51ad365/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eae08a831d7ef955bd2768c7777cbb6885c0492

commit 1eae08a831d7ef955bd2768c7777cbb6885c0492
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:13:03 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/mediacapturefromelement

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=emircan@chromium.org

Bug: 706466
Change-Id: I138ac6545fb06717eea96b8f34d43396ab5d5b71
Reviewed-on: https://chromium-review.googlesource.com/734725
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511110}
[modify] https://crrev.com/1eae08a831d7ef955bd2768c7777cbb6885c0492/third_party/WebKit/Source/modules/mediacapturefromelement/AutoCanvasDrawListener.h
[modify] https://crrev.com/1eae08a831d7ef955bd2768c7777cbb6885c0492/third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.h
[modify] https://crrev.com/1eae08a831d7ef955bd2768c7777cbb6885c0492/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp
[modify] https://crrev.com/1eae08a831d7ef955bd2768c7777cbb6885c0492/third_party/WebKit/Source/modules/mediacapturefromelement/OnRequestCanvasDrawListener.h
[modify] https://crrev.com/1eae08a831d7ef955bd2768c7777cbb6885c0492/third_party/WebKit/Source/modules/mediacapturefromelement/TimedCanvasDrawListener.h

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef3e9c91f808f922b2310405a62122ce0eabda4

commit 2ef3e9c91f808f922b2310405a62122ce0eabda4
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:16:31 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/background_fetch

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=peter@chromium.org

Bug: 706466
Change-Id: I08b8f6b57fc9ddf006439f8760850f33812eef15
Reviewed-on: https://chromium-review.googlesource.com/734843
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511112}
[modify] https://crrev.com/2ef3e9c91f808f922b2310405a62122ce0eabda4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.h
[modify] https://crrev.com/2ef3e9c91f808f922b2310405a62122ce0eabda4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.h
[modify] https://crrev.com/2ef3e9c91f808f922b2310405a62122ce0eabda4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.h
[modify] https://crrev.com/2ef3e9c91f808f922b2310405a62122ce0eabda4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.h
[modify] https://crrev.com/2ef3e9c91f808f922b2310405a62122ce0eabda4/third_party/WebKit/Source/modules/background_fetch/ServiceWorkerRegistrationBackgroundFetch.h

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d8d2788d9cb34cb9a55f068d8311b88365d17ef

commit 5d8d2788d9cb34cb9a55f068d8311b88365d17ef
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:34:36 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/html/parser

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=csharrison@chromium.org

Bug: 706466
Change-Id: If119660ce5ca2ced492e386504b188c8f2844177
Reviewed-on: https://chromium-review.googlesource.com/734868
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511115}
[modify] https://crrev.com/5d8d2788d9cb34cb9a55f068d8311b88365d17ef/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h
[modify] https://crrev.com/5d8d2788d9cb34cb9a55f068d8311b88365d17ef/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h
[modify] https://crrev.com/5d8d2788d9cb34cb9a55f068d8311b88365d17ef/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h
[modify] https://crrev.com/5d8d2788d9cb34cb9a55f068d8311b88365d17ef/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunnerHost.h
[modify] https://crrev.com/5d8d2788d9cb34cb9a55f068d8311b88365d17ef/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2110fa883f38e45b3d82cd3a60b925b13fd519ef

commit 2110fa883f38e45b3d82cd3a60b925b13fd519ef
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:40:23 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/gamepad

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=bajones@chromium.org

Bug: 706466
Change-Id: Ic690b2cc1334bc19e3cf4083da6408ae5bb9f732
Reviewed-on: https://chromium-review.googlesource.com/735502
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511117}
[modify] https://crrev.com/2110fa883f38e45b3d82cd3a60b925b13fd519ef/third_party/WebKit/Source/modules/gamepad/GamepadDispatcher.h
[modify] https://crrev.com/2110fa883f38e45b3d82cd3a60b925b13fd519ef/third_party/WebKit/Source/modules/gamepad/GamepadEvent.h
[modify] https://crrev.com/2110fa883f38e45b3d82cd3a60b925b13fd519ef/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/752685fe19a64649f98dab327f618450a89847cc

commit 752685fe19a64649f98dab327f618450a89847cc
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:42:48 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/compositorworker

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=kinuko@chromium.org

Bug: 706466
Change-Id: I55fa6b2d3e1ab384fd803ccf6cdfecf9045337a9
Reviewed-on: https://chromium-review.googlesource.com/734871
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511118}
[modify] https://crrev.com/752685fe19a64649f98dab327f618450a89847cc/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
[modify] https://crrev.com/752685fe19a64649f98dab327f618450a89847cc/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.h
[modify] https://crrev.com/752685fe19a64649f98dab327f618450a89847cc/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.h
[modify] https://crrev.com/752685fe19a64649f98dab327f618450a89847cc/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletProxyClientImpl.h
[modify] https://crrev.com/752685fe19a64649f98dab327f618450a89847cc/third_party/WebKit/Source/modules/compositorworker/Animator.h
[modify] https://crrev.com/752685fe19a64649f98dab327f618450a89847cc/third_party/WebKit/Source/modules/compositorworker/AnimatorDefinition.h
[modify] https://crrev.com/752685fe19a64649f98dab327f618450a89847cc/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
[modify] https://crrev.com/752685fe19a64649f98dab327f618450a89847cc/third_party/WebKit/Source/modules/compositorworker/WorkletAnimation.h

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f791eed0eae13a6f92cd49b3684b43daada63894

commit f791eed0eae13a6f92cd49b3684b43daada63894
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:44:28 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/loader

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mkwst@chromium.org

Bug: 706466
Change-Id: I265d054c696c6ef6fc4bd419e1ac2adddd704766
Reviewed-on: https://chromium-review.googlesource.com/734655
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511119}
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/AllowedByNosniffTest.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/BaseFetchContext.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/BaseFetchContextTest.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/DocumentLoader.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/DocumentLoaderTest.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/IdlenessDetectorTest.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/LinkLoader.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/LinkLoaderClient.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/TextTrackLoader.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/ThreadableLoadingContext.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/WorkerFetchContext.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/WorkletScriptLoader.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/modulescript/DocumentModuleScriptFetcher.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerRegistry.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/modulescript/WorkletModuleScriptFetcher.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/private/PrerenderHandle.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/DocumentResource.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/ImageResource.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.h
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp
[modify] https://crrev.com/f791eed0eae13a6f92cd49b3684b43daada63894/third_party/WebKit/Source/core/loader/resource/StyleSheetResourceClient.h

Project Member

Comment 35 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/044d580336daa7e3754138c49a74065bd7010dc6

commit 044d580336daa7e3754138c49a74065bd7010dc6
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 12:50:57 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/netinfo

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=jkarlin@chromium.org

Bug: 706466
Change-Id: I5bf6ff27f8b0eb9efeedec79335729aa75004fb7
Reviewed-on: https://chromium-review.googlesource.com/734844
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511121}
[modify] https://crrev.com/044d580336daa7e3754138c49a74065bd7010dc6/third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.h
[modify] https://crrev.com/044d580336daa7e3754138c49a74065bd7010dc6/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
[modify] https://crrev.com/044d580336daa7e3754138c49a74065bd7010dc6/third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.h

Project Member

Comment 36 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bff7ae24b455e9f9d84059d234cc289f92a70027

commit bff7ae24b455e9f9d84059d234cc289f92a70027
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 13:08:00 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/animation

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=alancutter@chromium.org

Bug: 706466
Change-Id: Ib44ed9b7bfd6dfec9ce0434031a1dbe7ee72a62f
Reviewed-on: https://chromium-review.googlesource.com/735504
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511125}
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/Animation.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/AnimationEffectReadOnlyTest.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/CSSDefaultInterpolationType.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/DocumentTimeline.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/DocumentTimelineTest.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/EffectStackTest.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/InertEffect.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/SVGValueInterpolationType.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/ScrollTimeline.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/StringKeyframe.h
[modify] https://crrev.com/bff7ae24b455e9f9d84059d234cc289f92a70027/third_party/WebKit/Source/core/animation/css/CSSAnimations.h

Project Member

Comment 37 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad22d4b0caf399c5fd0d543841789616a0a70fe2

commit ad22d4b0caf399c5fd0d543841789616a0a70fe2
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 14:21:54 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/platform/bindings

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=jbroman@chromium.org

Bug: 706466
Change-Id: Id8719acdb9963fd479aee96f524a4729143eebd0
Reviewed-on: https://chromium-review.googlesource.com/734651
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511136}
[modify] https://crrev.com/ad22d4b0caf399c5fd0d543841789616a0a70fe2/third_party/WebKit/Source/platform/bindings/CallbackFunctionBase.h
[modify] https://crrev.com/ad22d4b0caf399c5fd0d543841789616a0a70fe2/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp
[modify] https://crrev.com/ad22d4b0caf399c5fd0d543841789616a0a70fe2/third_party/WebKit/Source/platform/bindings/ScriptWrappableVisitor.cpp
[modify] https://crrev.com/ad22d4b0caf399c5fd0d543841789616a0a70fe2/third_party/WebKit/Source/platform/bindings/ScriptWrappableVisitor.h
[modify] https://crrev.com/ad22d4b0caf399c5fd0d543841789616a0a70fe2/third_party/WebKit/Source/platform/bindings/V8DOMWrapper.h

Project Member

Comment 38 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1

commit 8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 14:30:21 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/workers

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=nhiroki@chromium.org

Bug: 706466
Change-Id: I5083414c08c9f029d83b79601965a61e06bd406f
Reviewed-on: https://chromium-review.googlesource.com/735519
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511142}
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/AbstractWorker.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/DedicatedWorker.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/SharedWorker.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkerClients.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkerContentSettingsClient.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkerEventQueue.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkletGlobalScope.h
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkletModuleResponsesMap.cpp
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkletModuleResponsesMapProxy.cpp
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkletModuleResponsesMapTest.cpp
[modify] https://crrev.com/8a06dbd5ebcbe7e6fcc5411f448986bea9b5c8f1/third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.h

Project Member

Comment 39 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea94a4819a44a032a778a3f00f68996c3e902c7a

commit ea94a4819a44a032a778a3f00f68996c3e902c7a
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 16:17:20 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/bluetooth

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=scheib@chromium.org

Bug: 706466
Change-Id: I8e503488c125d96ca3693760907d18fd28acbe05
Reviewed-on: https://chromium-review.googlesource.com/734902
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511169}
[modify] https://crrev.com/ea94a4819a44a032a778a3f00f68996c3e902c7a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
[modify] https://crrev.com/ea94a4819a44a032a778a3f00f68996c3e902c7a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/ea94a4819a44a032a778a3f00f68996c3e902c7a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.h
[modify] https://crrev.com/ea94a4819a44a032a778a3f00f68996c3e902c7a/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.h

Project Member

Comment 40 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e45bd89263306db3eac9599a1cf51f95cbf95296

commit e45bd89263306db3eac9599a1cf51f95cbf95296
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 16:55:16 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/modules/broadcastchannel

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=mek@chromium.org

Bug: 706466
Change-Id: I3770d73f9fbd8607e5acf6233a84992d3aac6ef0
Reviewed-on: https://chromium-review.googlesource.com/735500
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511179}
[modify] https://crrev.com/e45bd89263306db3eac9599a1cf51f95cbf95296/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.h

Project Member

Comment 41 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/971dc566137354ccef69b3145d367e571d71fe39

commit 971dc566137354ccef69b3145d367e571d71fe39
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 16:56:16 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/platform/audio

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=rtoy@chromium.org

Bug: 706466
Change-Id: Ie39ac4e3ddf9f7d4619021c6526f54a5d78471e0
Reviewed-on: https://chromium-review.googlesource.com/734866
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511180}
[modify] https://crrev.com/971dc566137354ccef69b3145d367e571d71fe39/third_party/WebKit/Source/platform/audio/AudioSourceProviderClient.h

Project Member

Comment 42 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adbf8e35b6251002609fb922f349d1de2398293f

commit adbf8e35b6251002609fb922f349d1de2398293f
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 17:14:12 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/paint

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=wangxianzhu@chromium.org

Bug: 706466
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I458d58a50318c67a4a98d2db60f735c3db37edc3
Reviewed-on: https://chromium-review.googlesource.com/734876
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511189}
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/BoxPainterBase.cpp
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/PaintLayerResourceInfo.h
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/PaintTiming.h
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.h
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositorTest.cpp
[modify] https://crrev.com/adbf8e35b6251002609fb922f349d1de2398293f/third_party/WebKit/Source/core/paint/ng/ng_paint_fragment.h

Project Member

Comment 43 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3704146ff021d9e035a2fda201fb983811c10582

commit 3704146ff021d9e035a2fda201fb983811c10582
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 20:25:08 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/inspector

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=caseq@chromium.org

Bug: 706466
Change-Id: I1dd236bc636ee0817dcede5e458195bf91eef75b
Reviewed-on: https://chromium-review.googlesource.com/734656
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511248}
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/DOMEditor.cpp
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorAuditsAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorDOMSnapshotAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.cpp
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorLogAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
[modify] https://crrev.com/3704146ff021d9e035a2fda201fb983811c10582/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h

Project Member

Comment 44 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e736c63e7f5670580de0db37a6d7e2feda98250

commit 6e736c63e7f5670580de0db37a6d7e2feda98250
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 24 21:17:22 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/layout/ng

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=glebl@chromium.org

Bug: 706466
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I6da11c9de251677603d0c44090c789257123d008
Reviewed-on: https://chromium-review.googlesource.com/734865
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511261}
[modify] https://crrev.com/6e736c63e7f5670580de0db37a6d7e2feda98250/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc
[modify] https://crrev.com/6e736c63e7f5670580de0db37a6d7e2feda98250/third_party/WebKit/Source/core/layout/ng/ng_block_child_iterator_test.cc
[modify] https://crrev.com/6e736c63e7f5670580de0db37a6d7e2feda98250/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h
[modify] https://crrev.com/6e736c63e7f5670580de0db37a6d7e2feda98250/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc
[modify] https://crrev.com/6e736c63e7f5670580de0db37a6d7e2feda98250/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
[modify] https://crrev.com/6e736c63e7f5670580de0db37a6d7e2feda98250/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e8587301d2ac0a10184eb91d4caeae95a3c396

commit 78e8587301d2ac0a10184eb91d4caeae95a3c396
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Oct 25 14:36:07 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/Source/core/layout

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=schenney@chromium.org

Bug: 706466
Change-Id: I7a57e1c05893cf5e381453a5ec0879fc4dab092b
Reviewed-on: https://chromium-review.googlesource.com/734864
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511450}
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/ColumnBalancer.h
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutFlowThread.h
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutReplaced.h
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutScrollbar.h
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutTableRowTest.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/line/InlineBox.h
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp
[modify] https://crrev.com/78e8587301d2ac0a10184eb91d4caeae95a3c396/third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp

Project Member

Comment 46 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ad7f725ff737d234b4ea71a84662ed968aec21

commit b5ad7f725ff737d234b4ea71a84662ed968aec21
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Oct 25 20:23:53 2017

Automated fixes from the Chrome clang plugin in //third_party/WebKit/public/platform/modules/device_orientation

- normalizes uses of virtual / override / final
- ensures that auto is const / pointer / reference qualified as
  appropriate

This CL was uploaded by git cl split.

R=timvolodine@chromium.org

Bug: 706466
Change-Id: Ieb1a0f8aaf5522cdf285d15969f1f07acebf8b2e
Reviewed-on: https://chromium-review.googlesource.com/734653
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511558}
[modify] https://crrev.com/b5ad7f725ff737d234b4ea71a84662ed968aec21/third_party/WebKit/public/platform/modules/device_orientation/WebDeviceMotionListener.h
[modify] https://crrev.com/b5ad7f725ff737d234b4ea71a84662ed968aec21/third_party/WebKit/public/platform/modules/device_orientation/WebDeviceOrientationListener.h

Project Member

Comment 47 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3

commit 028491e1f9ac0e6b40e8f4495e8566b0fd9304b3
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 25 03:17:54 2018

Chrome style plugin: apply fixits in //third_party/blink/renderer/platform

Bug: 706466
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2d8a62e693af7a3c335f3401817988deae9f87bb
Reviewed-on: https://chromium-review.googlesource.com/1027001
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553436}
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/animation/animation_translation_util.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/animation/compositor_animation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/animation/compositor_filter_keyframe.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/animation/compositor_transform_keyframe.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/animation/timing_function.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/blob/blob_data_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/exported/web_coalesced_input_event.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/exported/web_media_constraints.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/exported/web_media_stream_track.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/exported/web_speech_synthesizer_client_impl.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/feature_policy/feature_policy_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/font_cache.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/font_data_for_range_set.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/font_fallback_iterator.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/font_selector.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/font_selector_client.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/script_run_iterator.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/segmented_font_data.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/shaping/shape_result.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/begin_frame_provider.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/bitmap_image_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/canvas_resource.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/compositing/chunk_to_layer_mapper_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/compositor_animator.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/compositor_mutator_client.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/compositor_mutator_impl.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/contiguous_container_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer_software_rendering_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer_test_helpers.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/image_observer.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/logging_canvas.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_impl.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_impl.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/paint/foreign_layer_display_item.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/paint/paint_chunk.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/paint/paint_chunker.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/paint/scroll_hit_test_display_item.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/profiling_canvas.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/static_bitmap_image.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/test/fake_web_graphics_context_3d_provider.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/graphics/test/mock_image_decoder.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/heap/gc_task_runner.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/heap/heap_page.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/heap/heap_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/heap/marking_verifier.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/heap/marking_visitor.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/heap/thread_state.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/image-decoders/gif/gif_image_decoder.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/image-decoders/webp/webp_image_decoder.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/instrumentation/tracing/memory_cache_dump_provider.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/instrumentation/tracing/traced_value.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/instrumentation/tracing/web_process_memory_dump_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/layout_locale_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/lifecycle_context_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/loader/fetch/source_keyed_cached_metadata_handler_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/long_task_detector_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/mediastream/media_stream_descriptor.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/mediastream/media_stream_descriptor.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/memory_coordinator.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/mojo/string16_mojom_traits.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/network/mime/mock_mime_registry.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/network/network_state_notifier_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/network/parsed_content_header_field_parameters_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/peerconnection/rtc_stats_response_base.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/prerender_client.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/common/throttling/cpu_time_budget_pool.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/test/fake_frame_scheduler.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/test/task_queue_manager_for_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scheduler/util/tracing_helper.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scroll/programmatic_scroll_animator.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scroll/scroll_animator.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scroll/scroll_animator_base.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scroll/scroll_animator_compositor_coordinator.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scroll/scrollable_area.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/scroll/scrollbar.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/shared_buffer.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/testing/compositor_test.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/timer_test.cc
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/transforms/identity_transform_operation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/transforms/interpolated_transform_operation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/transforms/matrix_3d_transform_operation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/transforms/matrix_transform_operation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/transforms/perspective_transform_operation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/transforms/rotate_transform_operation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/transforms/scale_transform_operation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/transforms/skew_transform_operation.h
[modify] https://crrev.com/028491e1f9ac0e6b40e8f4495e8566b0fd9304b3/third_party/blink/renderer/platform/wtf/vector_test.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c

commit ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 25 03:37:44 2018

Chrome style plugin: apply fixits in //third_party/blink/renderer/modules

Bug: 706466
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2241db1730ea7a11e13801eea2e6d3a6662f4105
Reviewed-on: https://chromium-review.googlesource.com/1027114
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553443}
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_aria_grid_row.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_image_map_link.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_menu_list_option.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_menu_list_popup.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_node_object.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_sparse_attribute_setter.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_spin_button.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_table.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_table_cell.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_table_column.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_table_row.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/ax_virtual_object.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/accessibility/testing/accessibility_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client_impl.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/audio_output_devices/audio_output_device_client.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/audio_output_devices/audio_output_device_client_impl.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/audio_output_devices/html_media_element_audio_output_device.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/audio_output_devices/html_media_element_audio_output_device.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/background_fetch/background_fetch_fetch.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/background_sync/sync_manager.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/battery/battery_manager.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/battery/navigator_battery.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/bluetooth/bluetooth.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/budget/budget_service.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/budget/navigator_budget.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/budget/worker_navigator_budget.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/cachestorage/cache.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/cachestorage/cache_storage.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/cachestorage/cache_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/cachestorage/inspector_cache_storage_agent.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/cachestorage/inspector_cache_storage_agent.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_state.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/clipboard/clipboard.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/clipboard/clipboard_promise.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/clipboard/navigator_clipboard.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/cookie_store/cookie_store.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/credentialmanager/authenticator_assertion_response.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/credentialmanager/authenticator_attestation_response.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/credentialmanager/authenticator_response.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/credentialmanager/credential.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/credentialmanager/credentials_container_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/credentialmanager/navigator_credentials.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/crypto/crypto.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/crypto/crypto_key.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/crypto/crypto_key.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/crypto/crypto_result_impl.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/crypto/crypto_result_impl.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/crypto/dom_window_crypto.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/crypto/worker_global_scope_crypto.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/csspaint/paint_size.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_acceleration.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_motion_controller.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_motion_dispatcher.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_motion_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_orientation_absolute_controller.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_orientation_controller.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_orientation_dispatcher.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_orientation_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_orientation_inspector_agent.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/device_orientation/device_rotation_rate.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/donottrack/navigator_do_not_track.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/encoding/text_decoder.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/encoding/text_encoder.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/encryptedmedia/media_key_status_map.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/encryptedmedia/media_key_system_access.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/encryptedmedia/media_keys.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/eventsource/event_source.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/eventsource/event_source_parser.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/eventsource/event_source_parser_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/filesystem/directory_reader_base.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/filesystem/dom_file_system_base.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/filesystem/entry_base.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/gamepad/gamepad.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/gamepad/gamepad_list.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/gamepad/gamepad_pose.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/geolocation/geolocation.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/geolocation/geolocation_watchers.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/geolocation/navigator_geolocation.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/imagecapture/photo_capabilities.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_cursor.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_index.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_key_range.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_object_store.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_observation.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_observer.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_observer_changes.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/idb_version_change_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/installedapp/related_application.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/keyboard/navigator_keyboard.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/locks/lock.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/locks/lock.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/locks/lock_manager.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/locks/lock_manager.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_animation_event_listener.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_div_element.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_element_base.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_loading_panel_element.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_slider_element.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_slider_element.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/media_controls_media_event_listener.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/media_controls_orientation_lock_delegate.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/media_controls_orientation_lock_delegate.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/media_controls_rotate_to_fullscreen_delegate.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/media_controls/media_controls_window_event_listener.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediarecorder/blob_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediarecorder/media_recorder.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediasession/media_metadata.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediasource/media_source.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediasource/source_buffer.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediasource/source_buffer_list.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediasource/source_buffer_track_base_supplement.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediasource/track_default.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediasource/track_default_list.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/media_devices.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/media_devices_test.cc
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/media_stream.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/media_stream_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/media_stream_track.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/media_stream_track_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/navigator_user_media.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/user_media_controller.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/mediastream/user_media_request.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/navigatorcontentutils/testing/navigator_content_utils_client_mock.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/nfc/nfc.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/notifications/notification.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/notifications/notification_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/notifications/notification_manager.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/payments/abort_payment_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/payments/abort_payment_respond_with_observer.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/payments/can_make_payment_event.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/payments/can_make_payment_respond_with_observer.h
[modify] https://crrev.com/ebc10f07e1fc46e03f7fc676fd562bedc4d1c18c/third_party/blink/renderer/modules/payments/html_iframe_element_payments.h
[modify] https://crrev.com/ebc10

Project Member

Comment 49 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51459d663d841c6430747aec97be9f7e7a7ca41f

commit 51459d663d841c6430747aec97be9f7e7a7ca41f
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 25 04:15:01 2018

Chrome style plugin: apply fixits in //third_party/blink/renderer/bindings

Bug: 706466
Change-Id: I6f9db18aaca1c24a3da055907786943e55ea36d9
Reviewed-on: https://chromium-review.googlesource.com/1027115
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553447}
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/activity_logger_test.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/custom/v8_custom_xpath_ns_resolver.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/initialize_v8_extras_binding.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/script_module_test.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/script_promise.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/script_promise_property_base.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/script_promise_property_test.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/v8_abstract_event_listener.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.cc
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/v8_intersection_observer_delegate.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/v8_lazy_event_listener.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/v8_v0_custom_element_lifecycle_callbacks.h
[modify] https://crrev.com/51459d663d841c6430747aec97be9f7e7a7ca41f/third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc

Project Member

Comment 50 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f87f441933cf81be2eb29a486c4180de8e1c8e03

commit f87f441933cf81be2eb29a486c4180de8e1c8e03
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 25 05:27:05 2018

Chrome style plugin: apply fixits in //third_party/blink/renderer/controller

Bug: 706466
Change-Id: Ibfca7f6baf3fcb475dd3bb78f3453624ef79c83c
Reviewed-on: https://chromium-review.googlesource.com/1027118
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553458}
[modify] https://crrev.com/f87f441933cf81be2eb29a486c4180de8e1c8e03/third_party/blink/renderer/controller/dev_tools_frontend_impl.h
[modify] https://crrev.com/f87f441933cf81be2eb29a486c4180de8e1c8e03/third_party/blink/renderer/controller/oom_intervention_impl_test.cc

Project Member

Comment 51 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a288d82b60800d5492bdca83f3da63e86ce615f

commit 2a288d82b60800d5492bdca83f3da63e86ce615f
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 25 06:39:31 2018

Chrome style plugin: apply fixits in //third_party/blink/renderer/core

Bug: 706466
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6bfda065d7d4026ea92409b198dc7b7f7cdca91b
Reviewed-on: https://chromium-review.googlesource.com/1027083
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553466}
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/animation/effect_input.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/active_style_sheets.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/cssom/css_numeric_value.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/invalidation/style_invalidator.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/properties/longhands/webkit_text_emphasis_position_custom.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/resolver/scoped_style_resolver.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/selector_query.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/css/style_engine.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/dom/accessible_node.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/dom/document_statistics_collector.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/dom/events/event_listener_map.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/dom/first_letter_pseudo_element.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/dom/live_node_list_registry.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/editing_utilities.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/link_selection_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/markers/sorted_document_marker_list_editor.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/markers/spell_check_marker_list_impl.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/markers/suggestion_marker_list_impl.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/markers/text_match_marker_list_impl.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/markers/unsorted_document_marker_list_editor.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/state_machines/backspace_state_machine.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/state_machines/backward_grapheme_boundary_state_machine.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/state_machines/forward_grapheme_boundary_state_machine.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/state_machines/state_machine_test_util.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/editing/state_machines/text_segmentation_machine_state.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/events/input_event.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/events/web_input_event_conversion.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/exported/web_searchable_form_data.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/frame/csp/csp_directive_list_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/frame/csp/media_list_directive_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/frame/csp/source_list_directive.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/frame/csp/source_list_directive_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/frame/layout_subtree_root_list.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/html/custom/custom_element_reaction_test_helpers.h
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/html/track/text_track_cue_list.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/input/touch_event_manager.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/layout/ng/exclusions/ng_exclusion_space.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/layout/ng/inline/ng_inline_fragment_traversal_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/page/chrome_client_impl.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/paint/object_paint_invalidator.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/resize_observer/resize_observer.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/script/worklet_modulator_impl.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/streams/readable_stream_operations_test.cc
[modify] https://crrev.com/2a288d82b60800d5492bdca83f3da63e86ce615f/third_party/blink/renderer/core/testing/internals.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe84915b1808c7a24cb606462c2584a61d1f1bd0

commit fe84915b1808c7a24cb606462c2584a61d1f1bd0
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 25 06:43:23 2018

Chrome style plugin: apply fixits in //third_party/blink/public

Bug: 706466
Change-Id: I418253ffc3cb314466beb3cad6eb0f36b099f28c
Reviewed-on: https://chromium-review.googlesource.com/1027117
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553470}
[modify] https://crrev.com/fe84915b1808c7a24cb606462c2584a61d1f1bd0/third_party/blink/public/platform/web_video_frame_submitter.h

Project Member

Comment 53 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733c4fa5dd0e68bd38afb085819b6c7230b68410

commit 733c4fa5dd0e68bd38afb085819b6c7230b68410
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 25 15:28:43 2018

Chrome style plugin: fix and enable a subset of the warnings in Blink

This CL includes manual fixes for the remaining warnings that
WeakPtrFactory should be the last member.

After this, a subset of the Chrome style plugin warnings are also enabled in
Blink:
- prompting that override/final are appropriately used
- ensuring that auto is qualified with * or & as needed
- kMaxValue is, in fact, the max value in an enum

Bug: 706466
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I296fb9be0214632a76d7faf739ee606383f50383
Reviewed-on: https://chromium-review.googlesource.com/1027437
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553567}
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/build/config/clang/BUILD.gn
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/core/html/parser/background_html_parser.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/core/html/parser/background_html_parser.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/core/html/parser/html_document_parser.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/core/html/parser/html_document_parser.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/core/layout/layout_theme_mac.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/core/loader/image_loader.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/fonts/shaping/shape_cache.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/graphics/video_frame_submitter.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/mac/scroll_animator_mac.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/mac/theme_mac.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/text/hyphenation/hyphenator_aosp.cc
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/text/locale_mac.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/text/locale_win.h
[modify] https://crrev.com/733c4fa5dd0e68bd38afb085819b6c7230b68410/third_party/blink/renderer/platform/text/mac/hyphenation_mac.cc

Project Member

Comment 54 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25be427c7323ce7eb7cf809070f4745548d45194

commit 25be427c7323ce7eb7cf809070f4745548d45194
Author: Daniel Cheng <dcheng@chromium.org>
Date: Thu Apr 26 20:44:44 2018

Chrome style plugin: always enable checks for Blink and Enum::kMaxValue.

These options are always on now, so default them to on in the plugin so
they can be removed in a followup.

Also cleans up a conditional check for Blink code in the legacy
//third_party/WebKit directory.

Bug:  482580 , 622551, 706466
Change-Id: I6d53d53cac11831b3bd10a4086c8daae0e67ddfc
Reviewed-on: https://chromium-review.googlesource.com/1030973
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554140}
[modify] https://crrev.com/25be427c7323ce7eb7cf809070f4745548d45194/tools/clang/plugins/ChromeClassTester.cpp
[modify] https://crrev.com/25be427c7323ce7eb7cf809070f4745548d45194/tools/clang/plugins/FindBadConstructsAction.cpp
[modify] https://crrev.com/25be427c7323ce7eb7cf809070f4745548d45194/tools/clang/plugins/FindBadConstructsConsumer.cpp
[modify] https://crrev.com/25be427c7323ce7eb7cf809070f4745548d45194/tools/clang/plugins/Options.h

►

Issue 706466 link

Issue metadata

Enable (more) clang plugin checks in Blink

Issue description

Comment 1 by dcheng@chromium.org, Mar 30 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 11 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 15 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Sep 15 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 19 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Sep 19 2017

Comment 6 Deleted

Comment 7 by dcheng@chromium.org, Oct 17 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Oct 20 2017

Comment 8 Deleted

Comment 9 by dcheng@chromium.org, Oct 23 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Oct 24 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Oct 24 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Oct 24 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Oct 24 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Oct 24 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Oct 24 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Oct 24 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Oct 24 2017

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Oct 24 2017

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Oct 24 2017

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Oct 24 2017

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Oct 24 2017

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Oct 24 2017

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Oct 24 2017

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Oct 24 2017

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Oct 24 2017

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Oct 24 2017

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Oct 24 2017

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Oct 24 2017

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Oct 24 2017

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Oct 24 2017

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Oct 24 2017

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Oct 24 2017

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Oct 24 2017

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Oct 24 2017

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Oct 24 2017

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Oct 24 2017

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Oct 24 2017

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Oct 24 2017

Comment 38 Deleted