git cl status is waiting to reply
Reported by
techtonik@gmail.com,
Mar 29 2017
|
|||
Issue description
`git cl status` is waiting for my reply even after I replied.
What steps will reproduce the problem?
(1) "cl upload" patchset, wait for review comment
(2) "cl upload" new patchset
(3) hit Done button on review comment, hit Reply button and submit
(4) `git cl status` of my review is still yellow:
- Yellow waiting for you to reply to review
>git cl status
...
rewinpath : https://chromium-review.googlesource.com/461141 (reply)
Please provide any additional information below. Attach a screenshot if
possible.
Happened here: https://chromium-review.googlesource.com/c/461141/
Discussed here: https://groups.google.com/a/chromium.org/forum/#!topic/infra-dev/XKb7cqk90P4
Needs Proj-Gerrit-Migration label.
,
Apr 6 2017
Ok, issue seemingly reproduced. I uploaded https://chromium-review.googlesource.com/c/470329/ and even after marking dpranke's comment as Done/resolved, "git cl status" still shows the CL as yellow/reply.
,
Apr 6 2017
Uploaded two CLs (second not strictly related): https://chromium-review.googlesource.com/c/470586/ https://chromium-review.googlesource.com/c/470448/
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9ab38c68858c67704f940f901ea9aa713cbfce52 commit 9ab38c68858c67704f940f901ea9aa713cbfce52 Author: Aaron Gable <agable@chromium.org> Date: Tue Apr 11 23:10:22 2017 Fix gerrit git-cl-status to be simpler and correct The loop over the messages didn't early-exit when it found a non-CQ message, so it would continue looking until it found any message by a non-owner. So all CLs with any comments by anyone other than the uploader would be in 'reply' state forever. This CL fixes that, and also makes some other tweaks to make the gerrit status code simpler and faster. Bug: 706460 Change-Id: I5cc06962f5121fe042a315e5e2e205e556eb85da Reviewed-on: https://chromium-review.googlesource.com/470586 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/9ab38c68858c67704f940f901ea9aa713cbfce52/git_cl.py
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9ab38c68858c67704f940f901ea9aa713cbfce52 commit 9ab38c68858c67704f940f901ea9aa713cbfce52 Author: Aaron Gable <agable@chromium.org> Date: Tue Apr 11 23:10:22 2017 Fix gerrit git-cl-status to be simpler and correct The loop over the messages didn't early-exit when it found a non-CQ message, so it would continue looking until it found any message by a non-owner. So all CLs with any comments by anyone other than the uploader would be in 'reply' state forever. This CL fixes that, and also makes some other tweaks to make the gerrit status code simpler and faster. Bug: 706460 Change-Id: I5cc06962f5121fe042a315e5e2e205e556eb85da Reviewed-on: https://chromium-review.googlesource.com/470586 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/9ab38c68858c67704f940f901ea9aa713cbfce52/git_cl.py
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/a1bab27a2545105f08d5cd7f1d5c9bae643315d2 commit a1bab27a2545105f08d5cd7f1d5c9bae643315d2 Author: Aaron Gable <agable@chromium.org> Date: Tue Apr 11 23:42:48 2017 Give Rietveld git-cl-status the 'not lgtm' state While working on fixing git-cl-status for gerrit, I realized it would be really easy to bring the Rietveld version up to parity and simplify it at the same time. Bug: 706460 Change-Id: Icff32b532fa29f8869205111cd117176e0d34b8f Reviewed-on: https://chromium-review.googlesource.com/470448 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/a1bab27a2545105f08d5cd7f1d5c9bae643315d2/tests/git_cl_test.py [modify] https://crrev.com/a1bab27a2545105f08d5cd7f1d5c9bae643315d2/git_cl.py
,
Apr 11 2017
,
Apr 13 2017
Awesome. ) |
|||
►
Sign in to add a comment |
|||
Comment 1 by aga...@chromium.org
, Mar 29 2017Components: Infra>Codereview>Gerrit
Labels: Milestone-Launch Proj-Gerrit-Migration