New issue
Advanced search Search tips

Issue 706443 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Missing stdarg.h include in wasm-result.h

Project Member Reported by kmackay@chromium.org, Mar 29 2017

Issue description

This causes build failures on some Chromecast builds due to undefined va_list.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f7e76cded6699b6d89021d055e51d1f4e58f6cc5

commit f7e76cded6699b6d89021d055e51d1f4e58f6cc5
Author: kmackay <kmackay@chromium.org>
Date: Tue Apr 11 17:12:07 2017

Add some missing stdarg includes

One of our internal Chromecast builds was failing due to undefined
va_list in wasm-result.h. I also searched for other files where va_list
was used without including stdarg.h and added it as necessary (since
include-what-you-use is a thing).

BUG= chromium:706443 

Review-Url: https://codereview.chromium.org/2780913002
Cr-Commit-Position: refs/heads/master@{#44588}

[modify] https://crrev.com/f7e76cded6699b6d89021d055e51d1f4e58f6cc5/src/base/logging.cc
[modify] https://crrev.com/f7e76cded6699b6d89021d055e51d1f4e58f6cc5/src/heap/gc-tracer.cc
[modify] https://crrev.com/f7e76cded6699b6d89021d055e51d1f4e58f6cc5/src/wasm/decoder.h
[modify] https://crrev.com/f7e76cded6699b6d89021d055e51d1f4e58f6cc5/src/wasm/wasm-result.h

Status: Fixed (was: Assigned)

Sign in to add a comment