New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706434 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 603328
issue 705734

Blocking:
issue 707649



Sign in to add a comment

Upstream image_capture tests to WPT

Project Member Reported by mcasas@chromium.org, Mar 29 2017

Issue description

If and when Image Capture i2ship progresses, and per comment in [1],
we should upstream as many (layout) tests as possible and sensible 
to WPT, starting from idlharness onwards.



[1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/Y1hsOyT-vkk/b7LQ2FccCwAJ
 

Comment 1 by mcasas@chromium.org, Mar 29 2017

Cc: mcasas@chromium.org

Comment 2 by rbyers@chromium.org, Mar 30 2017

Cc: rbyers@chromium.org
As far as I'm concerned, the only priority here should be for things which can already be tested only with standard APIs (i.e. the idlharness tests, looks like maybe all of fast/imagecapture?).  Those should be pretty easy to upstream, right?  Any chance we can get an owner for that with Pri=2?

There's a lot of (both technical and non-technical) issues to work out generally for interop testing of things that require automation/mocking.  I'm definitely not going to argue that solving that for ImageCapture should be a priority.
Blocking: 707649

Comment 5 by cco3@chromium.org, Jun 5 2017

Blockedon: 705734
#5, why is this blocked on upstreaming WebUSB tests?
Cc: cco3@chromium.org
#6: once WebUSB teaches how to plug the mojo mock service we can 
reuse the same arcanes for the Image Capture. 
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 8 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Still available - also WebUSB already upstreamed a JS+mojo mock, so this
brug should be addressed.
Owner: rijubrat...@intel.com
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c8194213ae5b33b2fd5835207bbcbdd7100d04

commit b4c8194213ae5b33b2fd5835207bbcbdd7100d04
Author: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Date: Wed Aug 29 16:21:55 2018

Upstream image_capture tests to WPT


Moved the layout tests under third_party/WebKit/LayoutTests/imagecapture/ to
third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/

Moved the layout tests under fast/imagecapture to wpt and suffixed some file names with
-fast.html to avoid name collision.
ImageCapture-creation.html was renamed to
ImageCapture-creation.https.html as it needed to be served over https

Moved third_party/WebKit/LayoutTests/imagecapture/resources/imagecapture-helpers.js to
third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/resources/imagecapture-helpers.js
and extended it by adding a wrapper promise test, image_capture_test.

Copy the auto generated image_capture.mojom.js to wpt/resources/chromium/mock-imagecapture.js
used a flag called "scramble_message_ids = false" to the mojom compiler.

Used the testharness from wpt/

No new tests have been added.


BUG= 706434 

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7de5b87b60396da841dda490da02bce800fcb793
Reviewed-on: https://chromium-review.googlesource.com/1165355
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#587144}
[modify] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/media/capture/mojom/BUILD.gn
[modify] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/ImageCapture-MediaTrackSupportedConstraints.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/ImageCapture-creation.https.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/ImageCapture-grabFrame.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-applyConstraints-fast.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-applyConstraints-getSettings.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-applyConstraints-reject.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-applyConstraints.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-getCapabilities-fast.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-getCapabilities.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-getConstraints-fast.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-getSettings-fast.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/MediaStreamTrack-getSettings.html
[delete] https://crrev.com/d195b82ed46f2be2c80dabefd095e8153733c06f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/OWNERS
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/detached-HTMLCanvasElement.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/getPhotoCapabilities.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/getPhotoSettings.html
[add] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/resources/imagecapture-helpers.js
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/setOptions-reject.html
[add] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/takePhoto-with-PhotoSettings.html
[rename] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/mediacapture-image/takePhoto.html
[add] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/image_capture-mojom.js.headers
[add] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/image_capture.mojom.js
[add] https://crrev.com/b4c8194213ae5b33b2fd5835207bbcbdd7100d04/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/mock-imagecapture.js
[delete] https://crrev.com/d195b82ed46f2be2c80dabefd095e8153733c06f/third_party/WebKit/LayoutTests/fast/imagecapture/OWNERS
[delete] https://crrev.com/d195b82ed46f2be2c80dabefd095e8153733c06f/third_party/WebKit/LayoutTests/imagecapture/OWNERS
[delete] https://crrev.com/d195b82ed46f2be2c80dabefd095e8153733c06f/third_party/WebKit/LayoutTests/imagecapture/resources/imagecapture-helpers.js
[delete] https://crrev.com/d195b82ed46f2be2c80dabefd095e8153733c06f/third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js
[delete] https://crrev.com/d195b82ed46f2be2c80dabefd095e8153733c06f/third_party/WebKit/LayoutTests/imagecapture/takePhoto-with-PhotoSettings.html

Status: Fixed (was: Started)

Sign in to add a comment