Issue metadata
Sign in to add a comment
|
Compiler warning in printing/backend/cups_jobs.cc |
||||||||||||||||||||||
Issue descriptionWhen using go/simplechrome: cros chrome-sdk --log-level=debug --board=link mkdir -p out_link/Release gn gen out_link/Branded --args="$GN_ARGS is_chrome_branded=true" ninja -C out_link/Branded -j500 -l30 chrome chrome_sandbox nacl_helper ../../printing/backend/cups_jobs.cc:89:5: warning: suggest braces around initialization of subobject [-Wmissing-braces] kPrinterState, kPrinterStateReasons, kPrinterStateMessage}; I don't understand why it's warning -- it seems like the right sort of initializer list for std::array. Maybe it's confused by const char foo[] vs const char* const.
,
Mar 29 2017
It seems like brace elision is supposed to be allowable on the right side of an equals. But clang doesn't like it. This is an example of aggregate initialization which seems to have some funny rules. http://en.cppreference.com/w/cpp/language/aggregate_initialization
,
Mar 31 2017
,
Mar 31 2017
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74cea7ee6f641c6f59970a45bc6a5ec334020131 commit 74cea7ee6f641c6f59970a45bc6a5ec334020131 Author: skau <skau@chromium.org> Date: Thu Apr 06 00:23:56 2017 Fix style for aggregate initializer. Appease clang when run with -Wmissing-braces. By rule, the braces can be elided but since std::array is an array wrapped in a struct, it produces a warning. BUG= 706428 Review-Url: https://codereview.chromium.org/2784083002 Cr-Commit-Position: refs/heads/master@{#462291} [modify] https://crrev.com/74cea7ee6f641c6f59970a45bc6a5ec334020131/printing/backend/cups_jobs.cc
,
Apr 6 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by skau@chromium.org
, Mar 29 2017