The content suggestions must have a way to get their favicon. The Suggested Articles must display the favicon of the publisher, the reading list items the favicon of the entry.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/114e5deb1036e5430295c0e91bed96c8c4e7db95 commit 114e5deb1036e5430295c0e91bed96c8c4e7db95 Author: gambard <gambard@chromium.org> Date: Mon Apr 03 11:08:47 2017 Move FaviconAttributes to UI Move the FaviconAttributes from ios/chrome/browser/favicon to ios/chrome/browser/ui/favicon. BUG= 706427 Review-Url: https://codereview.chromium.org/2787503002 Cr-Commit-Position: refs/heads/master@{#461404} [modify] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/favicon/BUILD.gn [modify] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/BUILD.gn [add] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/favicon/BUILD.gn [rename] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/favicon/favicon_attributes.h [rename] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/favicon/favicon_attributes.mm [rename] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/favicon/favicon_attributes_provider.h [rename] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/favicon/favicon_attributes_provider.mm [rename] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/favicon/favicon_view.h [rename] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/favicon/favicon_view.mm [modify] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [modify] https://crrev.com/114e5deb1036e5430295c0e91bed96c8c4e7db95/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0b79d75dc0b349a3ae2d9faf74e4f5d8584e844 commit c0b79d75dc0b349a3ae2d9faf74e4f5d8584e844 Author: gambard <gambard@chromium.org> Date: Mon Apr 03 11:29:00 2017 Default state for the favicon view This CL allows the favicon view to be configured with nil attributes, creating a default background. BUG= 706427 Review-Url: https://codereview.chromium.org/2785053003 Cr-Commit-Position: refs/heads/master@{#461407} [modify] https://crrev.com/c0b79d75dc0b349a3ae2d9faf74e4f5d8584e844/ios/chrome/browser/ui/favicon/favicon_view.h [modify] https://crrev.com/c0b79d75dc0b349a3ae2d9faf74e4f5d8584e844/ios/chrome/browser/ui/favicon/favicon_view.mm [modify] https://crrev.com/c0b79d75dc0b349a3ae2d9faf74e4f5d8584e844/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca7e8fffb3a38d5fdb83f987cb2bc3f8c9909a8a commit ca7e8fffb3a38d5fdb83f987cb2bc3f8c9909a8a Author: gambard <gambard@chromium.org> Date: Mon Apr 03 12:15:03 2017 Add favicon view to ContentSuggestionsArticle BUG= 706427 Review-Url: https://codereview.chromium.org/2779843006 Cr-Commit-Position: refs/heads/master@{#461411} [modify] https://crrev.com/ca7e8fffb3a38d5fdb83f987cb2bc3f8c9909a8a/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [modify] https://crrev.com/ca7e8fffb3a38d5fdb83f987cb2bc3f8c9909a8a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h [modify] https://crrev.com/ca7e8fffb3a38d5fdb83f987cb2bc3f8c9909a8a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50148353a87f81026afab0ea2647ad66eb25cf8c commit 50148353a87f81026afab0ea2647ad66eb25cf8c Author: gambard <gambard@chromium.org> Date: Mon Apr 03 14:07:06 2017 Add FaviconAttributesProvider to ContentSuggestions This CL allows the ContentSuggestionsMediator to provide favicon attributes. BUG= 706296 , 706427 Review-Url: https://codereview.chromium.org/2782613004 Cr-Commit-Position: refs/heads/master@{#461422} [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d2c9cff70f35b667e59349d8a3520c058da6593 commit 7d2c9cff70f35b667e59349d8a3520c058da6593 Author: gambard <gambard@chromium.org> Date: Fri Apr 14 13:42:28 2017 Download favicon from server for suggested articles This CL uses the FetchFavicon method of the ContentSuggestionsService to fetches favicon for suggested articles if they are not available in history. Only the favicon of suggested articles are fetched because the download service can only access public URL. BUG= 706427 Review-Url: https://codereview.chromium.org/2818453002 Cr-Commit-Position: refs/heads/master@{#464721} [modify] https://crrev.com/7d2c9cff70f35b667e59349d8a3520c058da6593/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/7d2c9cff70f35b667e59349d8a3520c058da6593/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/7d2c9cff70f35b667e59349d8a3520c058da6593/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h
Comment 1 by bugdroid1@chromium.org
, Apr 3 2017