New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706423 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Disable reporting persistent histograms from last session by default

Project Member Reported by asvitk...@chromium.org, Mar 29 2017

Issue description

We should make the client default match what we're launching to 100% - that is, we should disable reporting persistent histograms from last session by default (in absence of parameters).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8cf9f23a6c3b6d69e9528d7e9a4f22f16b7d63e

commit c8cf9f23a6c3b6d69e9528d7e9a4f22f16b7d63e
Author: asvitkine <asvitkine@chromium.org>
Date: Wed Mar 29 18:30:16 2017

Disable sending persistent histograms from last session by default.

Moves the logic to a different location than before so that it only
affects upload of persistent histograms data and not other .pma
file metrics - like crashpad and installer.

BUG= 706423 

Review-Url: https://codereview.chromium.org/2782903002
Cr-Commit-Position: refs/heads/master@{#460465}

[modify] https://crrev.com/c8cf9f23a6c3b6d69e9528d7e9a4f22f16b7d63e/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/c8cf9f23a6c3b6d69e9528d7e9a4f22f16b7d63e/components/metrics/file_metrics_provider.cc

Labels: Merge-Request-58
Would like to merge to M58.

This allows UMA from crashpad and installer to still be reported when we launch persistenthistograms study (which is in the process of being launched). Without this CL, launching that study will also disable crashpad/installer metrics reporting which is undesirable.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 30 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: M-58
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2c65825c8708d115f09e3521fecebca46895b6b

commit b2c65825c8708d115f09e3521fecebca46895b6b
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Thu Mar 30 21:08:35 2017

Disable sending persistent histograms from last session by default.

Moves the logic to a different location than before so that it only
affects upload of persistent histograms data and not other .pma
file metrics - like crashpad and installer.

BUG= 706423 

Review-Url: https://codereview.chromium.org/2782903002
Cr-Commit-Position: refs/heads/master@{#460465}
(cherry picked from commit c8cf9f23a6c3b6d69e9528d7e9a4f22f16b7d63e)

Review-Url: https://codereview.chromium.org/2790753002 .
Cr-Commit-Position: refs/branch-heads/3029@{#498}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/b2c65825c8708d115f09e3521fecebca46895b6b/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/b2c65825c8708d115f09e3521fecebca46895b6b/components/metrics/file_metrics_provider.cc

Status: Fixed (was: Started)

Sign in to add a comment