New issue
Advanced search Search tips

Issue 706408 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove support for non-spec compliant MediaStream constraints algorithms

Project Member Reported by guidou@chromium.org, Mar 29 2017

Issue description

Once spec-compliant processing of constraints stabilizes, remove all support and code related to the old constraints algorithms.
 
Summary: Remove support for non-spec compliant MediaStream constraints (was: Remove support non-spec compliant MediaStream constraints)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6beb0cec0f47293fc637421c85e275a657caf7e7

commit 6beb0cec0f47293fc637421c85e275a657caf7e7
Author: guidou <guidou@chromium.org>
Date: Wed Jul 05 06:57:51 2017

Remove support for old getUserMedia video constraints algorithm.

This CL removes most code implementing the old algorithm for processing
getUserMedia video constraints.
The new algorithm has been in stable Chrome for a few weeks now and
having the option to switch back to the old algorithm is no longer
necessary.

BUG= 706408 

Review-Url: https://codereview.chromium.org/2964003002
Cr-Commit-Position: refs/heads/master@{#484202}

[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/public/common/content_features.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/public/common/content_features.h
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_center.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_source.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_source.h
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_source_unittest.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_track.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_track.h
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/media_stream_video_track_unittest.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/mock_media_stream_registry.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/mock_media_stream_registry.h
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/mock_media_stream_video_source.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/media/webrtc/media_stream_video_webrtc_sink_unittest.cc
[modify] https://crrev.com/6beb0cec0f47293fc637421c85e275a657caf7e7/content/renderer/pepper/pepper_media_stream_video_track_host.cc

Summary: Remove support for non-spec compliant MediaStream constraints algorithms (was: Remove support for non-spec compliant MediaStream constraints)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bd16d04a28349748da422fa7361c1832c3cd04e

commit 9bd16d04a28349748da422fa7361c1832c3cd04e
Author: guidou <guidou@chromium.org>
Date: Wed Jul 05 19:06:51 2017

Remove MediaStreamVideoSource::GetCurrentSupportedFormats()

This is part of the removal of old MediaStream video constraints code.

BUG= 706408 

Review-Url: https://codereview.chromium.org/2972553002
Cr-Commit-Position: refs/heads/master@{#484324}

[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/media_stream_video_source.h
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/mock_media_stream_registry.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/mock_media_stream_video_source.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/mock_media_stream_video_source.h
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/webrtc/media_stream_remote_video_source.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/webrtc/media_stream_remote_video_source.h
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/webrtc/webrtc_media_stream_adapter_map_unittest.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_unittest.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/media_recorder/video_track_recorder_unittest.cc
[modify] https://crrev.com/9bd16d04a28349748da422fa7361c1832c3cd04e/content/renderer/pepper/pepper_media_stream_video_track_host.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c79d018fb4953a250235e6bcbafe7a18d52dc52

commit 3c79d018fb4953a250235e6bcbafe7a18d52dc52
Author: guidou <guidou@chromium.org>
Date: Wed Jul 05 19:30:57 2017

Remove unused parameters from MediaStreamVideoSource::StartCaptureImpl()

This is part of the removal of the old MediaStream video constraints
algorithm.

BUG= 706408 

Review-Url: https://codereview.chromium.org/2973503002
Cr-Commit-Position: refs/heads/master@{#484329}

[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/media_stream_video_capturer_source.cc
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/media_stream_video_capturer_source.h
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/media_stream_video_source.cc
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/media_stream_video_source.h
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/mock_media_stream_video_source.cc
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/mock_media_stream_video_source.h
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/webrtc/media_stream_remote_video_source.cc
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/media/webrtc/media_stream_remote_video_source.h
[modify] https://crrev.com/3c79d018fb4953a250235e6bcbafe7a18d52dc52/content/renderer/pepper/pepper_media_stream_video_track_host.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53

commit 1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53
Author: Guido Urdaneta <guidou@chromium.org>
Date: Sun Sep 10 20:00:02 2017

Remove old MediaStream audio constraints algorithm

The new constraints algorithm is enabled by default on stable and keeping
the old algorithm is no longer necessary.

Bug:  706408 
Change-Id: I77410c26f8a05ec53bdceaa7d4c64d3a8d898710
Reviewed-on: https://chromium-review.googlesource.com/655458
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500814}
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/public/common/content_features.cc
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/public/common/content_features.h
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/renderer/media/media_stream_audio_processor_options.cc
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/renderer/media/media_stream_audio_processor_options.h
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/renderer/media/media_stream_audio_processor_unittest.cc
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/1fc0dc303ef3fb0a0a2dc7d1402393d0fc9cdd53/content/renderer/media/webrtc/media_stream_video_webrtc_sink_unittest.cc

Comment 9 by guidou@chromium.org, Sep 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment