New issue
Advanced search Search tips

Issue 706407 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 689499

Blocking:
issue 680924


Show other hotlists

Hotlists containing this issue:
NFC


Sign in to add a comment

Normalize NFC Mojo module

Project Member Reported by blundell@chromium.org, Mar 29 2017

Issue description

The Mojo module for NFC is currently device.nfc.mojom. It should become device.mojom, which is what is being used for all the other device features.

Note that we should wait to do this until porting NFC into the Device Service, when the dust will have settled on all the relevant mojoms being in the codebase.
 
Components: Blink>NFC

Comment 2 by leon....@intel.com, May 21 2017

Owner: leon....@intel.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6a2e5f9d3fa677ee63257d3a350e65e269afe28

commit f6a2e5f9d3fa677ee63257d3a350e65e269afe28
Author: Han Leon <leon.han@intel.com>
Date: Wed May 24 03:13:24 2017

[DeviceService] Normalize NFC Mojo module: device.nfc.mojom => device.mojom

The Mojo module for NFC is currently device.nfc.mojom. It should become
device.mojom, which is what is being used for all the other device
features. This CL does this work.

BUG= 706407 
TBR=jam@chromium.org,tsepez@chromium.org,alexander.shalamov@intel.com

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ia6ab659abf35cded74e1b00ce7a958c87a7eb79e
Reviewed-on: https://chromium-review.googlesource.com/512362
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474143}
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/browser/android/nfc_host.cc
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/browser/android/nfc_host.h
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/android/java/src/org/chromium/services/device/InterfaceRegistrar.java
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/device_service.cc
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/device_service.h
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/manifest.json
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcImpl.java
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcMessageValidator.java
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcProviderImpl.java
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcTypeConverter.java
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/nfc/android/junit/src/org/chromium/device/nfc/NFCTest.java
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/public/interfaces/nfc.mojom
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/services/device/public/interfaces/nfc_provider.mojom
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/third_party/WebKit/LayoutTests/nfc/resources/nfc-helpers.js
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/third_party/WebKit/Source/modules/nfc/NFC.h
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/third_party/WebKit/Source/modules/nfc/NFCError.cpp
[modify] https://crrev.com/f6a2e5f9d3fa677ee63257d3a350e65e269afe28/third_party/WebKit/Source/modules/nfc/NFCError.h

Comment 4 by leon....@intel.com, May 25 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment