git cl patch doesn't work with rietveld URL |
||||||||
Issue descriptionwith depot_tools at b2e5564353be2974b1241d1bd57b3259100b14ea I ran the following command in a v8 check (fetch v8) at a5fe3a0ac6392446044bedef67813f5899d8552c $ git cl patch https://codereview.chromium.org/2770003002 change 2770003002 at https://codereview.chromium.org does not exist or you have no access to it using this however worked: $ git cl patch --rietveld 2770003002 Committed patch locally.
,
Mar 29 2017
,
Apr 5 2017
My guess is that "git cl"'s guessing logic is broken.
,
Apr 5 2017
WAI: $ git cl patch --rietveld <url or issue> is the right way to go since your default is Gerrit.
,
Apr 5 2017
+ @agable maybe this should be added to FAQ? Note: we can add guessing the codereview based on domain name, but IMO guessing is not a good approach since this is also used on bots. That said, if current behavior bugs many users this perhaps should be reconsidered.
,
Apr 5 2017
we can improve error message to indicate that it actually tried to access Gerrit's issue #xxxx, and suggest to use --rietveld or --gerrit.
,
Apr 6 2017
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/28d840eb31e84581608d43d8936646bc073ad2e1 commit 28d840eb31e84581608d43d8936646bc073ad2e1 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Apr 10 14:06:30 2017 git cl patch: when URL matches both codereview systems, choose rietveld. This is temporary, and will be changed in subsequent CLs. For now, it suffices to stop relying on pseudo-random dictionary order in tests and prod. R=jochen@chromium.org BUG= 706406 Change-Id: I26c467a28bc63b5f81d20fc222a2b6f0511c507f Reviewed-on: https://chromium-review.googlesource.com/472750 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/28d840eb31e84581608d43d8936646bc073ad2e1/tests/git_cl_test.py [modify] https://crrev.com/28d840eb31e84581608d43d8936646bc073ad2e1/git_cl.py
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/90f3192799a37026cf58b8d52f8ac2771f0cba80 commit 90f3192799a37026cf58b8d52f8ac2771f0cba80 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Apr 10 14:14:00 2017 git cl: remember codereview type when parsing issue/change URL. R=jochen@chromium.org BUG= 706406 Change-Id: I477d1cf629bb0bccebead6e5c0189830ea76be7e Reviewed-on: https://chromium-review.googlesource.com/472867 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> [modify] https://crrev.com/90f3192799a37026cf58b8d52f8ac2771f0cba80/tests/git_cl_test.py [modify] https://crrev.com/90f3192799a37026cf58b8d52f8ac2771f0cba80/git_cl.py
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/c971239edd08292d4e9a45b68cce1e82cea382b2 commit c971239edd08292d4e9a45b68cce1e82cea382b2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Apr 11 11:39:21 2017 git cl patch <url>: better handling of URLs. * if --rietveld or --gerrit is given, parse only using appropriate parser. * if url has '$HOST-review' in the beginning, assume it's Gerrit * if type of codereview is detected based on URL, then print this information for the user. This also applies to `git cl description` but message is logged instead, because in '-d|--display' option git cl is supposed to print only description, and some tooling likely relies on this :( R=jochen@chromium.org BUG= 706406 Change-Id: I21c9355c5334fd71db27618cda11287f75168b59 Reviewed-on: https://chromium-review.googlesource.com/473186 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> [modify] https://crrev.com/c971239edd08292d4e9a45b68cce1e82cea382b2/tests/git_cl_test.py [modify] https://crrev.com/c971239edd08292d4e9a45b68cce1e82cea382b2/git_cl.py
,
Apr 11 2017
So, I've actually found bugs and fixed them - see last CL landed right above. Jochen, thanks for reporting and persisting! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jochen@chromium.org
, Mar 29 2017