ChromePasswordManagerClient is WebContentsObserver and it listens input events. For some reasons it doesn't receive an event blink::WebInputEvent::Char on Android, so it can't get input from a user.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/841eab11c2273bb100fbd927a9e47411838cc6b5 commit 841eab11c2273bb100fbd927a9e47411838cc6b5 Author: dvadym <dvadym@chromium.org> Date: Tue Apr 04 10:08:54 2017 Do not build Password Reuse on Android and iOS. On both of these OS Password Reuse logic doesn't implemented fully and doesn't work, so let's stop building it and save some performance and binary size. BUG=657041, 706392 Review-Url: https://codereview.chromium.org/2777283004 Cr-Commit-Position: refs/heads/master@{#461672} [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/chrome/browser/password_manager/chrome_password_manager_client.cc [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/chrome/browser/password_manager/chrome_password_manager_client.h [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/components/password_manager/core/browser/BUILD.gn [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/components/password_manager/core/browser/mock_password_store.h [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/components/password_manager/core/browser/password_manager_test_utils.cc [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/components/password_manager/core/browser/password_manager_test_utils.h [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/components/password_manager/core/browser/password_store.cc [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/components/password_manager/core/browser/password_store.h [modify] https://crrev.com/841eab11c2273bb100fbd927a9e47411838cc6b5/components/password_manager/core/browser/password_store_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e46aa31140b2e6341183d454b39c38bfd440bb8e commit e46aa31140b2e6341183d454b39c38bfd440bb8e Author: Vaclav Brozek <vabr@chromium.org> Date: Mon Oct 01 13:49:28 2018 Synchronise flags for sync password reuse detection There are two flags guarding support for detecting sync password reuse: (1) password_reuse_detection_support in components/password_manager/core/browser/BUILD.gn, and (2) SYNC_PASSWORD_REUSE_DETECTION_ENABLED in components/password_manager/core/browser/password_reuse_defines.h Those got out of sync, with the former excluding Android and the latter not. This can cause compilation errors. Furthermore, at some places, direct mentions of OS_* macros are used instead of SYNC_PASSWORD_REUSE_DETECTION_ENABLED. This breaks compilation if SYNC_PASSWORD_REUSE_DETECTION_ENABLED is changed. Therefore this CL defines (2) by (1) and abolishes password_reuse_defines.h completely. It also replaces OS_* macros with SYNC_PASSWORD_REUSE_DETECTION_ENABLED as appropriate. Finally, it adds "// nogncheck" to conditional #includes which would otherwise cause troubles, following the guidance of [1], and also adds a missing #include, which was found when switching password_reuse_detection_support to exclude Linux instead. [1] https://chromium.googlesource.com/chromium/src/+/eca97f87e275a7c9c5b7f13a65ff8635f0821d46/tools/gn/docs/reference.md#controlling-includes-individually Bug: 706392 Change-Id: I40113777be9440faccb4e80fbca2a3571e2f6110 Reviewed-on: https://chromium-review.googlesource.com/1252585 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595441} [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/chrome/browser/password_manager/password_store_factory.cc [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/BUILD.gn [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_manager_client.h [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_manager_test_utils.cc [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_manager_test_utils.h [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_manager_unittest.cc [delete] https://crrev.com/d1d33c0081d63a416ac1226d0f2ae3062804cc5c/components/password_manager/core/browser/password_reuse_defines.h [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_store.cc [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_store.h [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/core/browser/password_store_unittest.cc [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/sync/browser/password_sync_util.cc [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/sync/browser/password_sync_util_unittest.cc [modify] https://crrev.com/e46aa31140b2e6341183d454b39c38bfd440bb8e/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc
Comment 1 by dvadym@chromium.org
, Mar 29 2017