New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 706386 link

Starred by 2 users
Status: Verified
Owner:
█ emso@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
qyears...@chromium.org
█ emso@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Incorporate instance selection in the context

Project Member Reported by emso@chromium.org, Mar 29 2017 
Tricium runs in three different modes: locally, dev or prod. Depending on mode, local configs, dev configs, or prod configs should be used. The same goes for swarming instance and auth instance. Incorporate the selected choice in the context passed around in the backend.

Comment 1 by emso@chromium.org, Apr 4 2017

Owner: emso@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b6bf26a1412e48e8754b9093fe405d417b508e99

commit b6bf26a1412e48e8754b9093fe405d417b508e99
Author: Emma <emso@chromium.org>
Date: Fri Apr 07 07:07:50 2017

Adds better pubsub handling

BUG= 706386 

Change-Id: Id6ad755bd54e801a05b97af938e59f03038d2a97
Reviewed-on: https://chromium-review.googlesource.com/467210
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/admin/v1/pb.discovery.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/admin/v1/driver.pb.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/v1/pb.discovery.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/common/config/validate.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/common/config/generate_test.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/common/swarming.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/common/common.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/driver/rpc_trigger.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/devcfg/services/tricium-dev/service.cfg
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/v1/config.proto
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/admin/v1/launcher.pb.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/admin/v1/workflow.proto
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/launcher/rpc_launch.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/common/config/generate.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/admin/v1/tracker.pb.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/v1/config.pb.go
[add] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/common/pubsub.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/common/config/validate_test.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/admin/v1/config.pb.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/api/admin/v1/workflow.pb.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/launcher/rpc_launch_test.go
[modify] https://crrev.com/b6bf26a1412e48e8754b9093fe405d417b508e99/go/src/infra/tricium/appengine/driver/handlers.go
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f019c0419488f88faa391290ad2b781c143285dd

commit f019c0419488f88faa391290ad2b781c143285dd
Author: Emma <emso@chromium.org>
Date: Mon Apr 10 12:07:26 2017

Derives services to use from instance context.

This includes service selection for swarming, isolate, and luci-config.

BUG= 706386 

Change-Id: I968b7747e2e0dff48a6e273907aebf2b49f673b3
Reviewed-on: https://chromium-review.googlesource.com/469728
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/api/admin/v1/pb.discovery.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/api/admin/v1/driver.pb.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/tracker/rpc_worker_done_test.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/driver/rpc_trigger_test.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/api/v1/pb.discovery.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/config/rpc_validate.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/config/validate.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/config/generate_test.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/swarming.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/common.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/driver/rpc_trigger.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/devcfg/services/tricium-dev/service.cfg
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/api/v1/config.proto
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/api/admin/v1/workflow.proto
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/launcher/rpc_launch.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/isolate.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/config/generate.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/api/v1/config.pb.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/pubsub.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/driver/rpc_collect_test.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/frontend/rpc_analyze.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/config/validate_test.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/config/rpc_generate_workflow.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/common/config/provider.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/api/admin/v1/driver.proto
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/driver/rpc_collect.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/frontend/handlers.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/api/admin/v1/workflow.pb.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/launcher/rpc_launch_test.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched_test.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/driver/handlers.go
[modify] https://crrev.com/f019c0419488f88faa391290ad2b781c143285dd/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched.go
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/8a3bfa9479c697a968a4522fdae0bd0edeb68107

commit 8a3bfa9479c697a968a4522fdae0bd0edeb68107
Author: Emma Soederberg <emso@google.com>
Date: Mon Apr 10 13:24:21 2017
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c76b51ab868ee220d7c0f3760281afb3ae574447

commit c76b51ab868ee220d7c0f3760281afb3ae574447
Author: Emma <emso@chromium.org>
Date: Wed Apr 19 13:09:19 2017

Derives luci-config project config file

Bug:706386

Change-Id: I14bf6b9a8d8e215a2bb43a7172ac9d12edf36af0
Reviewed-on: https://chromium-review.googlesource.com/475718
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/c76b51ab868ee220d7c0f3760281afb3ae574447/go/src/infra/tricium/appengine/common/config/provider.go
[modify] https://crrev.com/c76b51ab868ee220d7c0f3760281afb3ae574447/go/src/infra/tricium/appengine/common/config/config.infra_testing
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/da681c198ecf206f12ba22e16076a6b7ee02d6fb

commit da681c198ecf206f12ba22e16076a6b7ee02d6fb
Author: Emma <emso@chromium.org>
Date: Wed Apr 19 19:20:38 2017

Use the LUCI GAE AppID

Bug:706386

Change-Id: I113740b1ce648fe5478ed2a93c538d821cfaad8f
Reviewed-on: https://chromium-review.googlesource.com/481481
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/da681c198ecf206f12ba22e16076a6b7ee02d6fb/go/src/infra/tricium/appengine/common/config/provider.go
[modify] https://crrev.com/da681c198ecf206f12ba22e16076a6b7ee02d6fb/go/src/infra/tricium/appengine/common/pubsub.go
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a913f4ad01d7d24533c17033fa6a24642cf3f47b

commit a913f4ad01d7d24533c17033fa6a24642cf3f47b
Author: Emma <emso@chromium.org>
Date: Thu Apr 20 13:37:12 2017

Adjusts pubsub push URL.

Bug:706386

Change-Id: If5beccf5608e65edc2cdaf88d0970d2716b13501
Reviewed-on: https://chromium-review.googlesource.com/483441
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/a913f4ad01d7d24533c17033fa6a24642cf3f47b/go/src/infra/tricium/appengine/common/pubsub.go

Comment 8 by emso@chromium.org, Apr 28 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment