New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 706377 link

Starred by 2 users
Status: Duplicate
Merged: issue 648343
Owner: ----
Closed: Jan 2018
Cc:
█ zchen@google.com
█ iannucci@chromium.org
tandrii@chromium.org
aga...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CQ should reject changes with no files (only commit message)

Project Member Reported by rmis...@google.com, Mar 29 2017 
Eg: https://skia-review.googlesource.com/c/10335/

Is there a benefit to landing these changes? Majority (all?) of them are created accidentally.

Should the CQ be rejecting these patches? because landing them causes unnecessary trybot churn. This was not an issue in Rietveld because there was no "Commit message".

Comment 1 by aga...@chromium.org, Mar 29 2017

Labels: Milestone-Afterglow
Status: Available (was: Untriaged)
Have you also filed a bug against the recipe roller to make sure it can't create CLs like these?

It makes sense to put a safety check in place, I agree, but we should also fix the root cause.

Comment 2 by rmis...@google.com, Mar 29 2017

Cc: iannucci@chromium.org
I do not know if there is a bug on file but Robbie is aware of the issue. Robbie, is there an open bug for this?

Comment 3 by tandrii@chromium.org, Mar 30 2017

Cc: zchen@google.com
Components: -Infra>CQ
Are you sure CQ landed the patch with just description change?
I suspect the CL was fine, but it was a dup of another cl that landed,
And Gerrit rebase strategy "noticed" that and rebased cl into just commit message.

If so, there isn't much CQ can do about it. However, iirc there was related cl by Then to deal with cases when tree hash is the same after rebase.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 21 2017

Labels: Hotlist-Google

Comment 5 by aga...@chromium.org, Jan 3 2018

Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.

Comment 6 by aga...@chromium.org, Jan 5 2018

Components: -Infra>Codereview>Gerrit Infra>Platform>CQ
Labels: -Hotlist-Google -Proj-Gerrit-Migration
Mergedinto: 648343
Status: Duplicate (was: Available)
Summary: CQ should reject changes with no files (only commit message) (was: CQ should reject Gerrit patches with only "Commit message" changes)
►

Sign in to add a comment