New issue
Advanced search Search tips

Issue 706364 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Hotlist-1


Sign in to add a comment

ash: gap between window and resize shadow at rounded corners

Reported by dragonat...@gmail.com, Mar 29 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9000.91.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.110 Safari/537.36
Platform: 9000.91.0 (Official Build) stable-channel samus

Steps to reproduce the problem:
1. resize any window at corner in chromeos
2. 

What is the expected behavior?
the resizing corner should be pixelated, and not broken

What went wrong?
the corner resizing semi-transparent border is not pixelated, ant it is broken for top-right, bottom-left, bottom-right corner. top-left is good, but the others with changing alpha value in the corner part

Did this work before? No 

Chrome version: 56.0.2924.110  Channel: stable
OS Version: 9000.91.0
Flash Version: Shockwave Flash 24.0 r0
 
Screenshot 2017-03-29 at 20.09.34.png
12.0 KB View Download
What's more, title bar with tint color will have a white pixel in the corner when resizing.
I attached two more screenshots for this problem
Screenshot 2017-03-29 at 20.13.04.png
10.9 KB View Download
Screenshot 2017-03-29 at 20.12.35.png
27.7 KB View Download
with the new chrome os version 9202.60.0
the white pixel in the corner of window has been removed, but the resizing edge is still blurred
Cc: malaykeshav@chromium.org osh...@chromium.org sky@chromium.org
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Could you please triage? Thanks!

Comment 4 by est...@chromium.org, Apr 17 2017

Cc: sgabr...@chromium.org
What do you mean by the edge being blurred?

+sgabriel do the resize shadows on ToT match your expectation? (screenshots above are from an old version)
The CORNER of the resizing shadow is blurred, event in 9202.60.0
And the alpha of resizing shadow near corner part is not stable in the right-top, left-bottom and right-bottom corner
Implementation correct on ToT canary. See attached.
However I do notice the pixel in the corner, created by the fact that the handles do not go under the app layer.

I see two solutions:
- Get the grabbed corner to be rectangular when dragged.
- Get the resize handles underneath the app layer.

Does one seem possible for you @estade?


preview.png
48.5 KB View Download

Comment 7 by est...@chromium.org, Apr 18 2017

Status: Started (was: Assigned)
Summary: ash: gap between window and resize shadow at rounded corners (was: not pixelated corner resizing border for chromeos window )
the latter is easy enough, sure
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a26f514d0a7b98f146782a538c463bc39bfdf773

commit a26f514d0a7b98f146782a538c463bc39bfdf773
Author: estade <estade@chromium.org>
Date: Wed Apr 19 13:27:29 2017

Ash: Make window resize shadow extend beneath window it's attached to.

Gets rid of an empty pixel or two due to the window's rounded corner.

BUG= 706364 

Review-Url: https://codereview.chromium.org/2820323003
Cr-Commit-Position: refs/heads/master@{#465576}

[modify] https://crrev.com/a26f514d0a7b98f146782a538c463bc39bfdf773/ash/wm/resize_shadow.cc

Comment 9 by est...@chromium.org, Apr 19 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 9532.0.0, 60.0.3092.0

Sign in to add a comment