Issue metadata
Sign in to add a comment
|
Regression: Unable to add devices as 'Select/Cancel' button not visible on USB Device picker dialog. |
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3029.41 OS: Windows-10, Linux Ubuntu 14.04. What steps will reproduce the problem? (1) Launch chrome and add 'USB Device Info'(https://chrome.google.com/webstore/detail/usb-device-info/igkmggljimacfdfalpeelenjeicmfnll/related) (2) Launch the app once added and try to 'Add device' (3) Look out for 'Select/Cancel' buttons on the dialog. What is the expected result? Select/Cancel buttons should be visible. What happens instead? Select/Cancel buttons are not visible. Shows up only when the USB Device info dialog is maximized. Please use labels and text to provide additional information. > This is regression issue working fine on 57.0.2987.110 and reproducible on the latest canary(59.0.3054.0).
,
Apr 5 2017
Able to reproduce the issue on windows 7 using chrome version 59.0.3063.0. ellyjones@ Could you please look into this issue stable blocker issue.
,
Apr 5 2017
A friendly reminder that M58 Stable launch is coming soon! Your bug is labelled as Stable ReleaseBlock, please make sure to land the fix, verified in trunk and get it merged into the release branch ASAP.
,
Apr 6 2017
A friendly reminder that M58 Stable is launch is coming soon (less than 2 weeks)! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48fd59f0ef21b6daffc42147ac15bff3aefd4e67 commit 48fd59f0ef21b6daffc42147ac15bff3aefd4e67 Author: ellyjones <ellyjones@chromium.org> Date: Mon Apr 10 11:55:44 2017 views: don't make device chooser's client view huge ChooserDialogView's client view does not need to be 402x320, since the DeviceChooserContentView sizes itself. Worse, explicitly sizing the ChooserDialogView's client view causes the dialog to double in height. BUG= 706337 Review-Url: https://codereview.chromium.org/2804303002 Cr-Commit-Position: refs/heads/master@{#463225} [modify] https://crrev.com/48fd59f0ef21b6daffc42147ac15bff3aefd4e67/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
,
Apr 13 2017
This is working as intended, select and cancel buttons are visible. Chrome Version : 59.0.3070.0 (Official Build) canary OS : Win 10 ellyjones@ Would you mind requesting a merge to M58. We are close to M58 Stable promotion. Please merge ASAP once its approved.
,
Apr 13 2017
,
Apr 13 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/064f15c744cccb39236945565edf9e2977251940 commit 064f15c744cccb39236945565edf9e2977251940 Author: Elly Fong-Jones <ellyjones@google.com> Date: Mon Apr 17 14:35:25 2017 views: don't make device chooser's client view huge ChooserDialogView's client view does not need to be 402x320, since the DeviceChooserContentView sizes itself. Worse, explicitly sizing the ChooserDialogView's client view causes the dialog to double in height. BUG= 706337 Review-Url: https://codereview.chromium.org/2804303002 Cr-Commit-Position: refs/heads/master@{#463225} (cherry picked from commit 48fd59f0ef21b6daffc42147ac15bff3aefd4e67) Review-Url: https://codereview.chromium.org/2823863002 . Cr-Commit-Position: refs/branch-heads/3029@{#730} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/064f15c744cccb39236945565edf9e2977251940/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
,
Apr 17 2017
,
Apr 19 2017
Verified this issue on Ubuntu 14.04 and Mac 10.12.4 with chrome #58.0.3029.81 Observed fix is working as expected.Attaching a screen-cast for reference Hence adding TE-verified labels |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Mar 29 2017Labels: -Needs-Bisect hasbisect-per-revision
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
30.8 KB
30.8 KB View Download