New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706325 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Focus is lost after clicking on close icon of search field on 'Add languages' .

Reported by db...@etouch.net, Mar 29 2017

Issue description

Chrome Version: 59.0.3055.0 Revision e80b960e27af6495ff3dd79cbfcede18d48da85a-refs/heads/master@{#460255}
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)
 
What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/languages 
2. Now expand it and click on 'Add languages' to open overlay and type in search field.
3. Click on Close icon and observe.

Actual: Focus is lost after clicking on close icon of search field.

Expected: Focus should not lost after clicking on close icon of search field.

his is a non-regression issue, seen from M-59 as 'search field' in 'Add languages' overlay appears from build # 59.0.3051.3 
 
Actual_Focus.mp4
334 KB View Download
Status: Untriaged (was: Unconfirmed)
Untriaged so that it gets addressed.

Comment 2 by dpa...@chromium.org, Apr 12 2018

Cc: aee@chromium.org hcarmona@chromium.org
Labels: OS-Chrome
Status: Available (was: Untriaged)
This seems to be the case with other search boxes in settings too, like the one in chrome://settings/searchEngines.

Comment 3 by aee@chromium.org, Apr 19 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ebd208b57463c6b9d9c3b96d3601fe56b82c3fa

commit 2ebd208b57463c6b9d9c3b96d3601fe56b82c3fa
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Apr 20 02:11:18 2018

Settings: for search text input, focus after clear

Bug:  706325 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7166b4d3c2277d201bb29c305136cf4ed98a95d2
Reviewed-on: https://chromium-review.googlesource.com/1020522
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552231}
[modify] https://crrev.com/2ebd208b57463c6b9d9c3b96d3601fe56b82c3fa/chrome/browser/resources/settings/settings_page/settings_subpage_search.js
[modify] https://crrev.com/2ebd208b57463c6b9d9c3b96d3601fe56b82c3fa/chrome/test/data/webui/settings/settings_subpage_test.js

Comment 5 by aee@chromium.org, Apr 20 2018

Status: Fixed (was: Started)

Sign in to add a comment