New issue
Advanced search Search tips

Issue 706312 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Don't deprecate options_in_tab: true

Reported by w.vons...@eyeo.com, Mar 29 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36

Steps to reproduce the problem:
1. Force OptionsV2 via chrome://flags/#enable-embedded-extension-options
2. Restart browser
3. Install ABP (https://adblockplus.org/)
4. Visit chrome://extensions/
5. Click options link of ABP Extension

What is the expected behavior?
Options page should be opened in new tab.

What went wrong?
Options page gets opened in tiny overlay.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 57.0.2987.110  Channel: stable
OS Version: 
Flash Version: 

From the api docs:

```
This is only useful to delay the inevitable deprecation of the old options UI! It will be removed soon, so try not to use it. It will break.
```

<https://developer.chrome.com/extensions/optionsV2>

I understand the idea of providing a uniform user experience but I feel that this could also be achieved by providing chrome styles via chrome_style and defaulting options_in_tab to false and maybe encouraging developers to use them in the manual.

In my opinion not much is gained by forcing extensions to use options overlays with limited view ports, after all most option pages look the way they look because the developers didn't invest much effort.

We could of course still use a option tab and break out of the overlay if the user used the extension icon context menu or opened the options from the extension page, but we would rather not do something that goes against the recommendation or the very least make sure that the chromium team is fine with the approach.
 
options_page_in_tab.png
124 KB View Download
Labels: Needs-Triage-M57

Comment 2 by dk...@chromium.org, Apr 5 2017

Components: Platform>Extensions>API
Status: Untriaged (was: Unconfirmed)
Adding extensions label to comment on deprecation plan.

Comment 3 by dk...@chromium.org, Apr 5 2017

Labels: -Hotlist-Interop
Cc: karandeepb@chromium.org jawag@chromium.org catmulli...@chromium.org lazyboy@chromium.org
Owner: rdevlin....@chromium.org
I don't think we need to deprecate the tab-style options page; I think there are definitely UXs where having a full-tab options page would be more desirable.  I'll see if we can update the documentation to not state that deprecation is forthcoming.
Status: Assigned (was: Untriaged)
Cc: -catmulli...@chromium.org

Sign in to add a comment