The ContentSuggestions representing a Reading List entry should be displayed in the same way as the entries in the Reading List surface.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24939285bd24532cc0c2ffca609c5e80073cd9f4 commit 24939285bd24532cc0c2ffca609c5e80073cd9f4 Author: gambard <gambard@chromium.org> Date: Thu Mar 30 12:12:11 2017 Add ContentSuggestion for ReadingList This CL allows the ContentSuggestionsUpdater to display the ReadingListContentSuggestions. BUG= 702241 , 706296 Review-Url: https://codereview.chromium.org/2755383002 Cr-Commit-Position: refs/heads/master@{#460731} [modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [add] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_reading_list_item.h [add] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_reading_list_item.mm [modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/content_suggestion.h [modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4 commit d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4 Author: gambard <gambard@chromium.org> Date: Thu Mar 30 15:22:02 2017 Add mediation for ReadingList distillation state This CL adds a enum to map the ReadingListEntry::DistillationState with the states needed to display the Reading List entry. BUG= 706296 Review-Url: https://codereview.chromium.org/2784803002 Cr-Commit-Position: refs/heads/master@{#460762} [modify] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [modify] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm [modify] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h [modify] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm [modify] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm [add] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/reading_list/reading_list_utils.h [add] https://crrev.com/d5543110dfdaa0b8fbe7f4b69797cef6b0f5dca4/ios/chrome/browser/ui/reading_list/reading_list_utils.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50148353a87f81026afab0ea2647ad66eb25cf8c commit 50148353a87f81026afab0ea2647ad66eb25cf8c Author: gambard <gambard@chromium.org> Date: Mon Apr 03 14:07:06 2017 Add FaviconAttributesProvider to ContentSuggestions This CL allows the ContentSuggestionsMediator to provide favicon attributes. BUG= 706296 , 706427 Review-Url: https://codereview.chromium.org/2782613004 Cr-Commit-Position: refs/heads/master@{#461422} [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/50148353a87f81026afab0ea2647ad66eb25cf8c/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/892e302345218f7ed2ecfd9295a6011df806026e commit 892e302345218f7ed2ecfd9295a6011df806026e Author: gambard <gambard@chromium.org> Date: Thu Apr 06 10:39:07 2017 Display offline availability on ContentSuggestions This CL displays the offline availability of the ReadingList items in ContentSuggestions. BUG= 706296 , 702241 Review-Url: https://codereview.chromium.org/2796273002 Cr-Commit-Position: refs/heads/master@{#462416} [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestion.h [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestion.mm [add] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestion_extra_builder.h [add] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestion_extra_builder.mm [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/reading_list/reading_list_utils.h [modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/reading_list/reading_list_utils.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8168c8dd3b54ae05890afeeaca934acda86ce7ff commit 8168c8dd3b54ae05890afeeaca934acda86ce7ff Author: gambard <gambard@chromium.org> Date: Thu Apr 06 11:30:44 2017 Fetch favicon for ReadingListItem The ContentSuggestionsUpdater now fetches the favicon for the ReadingListItems. BUG= 706296 Review-Url: https://codereview.chromium.org/2803623002 Cr-Commit-Position: refs/heads/master@{#462426} [modify] https://crrev.com/8168c8dd3b54ae05890afeeaca934acda86ce7ff/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
The ReadingList should have the same design as the suggested articles.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/057d7cae6af79ac7fb8c43080d0499a2673e2952 commit 057d7cae6af79ac7fb8c43080d0499a2673e2952 Author: gambard <gambard@chromium.org> Date: Thu May 11 13:05:12 2017 Use the same design for all suggestions All the suggestions (Reading List and Suggested Articles) should have the same design. This CL removes the use of the Reading List Cells in ContentSuggestions. BUG= 706296 Review-Url: https://codereview.chromium.org/2865183003 Cr-Commit-Position: refs/heads/master@{#470935} [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/components/ntp_snippets/content_suggestion.h [delete] https://crrev.com/52bf555607be9fcfa8ad89601b0554db3c9af96b/components/ntp_snippets/reading_list/reading_list_distillation_state_util.cc [delete] https://crrev.com/52bf555607be9fcfa8ad89601b0554db3c9af96b/components/ntp_snippets/reading_list/reading_list_distillation_state_util.h [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/components/reading_list/core/reading_list_entry.h [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [delete] https://crrev.com/52bf555607be9fcfa8ad89601b0554db3c9af96b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h [delete] https://crrev.com/52bf555607be9fcfa8ad89601b0554db3c9af96b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm [add] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h [rename] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.mm [add] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item_unittest.mm [delete] https://crrev.com/52bf555607be9fcfa8ad89601b0554db3c9af96b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_reading_list_item.h [delete] https://crrev.com/52bf555607be9fcfa8ad89601b0554db3c9af96b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_reading_list_item.mm [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/content_suggestion.h [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/content_suggestion.mm [delete] https://crrev.com/52bf555607be9fcfa8ad89601b0554db3c9af96b/ios/chrome/browser/ui/content_suggestions/content_suggestion_extra_builder.h [delete] https://crrev.com/52bf555607be9fcfa8ad89601b0554db3c9af96b/ios/chrome/browser/ui/content_suggestions/content_suggestion_extra_builder.mm [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [add] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline.png [add] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline@2x.png [add] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline@3x.png [modify] https://crrev.com/057d7cae6af79ac7fb8c43080d0499a2673e2952/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
Comment 1 by bugdroid1@chromium.org
, Mar 30 2017