New issue
Advanced search Search tips

Issue 706288 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Move resource loading code from content/child to blink/platform

Project Member Reported by yhirano@chromium.org, Mar 29 2017

Issue description

...after removing old ChomeIPC code.
 
Labels: -Type-Bug Yukari Type-Task
let me add a custom label Yukari to track platform/loading related tasks

Also Task is a right type for this kind of things?
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b67d8156fb61630ab593fd17154b680e0cbdf4c0

commit b67d8156fb61630ab593fd17154b680e0cbdf4c0
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 10 13:20:14 2018

Merge SecurityFilterPeer and ReplaceContentPeer

SecuritFilterPeer had two subclasses but now it has only one subclass.
Let's merge them.

Bug: 706288
Change-Id: I59507f62d76c67df57fa80c9e59322c51ace27fe
Reviewed-on: https://chromium-review.googlesource.com/859257
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528291}
[modify] https://crrev.com/b67d8156fb61630ab593fd17154b680e0cbdf4c0/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/b67d8156fb61630ab593fd17154b680e0cbdf4c0/chrome/renderer/security_filter_peer.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d4c890570b8f3e4a0dc987aeb2fa51c678aef51

commit 8d4c890570b8f3e4a0dc987aeb2fa51c678aef51
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 10 13:28:04 2018

Add DCHECKs to SecurityFilterPeer methods

A SecurityFilterPeer is created only when the associated request is
rejected, which means content::RequestPeer methods other than
OnCompletedRequest must not be called.

Bug: 706288
Change-Id: I12eaef300909d1bc76ae2a9794c7b4d707b70c86
Reviewed-on: https://chromium-review.googlesource.com/859260
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528292}
[modify] https://crrev.com/8d4c890570b8f3e4a0dc987aeb2fa51c678aef51/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/8d4c890570b8f3e4a0dc987aeb2fa51c678aef51/chrome/renderer/security_filter_peer.h

Sign in to add a comment