New issue
Advanced search Search tips

Issue 706285 link

Starred by 4 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup: at least 60 LayoutTests define a function gc()

Project Member Reported by dmazz...@chromium.org, Mar 29 2017

Issue description

There's a canonical implementation in LayoutTests/resources/gc.js.

Most of the tests that define their own gc() function to force garbage collection should probably just use that canonical implementation.

 
Status: Available (was: Untriaged)
I will check this !!!
Submitted patch https://codereview.chromium.org/2847943002/ for review. 
Thanks !!!
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ce4fda39a836c2f345c78a00374b2776aa9e1d2

commit 0ce4fda39a836c2f345c78a00374b2776aa9e1d2
Author: nikhil.sahni <nikhil.sahni@samsung.com>
Date: Tue May 02 20:17:08 2017

Cleanup LayoutTests that define a function gc().

There are some LayoutTests that define their
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

BUG=706285

Review-Url: https://codereview.chromium.org/2847943002
Cr-Commit-Position: refs/heads/master@{#468757}

[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/canvas/canvas-context-gc-custom-properties.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/canvas/webgl/context-destroyed-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/DOMImplementation/detached-doctype.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/HTMLElement/class-list-gc.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/HTMLInputElement/cloned-input-checked-state.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/NodeList/adoptNode-node-list-cache.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/NodeList/childNodes-reset-cache.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/Range/remove-all-children-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/Window/timer-null-script-execution-context.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/dataset-gc.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/gc-custom-prototype.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/navigator-detached-no-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/node-iterator-document-moved-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/node-iterator-reference-node-moved-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/dom/text-node-append-data-remove-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/gc-freeze-with-attribute-listeners.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-channel-gc-2.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-channel-gc-3.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-channel-gc-4.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-channel-gc.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-channel-listener-circular-ownership.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-port-constructor-for-deleted-document.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-port-deleted-document.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-port-deleted-frame.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-port-inactive-document.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/message-port-no-wrapper.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/events/resources/message-port-iframe.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/forms/ValidityState-removed-control.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/forms/change-form-element-document-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/forms/dangling-form-element-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/forms/form-associated-element-crash2.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/forms/removed-image-as-property.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/html/pending-stylesheet-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/js/exec-state-marking.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/media/lifetime.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/workers/shared-worker-event-listener.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/workers/shared-worker-gc.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/workers/worker-event-listener.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/workers/worker-gc.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/workers/worker-init.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/workers/worker-supplement-gc.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/workers/worker-terminate.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/http/tests/inspector/network/long-script-content.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/images/destroyed-image-load-event.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/media/remoteplayback/availability-callback-gc.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/svg/custom/tref-clone-crash.html
[modify] https://crrev.com/0ce4fda39a836c2f345c78a00374b2776aa9e1d2/third_party/WebKit/LayoutTests/web-animations-api/animation-finish-promise-gc.html

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01eb503c9c39b7eb8c46398dab9a7321414da746

commit 01eb503c9c39b7eb8c46398dab9a7321414da746
Author: kyungyoung Heo <bbvch13531@gmail.com>
Date: Tue Oct 31 01:52:06 2017

Cleanup LayoutTests that define a function gc().

There are still some LayoutTests that define their
own gc ,instead of that they can use
canonical implementation in LayoutTests/resources/gc.js.

Bug: 706285
Change-Id: I5b6c3d6a610864617601ac816bccadfa2632bd32
Reviewed-on: https://chromium-review.googlesource.com/742761
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512708}
[modify] https://crrev.com/01eb503c9c39b7eb8c46398dab9a7321414da746/AUTHORS
[modify] https://crrev.com/01eb503c9c39b7eb8c46398dab9a7321414da746/third_party/WebKit/LayoutTests/fast/workers/shared-worker-load-error.html
[modify] https://crrev.com/01eb503c9c39b7eb8c46398dab9a7321414da746/third_party/WebKit/LayoutTests/fast/workers/worker-messageport-gc.html
[modify] https://crrev.com/01eb503c9c39b7eb8c46398dab9a7321414da746/third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/915d7a661436df962fdce00664723e0052306e28

commit 915d7a661436df962fdce00664723e0052306e28
Author: Myung-jong Kim <mjkim610@gmail.com>
Date: Mon Dec 04 17:11:16 2017

Remove redundant gc from LayoutTests

Bug: 706285
Change-Id: I19af8517f4cc561a30afb25ca3b3150a8dd41b12
Reviewed-on: https://chromium-review.googlesource.com/805515
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521371}
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/fast/dom/resources/script-element-gc.js
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/fast/events/destroyed-atomic-string.html-disabled
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/fast/events/nested-event-remove-node-crash.html
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/fast/events/script-tests/event-listener-sharing.js
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/fast/js/mozilla/resources/moz-test-pre.js
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/fast/js/script-tests/cached-eval-gc.js
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/fast/js/script-tests/with-scope-gc.js
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/http/tests/worklet/worklet-should-report-context-destroyed.html
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/storage/websql/multiple-databases-garbage-collection.html
[modify] https://crrev.com/915d7a661436df962fdce00664723e0052306e28/third_party/WebKit/LayoutTests/storage/websql/multiple-databases-garbage-collection.js

Comment 9 by mjkim...@gmail.com, Dec 5 2017

There seem to be no more redundant gc's in LayoutTests except for /resources/js-test.js.

Search shows 170 files that include js-test.js's gc. (Some of them already include gc.js so no work will be needed for those.)

https://cs.chromium.org/search/?q=%22js-test.js%22+%2B+%22gc()%22+file:%5Esrc/third_party/WebKit/LayoutTests/+package:%5Echromium$&type=cs

Any suggestions on how to proceed? :)
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 5

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment