Spanning table cell may be painted in wrong background color |
||
Issue descriptionhttp://jsbin.com/vazejaf The top-left spanning table cell is painted with yellow background, while the containing row has blue background. This is because we paint the table starting from the second row in the case. When painting the second row, TableSectionPainter::primaryCellToPaint(1, 0) returns the top-left cell, and the background is painted using the second row's background.
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29bb853d07d410286f932802134ff3732777f713 commit 29bb853d07d410286f932802134ff3732777f713 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Thu Mar 30 18:08:55 2017 Fix spanning cell painting background from wrong row Previously when we painted a table section not from the first row and the starting row contained spanned cells, we may paint the cell with the wrong row background. Now expands the dirty rows/columns to the top/left to cover the grid slots from which the spanning primary cells' originate. In this way, we also simply painting code to just consider the primary cells originating from the grid slots. This is also a preparation of crbug.com/663208 to paint background of each table section/row in one display item. BUG= 706255 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2783953002 Cr-Commit-Position: refs/heads/master@{#460822} [add] https://crrev.com/29bb853d07d410286f932802134ff3732777f713/third_party/WebKit/LayoutTests/paint/tables/row-span-visible-from-second-row-expected.html [add] https://crrev.com/29bb853d07d410286f932802134ff3732777f713/third_party/WebKit/LayoutTests/paint/tables/row-span-visible-from-second-row.html [modify] https://crrev.com/29bb853d07d410286f932802134ff3732777f713/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/29bb853d07d410286f932802134ff3732777f713/third_party/WebKit/Source/core/layout/LayoutTableSection.h [modify] https://crrev.com/29bb853d07d410286f932802134ff3732777f713/third_party/WebKit/Source/core/layout/LayoutTableSectionTest.cpp [modify] https://crrev.com/29bb853d07d410286f932802134ff3732777f713/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp [modify] https://crrev.com/29bb853d07d410286f932802134ff3732777f713/third_party/WebKit/Source/core/paint/TableSectionPainter.h
,
Mar 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, Mar 29 2017