The edges of the ink drop ripples and highlights tend to be blurry in fractional scales (e.g. 1.25x). Here is one example: the highlight on bookmark menus.
and here's how it should look.
Here is another motivating example to demonstrate this is not isolated.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c commit 7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c Author: estade <estade@chromium.org> Date: Fri Mar 31 02:04:11 2017 Make updates to InkDropHighlight to pave the way for improved ink drops at fractional scales. Also make some updates to BookmarkBarView button types and InkDropPaintedLayerDelegates to fix bookmark button highlights. Test with --force-device-scale-factor=1.25x. BUG=706228 Review-Url: https://codereview.chromium.org/2786543002 Cr-Commit-Position: refs/heads/master@{#460993} [modify] https://crrev.com/7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c/ui/views/animation/ink_drop_highlight.cc [modify] https://crrev.com/7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c/ui/views/animation/ink_drop_highlight.h [modify] https://crrev.com/7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c/ui/views/animation/ink_drop_host_view.cc [modify] https://crrev.com/7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c/ui/views/animation/ink_drop_painted_layer_delegates.cc [modify] https://crrev.com/7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c/ui/views/animation/ink_drop_painted_layer_delegates.h [modify] https://crrev.com/7caded54fe6a6ab2db2fa9c8960699bae7fe1e5c/ui/views/animation/square_ink_drop_ripple.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ce931e71d004ae9028b75fb7fbe3c68f8538f4 commit 73ce931e71d004ae9028b75fb7fbe3c68f8538f4 Author: estade <estade@chromium.org> Date: Tue Apr 11 19:18:48 2017 Remove SquareInkDropRipple::AnimateToCenterPoint This was always animating to the same point; i.e. no effective change was made after the initial transform on the root layer. I discovered this while investigating the linked bug and it will make my next fix easier, but in itself it should have no behavioral impact. BUG=706228 Review-Url: https://codereview.chromium.org/2805753002 Cr-Commit-Position: refs/heads/master@{#463717} [modify] https://crrev.com/73ce931e71d004ae9028b75fb7fbe3c68f8538f4/ui/views/animation/square_ink_drop_ripple.cc [modify] https://crrev.com/73ce931e71d004ae9028b75fb7fbe3c68f8538f4/ui/views/animation/square_ink_drop_ripple.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfd215a5b6b3d1ab60398fc8c4a522b0d8ce611e commit cfd215a5b6b3d1ab60398fc8c4a522b0d8ce611e Author: estade <estade@chromium.org> Date: Thu Apr 13 16:17:47 2017 Improve toolbar button ink drop ripples at 1.25x 1. combining scaling and translation transforms on nested layers seems to create unfixable blurriness, so instead do all transforms on the painted layers. 2. adjust the size of the painted layers by a fractional amount to ensure pixel alignment of edges of layer (at start and end points of animation). BUG=706228 Review-Url: https://codereview.chromium.org/2805813007 Cr-Commit-Position: refs/heads/master@{#464430} [modify] https://crrev.com/cfd215a5b6b3d1ab60398fc8c4a522b0d8ce611e/ui/views/animation/square_ink_drop_ripple.cc [modify] https://crrev.com/cfd215a5b6b3d1ab60398fc8c4a522b0d8ce611e/ui/views/animation/square_ink_drop_ripple.h [modify] https://crrev.com/cfd215a5b6b3d1ab60398fc8c4a522b0d8ce611e/ui/views/animation/square_ink_drop_ripple_unittest.cc
Comment 1 by est...@chromium.org
, Mar 29 20172.0 KB
2.0 KB View Download