Need to instrument SharedModelTypeProcessor and ModelTypeWorker
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49e09c1721596fe0925bfd290750fd6c707b09cc commit 49e09c1721596fe0925bfd290750fd6c707b09cc Author: pavely <pavely@chromium.org> Date: Thu Mar 30 06:08:42 2017 [Sync] Implement EstimateMemoryUsage for SharedModelTypeProcessor and ModelTypeWorker This CL implements EstimateMemoryUsage for processor, worker and all subobjects. R=pnoland@chromium.org BUG= 706214 Review-Url: https://codereview.chromium.org/2781863004 Cr-Commit-Position: refs/heads/master@{#460677} [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/base/proto_value_ptr.h [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/engine/non_blocking_sync_common.cc [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/engine/non_blocking_sync_common.h [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/engine_impl/model_type_worker.cc [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/engine_impl/model_type_worker.h [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/engine_impl/worker_entity_tracker.cc [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/engine_impl/worker_entity_tracker.h [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/model/entity_data.cc [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/model/entity_data.h [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/model_impl/processor_entity_tracker.cc [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/model_impl/processor_entity_tracker.h [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/model_impl/shared_model_type_processor.cc [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/model_impl/shared_model_type_processor.h [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/protocol/proto_memory_estimations.cc [modify] https://crrev.com/49e09c1721596fe0925bfd290750fd6c707b09cc/components/sync/protocol/proto_visitors.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0af09891c51edf00a52822907147c23b4f92aba1 commit 0af09891c51edf00a52822907147c23b4f92aba1 Author: pavely <pavely@chromium.org> Date: Tue Jun 20 22:20:04 2017 [Sync] Record sync memory usage in histogram broken by datatypes Memory estimate is collected from Directory for directory based datatypes and from SharedModelTypeProcessor for USS datatypes. It is triggered right after configuration when all sync data is loaded into memory. BUG= 706214 R=pnoland@chromium.org Review-Url: https://codereview.chromium.org/2950583003 Cr-Commit-Position: refs/heads/master@{#480992} [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/base/data_type_histogram.cc [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/base/data_type_histogram.h [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/driver/data_type_controller.h [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/driver/directory_data_type_controller.cc [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/driver/directory_data_type_controller.h [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/driver/model_type_controller.cc [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/driver/model_type_controller.h [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/driver/proxy_data_type_controller.cc [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/driver/proxy_data_type_controller.h [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/model/model_type_debug_info.cc [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/model/model_type_debug_info.h [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/syncable/directory.cc [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/components/sync/syncable/directory.h [modify] https://crrev.com/0af09891c51edf00a52822907147c23b4f92aba1/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e commit dd02c1a6a74ab9e33299a01f2c5348867cbaa15e Author: Daniel Cheng <dcheng@chromium.org> Date: Wed Jun 21 05:35:44 2017 Revert "[Sync] Record sync memory usage in histogram broken by datatypes" Fix ChromiumOS x86-generic Compile builder: obj/components/sync/libsync.a(directory.o)(.debug_addr+0x25c0): error: undefined reference to 'unsigned int sync_pb::EstimateMemoryUsage<sync_pb::DataTypeProgressMarker>(sync_pb::DataTypeProgressMarker const&)' TBR=pavely@chromium.org,isherman@chromium.org,pnoland@chromium.org Bug: 706214 Change-Id: I6694cc322b3f0ff302c4b47386c0e3084ac1508f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/542435 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#481116} [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/base/data_type_histogram.cc [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/base/data_type_histogram.h [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/driver/data_type_controller.h [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/driver/directory_data_type_controller.cc [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/driver/directory_data_type_controller.h [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/driver/model_type_controller.cc [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/driver/model_type_controller.h [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/driver/proxy_data_type_controller.cc [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/driver/proxy_data_type_controller.h [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/model/model_type_debug_info.cc [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/model/model_type_debug_info.h [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/syncable/directory.cc [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/components/sync/syncable/directory.h [modify] https://crrev.com/dd02c1a6a74ab9e33299a01f2c5348867cbaa15e/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df8bde78e96e636afd883deea1fb7e0752a78599 commit df8bde78e96e636afd883deea1fb7e0752a78599 Author: pavely <pavely@chromium.org> Date: Thu Jun 22 01:56:36 2017 Reland: [Sync] Record sync memory usage in histogram broken by datatypes Memory estimate is collected from Directory for directory based datatypes and from SharedModelTypeProcessor for USS datatypes. It is triggered right after configuration when all sync data is loaded into memory. BUG= 706214 R=pnoland@chromium.org TBR=isherman@chromium.org This is a reland of http://crrev.com/2950583003. Review-Url: https://codereview.chromium.org/2949923004 Cr-Commit-Position: refs/heads/master@{#481400} [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/base/data_type_histogram.cc [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/base/data_type_histogram.h [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/driver/data_type_controller.h [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/driver/directory_data_type_controller.cc [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/driver/directory_data_type_controller.h [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/driver/model_type_controller.cc [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/driver/model_type_controller.h [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/driver/proxy_data_type_controller.cc [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/driver/proxy_data_type_controller.h [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/model/model_type_debug_info.cc [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/model/model_type_debug_info.h [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/protocol/proto_memory_estimations.cc [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/syncable/directory.cc [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/components/sync/syncable/directory.h [modify] https://crrev.com/df8bde78e96e636afd883deea1fb7e0752a78599/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Mar 30 2017