New issue
Advanced search Search tips

Issue 706171 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Update interface PhotoCapabiltiies

Project Member Reported by mcasas@chromium.org, Mar 28 2017

Issue description

Should look like :

interface PhotoCapabilities {
  readonly attribute FrozenArray<boolean>       redEyeReduction;
  readonly attribute MediaSettingsRange         imageHeight;
  readonly attribute MediaSettingsRange         imageWidth;
  readonly attribute FrozenArray<FillLightMode> fillLightMode;
};

after
https://github.com/w3c/mediacapture-image/pull/164

which addressed
https://github.com/w3c/mediacapture-image/issues/163
 

Comment 1 by mcasas@chromium.org, Mar 28 2017

Also because of https://github.com/w3c/mediacapture-image/issues/156
(and associated PR https://github.com/w3c/mediacapture-image/pull/165)
probably |redEyeReduction| will change to an enum, and I think it's 
fine to bundle it up in this bug too.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38d77c83ff942c116f8653dba2c643f63e16ae7f

commit 38d77c83ff942c116f8653dba2c643f63e16ae7f
Author: mcasas <mcasas@chromium.org>
Date: Wed Mar 29 19:09:48 2017

Image Capture: update PhotoCapabilities.idl to latest Spec changes

This CL updates PhotoCapabilities.idl and associated logic to the extent
possible before touching the mojo interface, which essentially means:

- |redEyeReduction| changes to be an enum of supported modes
- |fillLightMode| changes to be an array of supported modes

Referring to the following Spec PRs :

https://github.com/w3c/mediacapture-image/pull/164
 (which addressed https://github.com/w3c/mediacapture-image/issues/163)
and
https://github.com/w3c/mediacapture-image/pull/165
 (which addressed https://github.com/w3c/mediacapture-image/issues/156)

BUG= 706171 

Review-Url: https://codereview.chromium.org/2785503003
Cr-Commit-Position: refs/heads/master@{#460480}

[modify] https://crrev.com/38d77c83ff942c116f8653dba2c643f63e16ae7f/third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html
[modify] https://crrev.com/38d77c83ff942c116f8653dba2c643f63e16ae7f/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/38d77c83ff942c116f8653dba2c643f63e16ae7f/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp
[modify] https://crrev.com/38d77c83ff942c116f8653dba2c643f63e16ae7f/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h
[modify] https://crrev.com/38d77c83ff942c116f8653dba2c643f63e16ae7f/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

Comment 3 by mcasas@chromium.org, Mar 29 2017

Status: Fixed (was: Started)

Sign in to add a comment