Issue metadata
Sign in to add a comment
|
Samus enters docked mode when lid is closed while empty Apple Type-C adapter is connected |
||||||||||||||||||||||
Issue descriptionGoogle Chrome : 59.0.3051.3 (Official Build) Platform : 9408.0.0 (Official Build) dev-channel What steps will reproduce the problem? (1) Sign in (2) Plug an empty Apple multi-port adapter (usb/external display port/type-c power port) (3) Close the lid What is the expected result? It should suspend in less than 10 seconds Lights on the panel should turn off What happens instead? It does not suspend for 15 min More than 1% power consumed A lot of kernel warnings, trace stack shown at /var/log/messages Always reproducible
,
Mar 28 2017
helenzhang@, please check previous milestone(s)
,
Mar 28 2017
It's not reproducible in M57: 9202.58.0, 57.0.2987.128. It's reproducible M58: 9334.23.0/58.0.3029.39. It's reproducible on another Samus.
,
Mar 28 2017
,
Mar 28 2017
powerd is behaving as expected; Chrome reported that an external display is connected (probably when you connected the dock), so the system entered docked mode when the lid was closed: [0328/192257:INFO:daemon.cc(1392)] Chrome is using presentation display mode ... [0328/193021:INFO:daemon.cc(511)] Lid closed [0328/193021:INFO:input_device_controller.cc(170)] Inhibiting /sys/devices/pci0000:00/INT3432:00/i2c-0/i2c-ATML0000:01/input/input4 [0328/193021:INFO:input_device_controller.cc(170)] Inhibiting /sys/devices/pci0000:00/INT3433:00/i2c-1/i2c-ATML0001:01/input/input5 [0328/193021:INFO:input_device_controller.cc(170)] Inhibiting /sys/devices/platform/i8042/serio0/input/input3 [0328/193021:INFO:input_device_controller.cc(158)] Disabling wakeup for /sys/devices/pci0000:00/INT3432:00/i2c-0/i2c-ATML0000:01/input/input4 through /sys/devices/pci0000:00/INT3432:00/i2c-0/i2c-ATML0000:01 [0328/193021:INFO:input_device_controller.cc(158)] Disabling wakeup for /sys/devices/platform/i8042/serio0/input/input3 through /sys/devices/platform/i8042/serio0 [0328/193021:INFO:state_controller.cc(831)] Turning panel off after entering docked mode [0328/193021:INFO:display_power_setter.cc(82)] Asking Chrome to turn internal display off and external displays on [0328/193021:INFO:internal_backlight_controller.cc(682)] Setting brightness to 0 (0%) over 0 ms [0328/193021:INFO:state_controller.cc(878)] Ready to perform lid-closed action (no-op) [0328/193021:INFO:daemon.cc(1392)] Chrome is using presentation display mode I'll let others comment about whether it's expected that Chrome thinks an external display is connected when this empty adapter is plugged in.
,
Mar 28 2017
@5: that sounds like a display driver bug, if there is no downstream the display shouldn't appear connected. Helen: - can you please paste the output of modetest so we can check that the kernel does think it's connected (that it's not a flake) - what exact adapter are you using?
,
Mar 28 2017
,
Mar 28 2017
I don't think this is important enough to block a stable release.
,
Mar 28 2017
Looks like a regression from M-57, It is consistent, and UX changes towards (the defaults of) no locking and faster battery discharge if audio is playing.
,
Mar 28 2017
Please refer in the link: https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/706149 - a screenshot of Apple type-c adapters I used - modetest outputs - a screenshot showing "...unknown display " with empty Apple Type-C connected
,
Mar 28 2017
,
Mar 29 2017
For the modetest_plugged.txt this is with which of the adapters connected (VGA or HDMI)? And just to confirm plugged means the dongle is plugged in but with no actual display? It is weird that we are getting modes without an EDID? 38 37 connected DP-1 0x0 5 37 modes: name refresh (Hz) hdisp hss hse htot vdisp vss vse vtot) 1024x768 60 1024 1048 1184 1344 768 771 777 806 65000 flags: nhsync, nvsync; type: driver 800x600 60 800 840 968 1056 600 601 605 628 40000 flags: phsync, pvsync; type: driver 800x600 56 800 824 896 1024 600 601 603 625 36000 flags: phsync, pvsync; type: driver 848x480 60 848 864 976 1088 480 486 494 517 33750 flags: phsync, pvsync; type: driver 640x480 60 640 656 752 800 480 489 492 525 25175 flags: nhsync, nvsync; type: driver props: 1 EDID: flags: immutable blob blobs: value: 2 DPMS: flags: enum enums: On=0 Standby=1 Suspend=2 Off=3 value: 0 33 psr: flags: enum enums: on=0 off=1 value: 0 34 audio: flags: enum enums: force-dvi=18446744073709551614 off=18446744073709551615 auto=0 on=1 value: 0 35 Broadcast RGB: flags: enum enums: Automatic=0 Full=1 Limited 16:235=2 value: 0
,
Mar 29 2017
> For the modetest_plugged.txt this is with which of the adapters connected (VGA or HDMI)? It was the HDMI-USBA-USBC multiport adapter > And just to confirm plugged means the dongle is plugged in but with no actual display? Right, no actual display.
,
Apr 12 2017
Any update here? This is marked as a stable blocker, and we are nearing stable promotion for 58. Dominik, is this something you could take a look at?
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/853eb1900af29ef99792e120a0bed894369540b2 commit 853eb1900af29ef99792e120a0bed894369540b2 Author: Dominik Behr <dbehr@chromium.org> Date: Wed Apr 19 06:33:19 2017 CHROMIUM: drm/i915: fix connection status check from dp_dpcd_detect I18f5457817badc3a9fdf4ac863d39fcdbdf51c70 also missed a check of connection status returned from intel_dp_dpcd_detect resulting in monitors being detected even if only adapter without monitor attached is plugged in. BUG= chromium:706149 TEST=connect Apple USB-C-HDMI adapter and see if there is monitor detected\ using modeprint i915 in shell. Change-Id: Iae3fd7667b2c909a420472f736f88e14465d226c Signed-off-by: Dominik Behr <dbehr@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/480980 Commit-Ready: Stéphane Marchesin <marcheu@chromium.org> Tested-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> [modify] https://crrev.com/853eb1900af29ef99792e120a0bed894369540b2/drivers/gpu/drm/i915/intel_dp.c
,
Apr 19 2017
,
Apr 19 2017
This bug requires manual review: Only 5 days from stable, we might already have a stable candidate build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
LGTM for 58.
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0df323b9ce9951007eeca16c36610e44265e83d1 commit 0df323b9ce9951007eeca16c36610e44265e83d1 Author: Dominik Behr <dbehr@chromium.org> Date: Tue Apr 25 22:46:36 2017 CHROMIUM: drm/i915: fix connection status check from dp_dpcd_detect I18f5457817badc3a9fdf4ac863d39fcdbdf51c70 also missed a check of connection status returned from intel_dp_dpcd_detect resulting in monitors being detected even if only adapter without monitor attached is plugged in. BUG= chromium:706149 TEST=connect Apple USB-C-HDMI adapter and see if there is monitor detected\ using modeprint i915 in shell. Change-Id: Iae3fd7667b2c909a420472f736f88e14465d226c Signed-off-by: Dominik Behr <dbehr@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/480980 Commit-Ready: Stéphane Marchesin <marcheu@chromium.org> Tested-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> (cherry picked from commit 853eb1900af29ef99792e120a0bed894369540b2) Reviewed-on: https://chromium-review.googlesource.com/486246 [modify] https://crrev.com/0df323b9ce9951007eeca16c36610e44265e83d1/drivers/gpu/drm/i915/intel_dp.c
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/12e6c84c878296aec36863ab5ebbe8b0f43a6f68 commit 12e6c84c878296aec36863ab5ebbe8b0f43a6f68 Author: Dominik Behr <dbehr@chromium.org> Date: Tue Apr 25 22:48:14 2017 CHROMIUM: drm/i915: fix connection status check from dp_dpcd_detect I18f5457817badc3a9fdf4ac863d39fcdbdf51c70 also missed a check of connection status returned from intel_dp_dpcd_detect resulting in monitors being detected even if only adapter without monitor attached is plugged in. BUG= chromium:706149 TEST=connect Apple USB-C-HDMI adapter and see if there is monitor detected\ using modeprint i915 in shell. Change-Id: Iae3fd7667b2c909a420472f736f88e14465d226c Signed-off-by: Dominik Behr <dbehr@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/480980 Commit-Ready: Stéphane Marchesin <marcheu@chromium.org> Tested-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> (cherry picked from commit 853eb1900af29ef99792e120a0bed894369540b2) Reviewed-on: https://chromium-review.googlesource.com/487074 [modify] https://crrev.com/12e6c84c878296aec36863ab5ebbe8b0f43a6f68/drivers/gpu/drm/i915/intel_dp.c
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/12e6c84c878296aec36863ab5ebbe8b0f43a6f68 commit 12e6c84c878296aec36863ab5ebbe8b0f43a6f68 Author: Dominik Behr <dbehr@chromium.org> Date: Tue Apr 25 22:48:14 2017 CHROMIUM: drm/i915: fix connection status check from dp_dpcd_detect I18f5457817badc3a9fdf4ac863d39fcdbdf51c70 also missed a check of connection status returned from intel_dp_dpcd_detect resulting in monitors being detected even if only adapter without monitor attached is plugged in. BUG= chromium:706149 TEST=connect Apple USB-C-HDMI adapter and see if there is monitor detected\ using modeprint i915 in shell. Change-Id: Iae3fd7667b2c909a420472f736f88e14465d226c Signed-off-by: Dominik Behr <dbehr@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/480980 Commit-Ready: Stéphane Marchesin <marcheu@chromium.org> Tested-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> (cherry picked from commit 853eb1900af29ef99792e120a0bed894369540b2) Reviewed-on: https://chromium-review.googlesource.com/487074 [modify] https://crrev.com/12e6c84c878296aec36863ab5ebbe8b0f43a6f68/drivers/gpu/drm/i915/intel_dp.c
,
Apr 26 2017
Removing release block as this appears to be merged, thanks!
,
Apr 26 2017
It should have the RBS. It should be marked as Fixed. dbehr@, please remove Fixed label if not yet fixed
,
Apr 27 2017
Verified with version 58.0.3029.89/9334.58.0 beta. Will update the status once tested on M59.
,
Apr 27 2017
Verified with version 59.0.3071.28/9460.13.0 dev
,
Apr 28 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by helenzhang@google.com
, Mar 28 2017Summary: [Samus] not suspend if an empty Apple Type-C multiple adapter plugged (was: [Samus] not suspend in 15 minutes if an empty Apple Type-C multiple adapter plugged )