Issue metadata
Sign in to add a comment
|
[Confirm] button stays greyed out when updating non-expired card on Android |
||||||||||||||||||||||
Issue descriptionDevice name: Nexus 5 From "Settings > About Chrome" Application version:57.0.2987.110 Operating system: Android Steps to reproduce: 1) Open dump-truck.appspot.com in Chrome on Android. 2) Click "Address and CC (dropdown-based) on same page and come to the following page:" https://screenshot.googleplex.com/xuWWt9QHAqP 3) Click on the Credit card number field. 4) Input the wrong CVC number: https://screenshot.googleplex.com/VzP7OO863cS 5) Click "New card?" 6) Enter any expiration date and CVC Expected result: Should be able to click confirm. Actual result: The Confirm button stays greyed out.
,
Mar 29 2017
the bug is introduced by https://codereview.chromium.org/1964323002/patch/1/10001 mShouldRequestExpirationDate is set to be true in onNewCardLinkClicked(): https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java?q=cardunmaskprompt&dr=CSs&l=457 However, the constructer will not be called after it is true. So CalendarTask() was never executed. : https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java?q=cardunmaskprompt&dr=CSs&l=207 That's why getExpirationDateErrorType is always returning ERROR_TYPE_NOT_ENOUGH_INFO: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java?q=cardunmaskprompt&dr=CSs&l=615
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d4693afa913c9272ba70ae0dc8b2eb387f83bce commit 4d4693afa913c9272ba70ae0dc8b2eb387f83bce Author: szhangcs <szhangcs@google.com> Date: Fri Mar 31 21:58:04 2017 Always initialize this year and month Currently, after click newCardLink for server cards, the confirm button is always greyed. This Cl fixes this. The bug is introduced by: https://codereview.chromium.org/1964323002/patch/1/10001 When CardUnmaskPrompt is created. mShouldRequestExpirationDate is false. So CalendarTask() is never executed: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java?l=207 After onNewCardLinkClicked(), mShouldRequestExpirationDate is true. That's why getExpirationDateErrorType is always returning ERROR_TYPE_NOT_ENOUGH_INFO: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java?l=615 We need to execute CalendarTask() from somewhere. BUG= 706143 Review-Url: https://codereview.chromium.org/2784663002 Cr-Commit-Position: refs/heads/master@{#461241} [modify] https://crrev.com/4d4693afa913c9272ba70ae0dc8b2eb387f83bce/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
,
Jun 27 2017
,
Jul 21 2017
,
Jan 11 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by szhangcs@google.com
, Mar 28 2017