New issue
Advanced search Search tips

Issue 706133 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 469639



Sign in to add a comment

Use WebThread for WebAudio rendering

Project Member Reported by hongchan@chromium.org, Mar 28 2017

Issue description

Currently the WebAudio rendering pipeline depends on the audio device thread and this thread is not capable of running V8 instance. This has been a blocking issue for the implementation of AudioWorklet. With the recently introduced PushPullFIFO, replace the driving thread of WebAudio to WebThread which can power V8 instance properly.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1492075fce7add79a11e13a3c40d55261f4ae89d

commit 1492075fce7add79a11e13a3c40d55261f4ae89d
Author: hongchan <hongchan@chromium.org>
Date: Fri Apr 28 01:53:13 2017

Add WebThread in AudioDestination to support AudioWorkletThread

This CL to introduce a WebThread to run WebAudio graph rendering.

FYI: with the box 2d demo on my local machine (MacPro), the release
build of this patch was able to render 50 cubes concurrently before
glitch, which is similar to the current stable build that runs only on the
audio device thread. No significant performance regression is observed.

Design doc: https://docs.google.com/document/d/1WnqZHcA2TQjS1aKvzx2nnJ2y2tWK1Xp_0BhFGpsryaQ/edit#

BUG= 706133 

Review-Url: https://codereview.chromium.org/2777903005
Cr-Commit-Position: refs/heads/master@{#467819}

[modify] https://crrev.com/1492075fce7add79a11e13a3c40d55261f4ae89d/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/1492075fce7add79a11e13a3c40d55261f4ae89d/third_party/WebKit/Source/platform/audio/AudioDestination.cpp
[modify] https://crrev.com/1492075fce7add79a11e13a3c40d55261f4ae89d/third_party/WebKit/Source/platform/audio/AudioDestination.h
[modify] https://crrev.com/1492075fce7add79a11e13a3c40d55261f4ae89d/third_party/WebKit/Source/platform/audio/PushPullFIFO.cpp
[modify] https://crrev.com/1492075fce7add79a11e13a3c40d55261f4ae89d/third_party/WebKit/Source/platform/audio/PushPullFIFO.h
[add] https://crrev.com/1492075fce7add79a11e13a3c40d55261f4ae89d/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
[modify] https://crrev.com/1492075fce7add79a11e13a3c40d55261f4ae89d/third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp

Status: Verified (was: Started)

Sign in to add a comment