Issue metadata
Sign in to add a comment
|
Console scrolls to bottom of view automatically when opening object trees
Reported by
msilveir...@gmail.com,
Mar 28 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Log a JS object 2. Log a bunch of filler content so that scroll can be seen 3. Open console and scroll up to the JS object. What is the expected behavior? The scroll of the console view to be unaffected by opening or closing object trees. What went wrong? Sometimes (not always) the view will scroll to the bottom of the page. See attached animated gif. Did this work before? Yes ? Chrome version: 56.0.2924.87 Channel: n/a OS Version: OS X 10.12.1 Flash Version: First noticed it about two months ago. I have coworkers who do not experience this problem, but asking within a popular react dev chat reveals that other people have experienced this issue as well. I have reset my chrome settings to default, which has removed all extensions, and this issue still happens.
,
Apr 4 2017
,
Apr 6 2017
,
Apr 6 2017
Thank you for the report. I wasn't able to repro this bug on 56.0.2924.87, but the same bug occurs on tip of tree (59.0.3051.0). I did a bisect to a CodeMirror roll: https://chromium.googlesource.com/chromium/src/+/02128266dda94d175c6e4070a7f67b6232d6ae03 einbinder@, it looks like your patch to have console focus on key events and not on clicks will fix this. Could you please take a look?
,
Apr 13 2017
Issue 711143 has been merged into this issue.
,
Apr 18 2017
,
Apr 18 2017
Quoting 711727 just in case: >Already reported and fixed in https://github.com/codemirror/CodeMirror/issues/4657
,
Apr 25 2017
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5213f9bd6b6e6e95f40852b56ef62f1307c94ee commit c5213f9bd6b6e6e95f40852b56ef62f1307c94ee Author: luoe <luoe@chromium.org> Date: Fri Apr 28 15:34:03 2017 DevTools: clicking in console messages should not jump to bottom ConsolePrompt's moveCaretToEndOfPrompt() works by setting the CodeMirror editor's selection to the end. After a recent CodeMirror roll, doing so now scrolls the editor into view. This change in behavior led to an error where expanding an object in console would jump the viewport to bottom. This CL only focuses the prompt without moving the cursor, in some cases. BUG= 706128 Review-Url: https://codereview.chromium.org/2840663002 Cr-Commit-Position: refs/heads/master@{#468009} [add] https://crrev.com/c5213f9bd6b6e6e95f40852b56ef62f1307c94ee/third_party/WebKit/LayoutTests/inspector/console/console-focus-expected.txt [add] https://crrev.com/c5213f9bd6b6e6e95f40852b56ef62f1307c94ee/third_party/WebKit/LayoutTests/inspector/console/console-focus.html [modify] https://crrev.com/c5213f9bd6b6e6e95f40852b56ef62f1307c94ee/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
,
May 1 2017
,
May 1 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0eefdccfe7b90d093875ebda910a72fbb182b6b8 commit 0eefdccfe7b90d093875ebda910a72fbb182b6b8 Author: luoe <luoe@chromium.org> Date: Mon May 01 18:40:01 2017 DevTools: clicking in console messages should not jump to bottom ConsolePrompt's moveCaretToEndOfPrompt() works by setting the CodeMirror editor's selection to the end. After a recent CodeMirror roll, doing so now scrolls the editor into view. This change in behavior led to an error where expanding an object in console would jump the viewport to bottom. This CL only focuses the prompt without moving the cursor, in some cases. NOTRY=true NOPRESUBMIT=true BUG= 706128 Review-Url: https://codereview.chromium.org/2840663002 Cr-Commit-Position: refs/heads/master@{#468009} (cherry picked from commit c5213f9bd6b6e6e95f40852b56ef62f1307c94ee) Review-Url: https://codereview.chromium.org/2853053002 Cr-Commit-Position: refs/branch-heads/3071@{#331} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [add] https://crrev.com/0eefdccfe7b90d093875ebda910a72fbb182b6b8/third_party/WebKit/LayoutTests/inspector/console/console-focus-expected.txt [add] https://crrev.com/0eefdccfe7b90d093875ebda910a72fbb182b6b8/third_party/WebKit/LayoutTests/inspector/console/console-focus.html [modify] https://crrev.com/0eefdccfe7b90d093875ebda910a72fbb182b6b8/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
,
May 1 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msilveir...@gmail.com
, Mar 30 2017