New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706119 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

fast/forms/focus-selection-textarea.html failing on WebKit Win7 (dbg)

Project Member Reported by imch...@chromium.org, Mar 28 2017

Issue description

I reverted the patch (https://codereview.chromium.org/2784653002/) since this is breaking multiple bots. Please re-land once the issue is resolved. Sorry for the inconvenience. 

Comment 3 by hu...@opera.com, Mar 29 2017

Cc: yosin@chromium.org
The expected result [1] is the unchanged LayoutTests/fast/forms/focus-selection-textarea-expected.txt

I wonder how it passed the trybots... I will try the same CL again but without changing LayoutTests/fast/forms/focus-selection-textarea-expected.txt . 

[1] https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/9347/layout-test-results/fast/forms/focus-selection-textarea-expected.txt

Comment 4 by finnur@chromium.org, Mar 29 2017

Status: Assigned (was: Untriaged)
I see this has relanded, and since then fast/forms/focus-selection-textarea.html is failing consistently.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4cb1157a0036e40bf59382eeead754bc8b40bdd

commit e4cb1157a0036e40bf59382eeead754bc8b40bdd
Author: finnur <finnur@chromium.org>
Date: Wed Mar 29 13:33:09 2017

Disable a few failing tests.

BUG= 706371 ,  706375 ,  706119 
NOTRY=true
TBR=chrishtr

Review-Url: https://codereview.chromium.org/2779983004
Cr-Commit-Position: refs/heads/master@{#460370}

[modify] https://crrev.com/e4cb1157a0036e40bf59382eeead754bc8b40bdd/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by finnur@chromium.org, Mar 29 2017

Labels: -Sheriff-Chromium
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3afa26135e229e0f7fb81328a2bf4dcf966f90af

commit 3afa26135e229e0f7fb81328a2bf4dcf966f90af
Author: hugoh <hugoh@opera.com>
Date: Thu Mar 30 12:29:03 2017

Render focus-selection-textarea at constant font-size to avoid flakiness

When crrev.com/453211 updated FreeType on Linux, some glyphs
got bigger due to the new antialiasing and hinting settings.

Bigger glyphs made focus-selection-textarea.html layout differently.
With the new layout, scripted mouse clicks no longer hit the right spot.

After the manual rebaselining in crrev.com/453211, the expected result
on Linux started to include FAIL whereas other platforms still expected
PASS. This CL makes also Linux PASS.

BUG= 706119 ,  274030 

TEST=python third_party/WebKit/Tools/Scripts/run-webkit-tests -t\
     PcDebug LayoutTests/fast/forms/focus-selection-textarea.html

Review-Url: https://codereview.chromium.org/2786953002
Cr-Commit-Position: refs/heads/master@{#460732}

[modify] https://crrev.com/3afa26135e229e0f7fb81328a2bf4dcf966f90af/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3afa26135e229e0f7fb81328a2bf4dcf966f90af/third_party/WebKit/LayoutTests/fast/forms/focus-selection-textarea.html
[modify] https://crrev.com/3afa26135e229e0f7fb81328a2bf4dcf966f90af/third_party/WebKit/LayoutTests/platform/linux/fast/forms/focus-selection-textarea-expected.txt

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9093358a6c479fdf41bb40ec5203850608240600

commit 9093358a6c479fdf41bb40ec5203850608240600
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Mar 30 13:32:56 2017

Auto-rebaseline for r460732

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/647920

https://chromium.googlesource.com/chromium/src/+/3afa26135e229

BUG= 706119 
TBR=hugoh@opera.com

Review-Url: https://codereview.chromium.org/2786063003 .
Cr-Commit-Position: refs/heads/master@{#460742}

[modify] https://crrev.com/9093358a6c479fdf41bb40ec5203850608240600/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9093358a6c479fdf41bb40ec5203850608240600/third_party/WebKit/LayoutTests/fast/forms/focus-selection-textarea-expected.txt
[delete] https://crrev.com/286a79cc3d9b45f96709aa6b919ef94060b4fd92/third_party/WebKit/LayoutTests/platform/linux/fast/forms/focus-selection-textarea-expected.txt
[delete] https://crrev.com/286a79cc3d9b45f96709aa6b919ef94060b4fd92/third_party/WebKit/LayoutTests/platform/mac/fast/forms/focus-selection-textarea-expected.txt
[delete] https://crrev.com/286a79cc3d9b45f96709aa6b919ef94060b4fd92/third_party/WebKit/LayoutTests/platform/win/fast/forms/focus-selection-textarea-expected.txt
[delete] https://crrev.com/286a79cc3d9b45f96709aa6b919ef94060b4fd92/third_party/WebKit/LayoutTests/platform/win7/fast/forms/focus-selection-textarea-expected.txt

Comment 9 by hu...@opera.com, Apr 11 2017

Status: Fixed (was: Assigned)

Sign in to add a comment