[Mac] [Regression?] PopUp Blocker icon in the Omnibox is blurred during the animation |
||||||
Issue descriptionChrome Version: Version 59.0.3054.0 canary (64-bit) OS: MacOS 10.12.3 / Macbook Air 11" NonRetina What steps will reproduce the problem? (1) go to http://www.popuptest.com/popuptest1.html (2) take a look at the PopUp Blocker icon during the animation (3) What is the expected result? It should not be blurred. What happens instead? It is blurred. Please use labels and text to provide additional information. A screenshot is attached. Not sure if this is a regression.
,
Mar 29 2017
,
Mar 29 2017
Able to reproduce the issue on Mac-10.12.3 using chrome stable version 57.0.2987.110 and reported 59.0.3054.0 with the steps mentioned in comment#0. This is Non regression issue observed from M53# 53.0.2744.0 and confirming this to get more inputs from dev team. From M30 to M52 the PopUp Blocker icon looks different. Please find the attached screenshot for reference. Note:Issue is specific to Mac. Thanks..
,
Mar 30 2017
,
Mar 31 2017
For some reason this info did not get attached to the bug. commit 960575f6f8da2a8557c04adbeccc045cd51034b1 author shrike <shrike@chromium.org> Thu Mar 30 16:56:09 2017 committer Commit bot <commit-bot@chromium.org> Thu Mar 30 16:56:09 2017 tree d355d555e96aa19a729bb99060560e24b342e1b3 parent 34b3bb86e0e8490c439cc81537461be312577fb8 [diff] [Mac] Fix popup blocker animation's blurry end state. The final state of the omnibox's popup blocker animation is drawn to a non-integral point boundary, so the animated icon and text are blurry. This change floors the incoming frame so that the animation is always drawn to an integral point boundary. R=avi@chromium.org BUG= 706114 Review-Url: https://codereview.chromium.org/2784103002 Cr-Commit-Position: refs/heads/master@{#460798}
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e385704a77bfd6b5fd665bf860ae22beae237802 commit e385704a77bfd6b5fd665bf860ae22beae237802 Author: shrike <shrike@chromium.org> Date: Mon Apr 03 22:21:59 2017 [Mac] Fix jittery divider during omnibox's popup blocker animation. A followup to crrev 2784103002 which fixed the popup blocker animation's blurry end state. This cl addresses the jittery divider line that's drawn to the right of the popup blocker, also caused by the non-integral frame rect. R=avi@chromium.org BUG= 706114 Review-Url: https://codereview.chromium.org/2790233002 Cr-Commit-Position: refs/heads/master@{#461557} [modify] https://crrev.com/e385704a77bfd6b5fd665bf860ae22beae237802/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
,
Apr 4 2017
Tested the issue on 13 inch Non-Retina Mac OS X 10.12.3 using Latest Dev# 59.0.3061.3 and found the animation is looking fine without any blurry font. Could some one from MTV Team please look into the issue and check on 11" Non-Retina Mac OS X 10.12.3 and update the issue. Thank You.
,
Apr 4 2017
The PopUp Blocker Icon and the divider are no longer blurred in today's Version 59.0.3062.0 canary (64-bit). Tested on MacBook 11" Non-Retina. Thanks shrike@.
,
Apr 4 2017
OK, good. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by meh...@chromium.org
, Mar 28 2017