New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706112 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Support serialization operations on a buffer

Project Member Reported by xiy...@chromium.org, Mar 28 2017

Issue description

It would be nice to be able to do serialization directly on a buffer to avoid extra copies.

One case is gfx.mojom.SharedBufferSkBitmap that transports a serialized skia.mojom.Bitmap via shared buffer [1]. With the current vector based api, the code makes 4 copies:

Sender:
- skia::mojom::Bitmap::Serialize to a vector;
- Copy vector to a shared buffer;

Receiver:
- Copy data from the shared buffer to a vector;
- skia::mojom::Bitmap::Deserialize from the vector;

If vector can be taken off from the picture, we save two copies.

[1]: https://cs.chromium.org/chromium/src/ui/gfx/image/mojo/image_skia_struct_traits.cc?rcl=3e92f75741339da0c094fd863bb4a79575a74792&l=26,35,77,81
 

Comment 1 Deleted

Comment 2 by yzshen@chromium.org, Mar 28 2017

Thanks for filing this request!

I will try to find some time to work on it this week or early next week, if no one else has got a chance to work on it.
Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment