New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 706100 link

Starred by 1 user
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Generalize ReferrerChainEntry usage

Project Member Reported by jialiul@chromium.org, Mar 28 2017 
In addition to ClientDownloadRequest, We are going to use ReferrerChainEntry on other SafeBrowsing reports and requests. We need to rename a couple of things to generalize the scope of referrer chain usage:
(1) Rename proto enum field from DOWNLOD_URL to EVENT_URL
   -- google3 end change landed
(2) Rename functions in SafeBrowsingNavigationObserverManager class
(3) Revise comments in c/b/safe_browsing/safe_browsing_navigation_observer*.

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe

commit bfe0492224665ab6ce8dd8588dcfb474fb27fdbe
Author: jialiul <jialiul@chromium.org>
Date: Thu Mar 30 03:54:19 2017

Generalize the usage of referrer chain

Change a couple of things to generalize the scope of referrer chain usage:
(1) Rename proto enum field from DOWNLOD_URL to EVENT_URL
   -- google3 end change landed
(2) Rename functions in SafeBrowsingNavigationObserverManager class
(3) Revise comments in
   c/b/safe_browsing/safe_browsing_navigation_observer*.

BUG= 706100 

Review-Url: https://codereview.chromium.org/2777853005
Cr-Commit-Position: refs/heads/master@{#460653}

[modify] https://crrev.com/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe/chrome/browser/safe_browsing/safe_browsing_navigation_observer.h
[modify] https://crrev.com/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
[modify] https://crrev.com/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
[modify] https://crrev.com/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/bfe0492224665ab6ce8dd8588dcfb474fb27fdbe/components/safe_browsing/csd.proto

Comment 3 by jialiul@chromium.org, Mar 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment