Downloads - Download summary notification remains after opening file from snackbar |
||||
Issue description1. Download an APK. 2. Wait for it to finish. 3. Click "open" on the snackbar that pops up. 4. Notice that the summary notification is still there when it should be gone.
,
Mar 29 2017
,
Mar 29 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 30 2017
Verified in M59-59.0.3056.4 build
,
Apr 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3605a93ad1d456aadf346ef8eb5da59359b069a commit a3605a93ad1d456aadf346ef8eb5da59359b069a Author: David Trainor <dtrainor@chromium.org> Date: Sun Apr 02 16:40:56 2017 Properly clean up notification on download open Now that downloads is a foreground service with the summary, we need to manually clean up the summary in code, which means going through the notification service to do it. BUG= 706094 Review-Url: https://codereview.chromium.org/2781873002 Cr-Commit-Position: refs/heads/master@{#460459} (cherry picked from commit 6d71d9c5b9a95b7476beefaa9ace1fc8b54d5b43) Review-Url: https://codereview.chromium.org/2789083002 . Cr-Commit-Position: refs/branch-heads/3029@{#530} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/a3605a93ad1d456aadf346ef8eb5da59359b069a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/a3605a93ad1d456aadf346ef8eb5da59359b069a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java [modify] https://crrev.com/a3605a93ad1d456aadf346ef8eb5da59359b069a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java [modify] https://crrev.com/a3605a93ad1d456aadf346ef8eb5da59359b069a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java [modify] https://crrev.com/a3605a93ad1d456aadf346ef8eb5da59359b069a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Mar 29 2017