New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706085 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

"$1" text is incorrectly appended to Ethernet text in network panel

Project Member Reported by aashuto...@chromium.org, Mar 28 2017

Issue description

Chrome Version: <From about:version: Google Chrome 9.0.3051.3>
Chrome OS Version: <From about:version: Platform  9408.0.0>
Chrome OS Platform: <Samus>
Network info: <Ethernet>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Login as a user, connect to usb-Ethernet.
(2) Click on lower panel, navigate to "Connected to Ethernet". 

Actual Result: $1 shows up in the UI, appended to Ethernet text

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Screenshot 2017-03-28 at 11.18.25 AM.png
280 KB View Download
Components: UI>Shell>StatusArea
Owner: tdander...@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: tdander...@chromium.org
Labels: -Pri-3 Proj-MaterialDesign-CrOS Pri-1
Owner: est...@chromium.org
Evan, I think this is likely due to you re-purposing IDS_ASH_STATUS_TRAY_ETHERNET in this CL: https://codereview.chromium.org/2754963002

Comment 3 by est...@chromium.org, Mar 30 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4980bf9a7b63805fceae1fa3fb17922abb99f59a

commit 4980bf9a7b63805fceae1fa3fb17922abb99f59a
Author: estade <estade@chromium.org>
Date: Thu Mar 30 19:01:02 2017

ChromeOS - Fix some network related strings.

This fixes the ethernet string and removes broken/unused code for VPN
address in network info bubble.

BUG= 706085 

Review-Url: https://codereview.chromium.org/2781233002
Cr-Commit-Position: refs/heads/master@{#460841}

[modify] https://crrev.com/4980bf9a7b63805fceae1fa3fb17922abb99f59a/ash/ash_strings.grd
[modify] https://crrev.com/4980bf9a7b63805fceae1fa3fb17922abb99f59a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc

Comment 5 by est...@chromium.org, Mar 31 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1342f7eddf4feddaac3c061bdfa78502e500228

commit e1342f7eddf4feddaac3c061bdfa78502e500228
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Mar 31 18:28:44 2017

Ash Tray: Fix ip address to work for VPN

BUG= 706085 

Review-Url: https://codereview.chromium.org/2790463004
Cr-Commit-Position: refs/heads/master@{#461176}

[modify] https://crrev.com/e1342f7eddf4feddaac3c061bdfa78502e500228/ash/common/system/chromeos/network/network_state_list_detailed_view.cc

I continue to see this issue on R59.0.3055.0/9433.0.0. Did this land in ToT?
Cc: abodenha@chromium.org dhadd...@chromium.org sdantul...@chromium.org abod...@chromium.org zork@chromium.org
 Issue 706034  has been merged into this issue.
Status: Verified (was: Fixed)
ChromeOS Version 9438.0.0/59.0.3064.0
Cc: -yoshi@chromium.org

Sign in to add a comment