New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706069 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
inactive
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Tab switcher broken when "Animator duration scale"=0 in developer options

Project Member Reported by hongchic...@chromium.org, Mar 28 2017

Issue description

Chrome Version: 59.0.3050.4
OS: Android 

What steps will reproduce the problem?
http://feedback/#/Report/55897666233
http://feedback/#/Report/55873196953
http://feedback/#/Report/55715640091
http://feedback/#/Report/55739263031
http://feedback/#/Report/55979172958

We've reached out to users for more screenshot and will update to this bug later.
System log is available in feedback reports by going to "More info"-->"Binary data"

What is the expected result?
Chrome should show tabs

What happens instead?
Chrome shows tabs in blank or no tabs but black background

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Cc: candr...@chromium.org aska...@chromium.org
Labels: -Pri-3 ReleaseBlock-Dev M-59 Pri-1
Based on the volume of reports we should fix this before our next dev drop.
Steps to reproduce with screenshot from the user has been updated to 
http://go/chrome-androidlogs1/6/697058

Thanks
I don't believe the logs in c#3 are accurate, confirming with hongchichang@ now.

From the feedback reports:
"update causes open tabs on the switch tab screen to be invisible with not visible way to select any previous tabs"

"tabs button is not working.

instead of showing tabs, it only shows black background

The last tab in the list is always black with no title bar or close buttons. often other tabs are black too"

"when you press the tab switch (box shaped button) it doesn show any tabs so only way to switch tabs is swiping on the top"

Re #3 - Do we have the repro steps? The link above has screenshot and logs / bugreport.

Note: I tried one more device thats listed in feedback, but no luck in reproing the issue. S7 (SM-G930F)/7.0.
I tried upgrade from M58 to the playstore Dev build with and without existing tabs in Chrome M58.

Comment 6 Deleted

Sorry this is the right link:
go/chrome-androidlogs1/6/706069
Cc: aelias@chromium.org khushals...@chromium.org mdjones@chromium.org
khushalsagar@, mdjones@, aelias@ -- are you aware of anything that happened in the tab switcher recently that might cause this?

The test team is trying to repro, but trying to parallelize our efforts.

FWIW, this is the first M59 dev push, so our regression range sadly is anything that has landed after M58 branched...

We need a fix landed by tomorrow 3 PM PT if we want to ship a dev this week (which is something I would like to do).
Thanks for the steps in #7. Tried those steps and still no luck reproing.
I don't have any theory offhand, sorry.
Owner: aelias@chromium.org
Status: Assigned (was: Untriaged)
It so happens I can repro the issue on my personal Galaxy S7 (SM-G930U, MMB29M).  Seems nobody else found a repro, so I'll bisect.
Owner: bauerb@chromium.org
Bisected to https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eacf4677bda6954 "Respect animation multiplier from developer options".  I have my animation multipliers all set to zero to make my phone respond a bit faster, and this is likely the case for the users filing feedback reports as well.
Thanks aelias@! 
I can repro the issue with 'Animator duration scale' set to '0'.
Summary: Tab switcher broken when "Animator duration scale"=0 in developer options (was: Chrome show black/blank screen when users click on tab switcher to switch tabs)
Owner: aelias@chromium.org
I'm reverting in https://codereview.chromium.org/2782013002/

Cc: bauerb@chromium.org
hongchichang@, can you coordinate to inform users of how they can work around the regression in the short term (setting Animator duration scale to a non-zero value) and let them know we'll fix the bug in the next dev update?

aelias@ excellent work on narrowing this down so quickly, you rule.
Video tutorial for users who want to know how to enable Developer mode and change Animation duration scale on their android phones

https://youtu.be/_SBtu7sTpY8

Posting this link on Playstore comments
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb76338abd7a35297065ceb7d3aaecc8a3dd1bae

commit bb76338abd7a35297065ceb7d3aaecc8a3dd1bae
Author: aelias <aelias@chromium.org>
Date: Wed Mar 29 01:53:58 2017

Revert of [Android] Respect animation multiplier from Developer Options. (patchset #3 id:40001 of https://codereview.chromium.org/2743403006/ )

Reason for revert:
Breaks the tab switcher when scale is set to zero.

BUG= 706069 

Original issue's description:
> [Android] Respect animation multiplier from Developer Options.
>
> Review-Url: https://codereview.chromium.org/2743403006
> Cr-Commit-Position: refs/heads/master@{#457284}
> Committed: https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eacf4677bda6954

TBR=mdjones@chromium.org,bauerb@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2782013002
Cr-Commit-Position: refs/heads/master@{#460260}

[modify] https://crrev.com/bb76338abd7a35297065ceb7d3aaecc8a3dd1bae/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java

amineer@, Workaround has been sent to users reporting this issue from play store review and in-product feedback as well as shared with community team. Thanks. 
Status: Fixed (was: Assigned)
> aelias@ excellent work on narrowing this down so quickly

Thanks :).  Pure luck that I had the right configuration on hand in this case though.  I always knew this developer setting would cause a bug someday but I didn't think that would be useful!
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f8d0b3cdb5c51733c3c0f63dfb0b17dac7b9bff

commit 4f8d0b3cdb5c51733c3c0f63dfb0b17dac7b9bff
Author: bauerb <bauerb@chromium.org>
Date: Thu Mar 30 09:25:15 2017

Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/)

ChromeAnimation can now correctly deal with animations of length 0.

Originally reviewed at https://codereview.chromium.org/2743403006.

BUG= 706069 

Review-Url: https://codereview.chromium.org/2782143002
Cr-Commit-Position: refs/heads/master@{#460711}

[modify] https://crrev.com/4f8d0b3cdb5c51733c3c0f63dfb0b17dac7b9bff/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java

Verified fix in 59.0.3956.4. 

Sign in to add a comment