New issue
Advanced search Search tips

Issue 706053 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Desktop: Implement an error dialog.

Project Member Reported by ma...@chromium.org, Mar 28 2017

Issue description

To be shown when the merchant indicates that an error occurred.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21879589342d3991449a8f6eef8ef40802a61d5d

commit 21879589342d3991449a8f6eef8ef40802a61d5d
Author: mathp <mathp@chromium.org>
Date: Wed Mar 29 15:15:34 2017

[Payments] Desktop: Error message in the dialog.

Surfaced when the website calls "complete" in a failure scenario.

BUG= 706053 
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2768093006
Cr-Commit-Position: refs/heads/master@{#460390}

[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/error_message_view_controller.cc
[add] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/error_message_view_controller.h
[add] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/error_message_view_controller_browsertest.cc
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/chrome/test/BUILD.gn
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/components/payments/content/payment_request.cc
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/components/payments/content/payment_request_delegate.h
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/components/payments/content/payment_request_dialog.h
[modify] https://crrev.com/21879589342d3991449a8f6eef8ef40802a61d5d/components/payments_strings.grdp

Comment 2 by ma...@chromium.org, Mar 30 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment