New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705993 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 703122

Blocking:
issue 701330



Sign in to add a comment

Expose RTCContributingSource in JavaScript

Project Member Reported by hbos@chromium.org, Mar 28 2017

Issue description

RTCRtpContributingSource: https://w3c.github.io/webrtc-pc/#dom-rtcrtpcontributingsource

Retrieved from RTCRtpReceiver.getContributingSources();

Needs to be updated as new RTP packets arrive, however the values should only change in-between event loop task execution so we need to cache them.

RTCRtpReceiver should have a cache that RTCRtpContributingSources can access by source key. When getContributingSources is called or a contributing source member variable is accessed, refresh and/or use cache.

When fetching values from webrtc set should_update_contributing_sources_ to false and schedule a microtask to set it to true. The cache needs to retain values for any contributing source that has not been GC'd.
 

Comment 1 by hbos@chromium.org, Apr 12 2017

This has been exposed now, see https://bugs.chromium.org/p/chromium/issues/detail?id=703122:

interface RTCRtpReceiver {
    readonly attribute MediaStreamTrack track;
    sequence<RTCRtpContributingSource> getContributingSources();
};

interface RTCRtpContributingSource {
    readonly attribute DOMHighResTimeStamp timestamp;
    readonly attribute unsigned long       source;
};

This bug is to implement the rest of RTCRtpContributingSource.

Comment 2 by zstein@chromium.org, Sep 25 2017

Cc: zstein@chromium.org
Status: Verified (was: Started)
Splitting this up, this issue description is misleading:
 https://crbug.com/893158 
 https://crbug.com/893159 
In terms of implementing the initial stuff, this is fixed & verified since forever ago.

Sign in to add a comment