New issue
Advanced search Search tips

Issue 705956 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
derat@chromium.org
xiy...@chromium.org
abodenha@chromium.org
steve...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

NOTREACHED() spam from values.cc(136)

Project Member Reported by djkurtz@chromium.org, Mar 28 2017 
Chrome Version: 58.0.3029.31
Chrome OS Version: 9334.18.0
Chrome OS Platform: elm

Steps To Reproduce:
Unclear, noticed in feedback reports such as:
https://feedback.corp.google.com/product/208/neutron?lView=rd&lReport=55960784779

Expected Result:

/var/log/ui/ui.LATEST sometimes fills up with bursts

Actual Result:

/var/log/ui/ui.LATEST sometimes fills up with bursts like this, with hundreds of these messages mere milliseconds apart:

[1256:1524:0327/205017.952206:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205017.952831:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205017.952908:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205017.953038:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205017.953089:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205017.953185:ERROR:values.cc(136)] NOTREACHED() hit.


How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

Sometimes.
I am pretty sure that I've seen this in other reports from older releases, too, but just got around to filing.

What is the impact to the user, and is there a workaround? If so, what is
it?

Unknown.

NOTREACHED() in question is:
https://chromium.googlesource.com/chromium/src/+/58.0.3029.31/base/values.cc#136

Value::Value(double in_double) : type_(Type::DOUBLE), double_value_(in_double) {
  if (!std::isfinite(double_value_)) {
    NOTREACHED() << "Non-finite (i.e. NaN or positive/negative infinity) "
                 << "values cannot be represented in JSON";
    double_value_ = 0.0;
  }
}

Comment 1 by djkurtz@chromium.org, Mar 28 2017

Summary: NOTREACHED() spam from values.cc(136) (was: NOTREACHED() reached spam from values.cc(136))

Comment 2 by derat@chromium.org, Mar 28 2017 

This code is called in tons of places. Are there any messages on either side of the bursts of NOTREACHED() hinting at the cause?

Comment 3 by djkurtz@chromium.org, Mar 28 2017 

The feedback above has two bursts:

(1)
[1256:1256:0327/205016.007301:ERROR:device_event_log_impl.cc(137)] [20:50:16.007] Network: network_state_handler.cc:992 Default network in unexpected state: NETGEAR12 (/service/0)State: idle
[1256:1524:0327/205017.015501:ERROR:connection_factory_impl.cc(386)] Failed to connect to MCS endpoint with error -106
[1256:1524:0327/205017.952206:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205017.952831:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205017.952908:ERROR:values.cc(136)] NOTREACHED() hit.
...
[1256:1524:0327/205017.993600:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205017.994020:ERROR:values.cc(136)] NOTREACHED() hit.

(2)
[1256:1256:0327/205044.254358:ERROR:tab_manager_delegate_chromeos.cc(146)] NOTREACHED() hit.
[1256:1256:0327/205045.055043:ERROR:multi_user_window_manager_stub.cc(19)] Not implemented reached in virtual void <URL: 4> const AccountId&)
[1256:1256:0327/205045.280344:ERROR:multi_user_window_manager_stub.cc(19)] Not implemented reached in virtual void <URL: 4> const AccountId&)
[1256:1256:0327/205046.457428:ERROR:multi_user_window_manager_stub.cc(19)] Not implemented reached in virtual void <URL: 4> const AccountId&)
[1256:1256:0327/205105.754803:ERROR:instance_holder.h(72)] Instance for ar<IPv6: 5>mojom<IPv6: 7>ileSystemInstan<IPv6: 6>Init version mismatch. Expected 3 got 2
[1256:1256:0327/205158.138862:ERROR:multi_user_window_manager_stub.cc(19)] Not implemented reached in virtual void <URL: 4> const AccountId&)
[1256:1524:0327/205229.307704:ERROR:values.cc(136)] NOTREACHED() hit.
[1256:1524:0327/205229.308410:ERROR:values.cc(136)] NOTREACHED() hit.
...
[1256:1524:0327/205229.340612:ERROR:values.cc(136)] NOTREACHED() hit.

Comment 4 by derat@chromium.org, Mar 28 2017

Cc: abodenha@chromium.org steve...@chromium.org xiy...@chromium.org
Thanks, but I still don't have any theories.

I forget, is it possible to generate a minidump without crashing? If so, maybe we could generate one the first time this is hit to get a stack trace.

(The other NOTREACHED() in the second snippet is probably worth looking at, too.)

Comment 5 by xiy...@chromium.org, Mar 28 2017 

DumpWithoutCrashing() to silently generate a dump. [1]

No idea what could be the cause. :(

[1]: https://cs.chromium.org/chromium/src/base/debug/dump_without_crashing.h?rcl=4e3eedb01d42a459acc405e87e7a0a72ca9c71b8&l=21
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 2 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by derat@chromium.org, Apr 2 2018

Status: WontFix (was: Untriaged)
This isn't going to go anywhere without more info. Please reopen if it still happens.
►

Sign in to add a comment