New issue
Advanced search Search tips

Issue 705953 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

virtual/mojo-loading/http/tests/origin_trials/sample-api-workers.html is flaky

Project Member Reported by kolos@chromium.org, Mar 28 2017

Issue description

Time-to-time the test causes failure of WebKit Linux Trusty (stats)

The first failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/24896

I tried to reproduce it locally. The test passed the first run after building and fails on further runs.

I'll fix expectations.
 

Comment 1 by kolos@chromium.org, Mar 28 2017

Components: Tests>Flaky
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a144e93bd31532a9d396ae22488525c34c341bfc

commit a144e93bd31532a9d396ae22488525c34c341bfc
Author: kolos <kolos@chromium.org>
Date: Tue Mar 28 14:13:34 2017

Expect failure or pass from flaky virtual/mojo-loading/http/tests/origin_trials/sample-api-workers.html

TBR=qyearsley@chromium.org
BUG= 705953 

Review-Url: https://codereview.chromium.org/2777903004
Cr-Commit-Position: refs/heads/master@{#460091}

[modify] https://crrev.com/a144e93bd31532a9d396ae22488525c34c341bfc/third_party/WebKit/LayoutTests/TestExpectations

Cc: cha...@chromium.org
Components: -Tests>Flaky Internals>OriginTrials
Labels: Test-Layout
Owner: ----
Status: Available (was: Assigned)
This is another case where the test fails due to "Harness error: ... duplicate test names ...".

It's flaky because the order of subtests is non-deterministic: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty/24896/layout-test-results/results.html
Owner: cha...@chromium.org
Status: Started (was: Available)
I have a CL in progress to address the error for duplicate test names, and remove all the expected.txt files:
https://codereview.chromium.org/2808543002/

That should also address the flakiness. I'll add this bug to the CL, and cleanup the expectations.

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61358d56517577686b5003b89146cc2071f79ed1

commit 61358d56517577686b5003b89146cc2071f79ed1
Author: chasej <chasej@chromium.org>
Date: Tue Apr 11 04:03:52 2017

Cleanup expected.txt files for layout tests

Rework the layout tests for origin trials so the expected.txt files are
no longer needed. This was addressing the harness error about duplicate
test names. Due to tests being run in multiple workers, the structure
was reworked to make it easier to create unique test names.

Also, remove the expectation for a flaky test, since the expected.txt
files were forcing the flaky results (see  crbug.com/705953 ).

This is a precursor so later changes to the layout tests do not require
changing multiple expected.txt files.

BUG= 695123 ,  705953 

Review-Url: https://codereview.chromium.org/2808543002
Cr-Commit-Position: refs/heads/master@{#463525}

[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/disabled-worker.js
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js
[add] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials-worker.js
[rename] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/sample-api-enabled-worker.php
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-broken.html
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-disabled.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled-expected.txt
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled-header-expected.txt
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled-header.php
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled.html
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-expired.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-multiple-tokens-expected.txt
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-multiple-tokens-header-expected.txt
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-multiple-tokens-header.php
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-multiple-tokens.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-before-access-expected.txt
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-before-access.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-expected.txt
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added.html
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-stolen.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-workers-expected.txt
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/origin_trials/sample-api-workers-expected.txt

Comment 6 by cha...@chromium.org, Apr 11 2017

Status: Fixed (was: Started)

Sign in to add a comment