New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705925 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 705919



Sign in to add a comment

Make MediaNotification configurable

Project Member Reported by zqzh...@chromium.org, Mar 28 2017

Issue description

We need to make it easier to customize the service class, receiver class, etc.
 
I think this bug very vaguely implies it's needed to make testing easier (except that it blocks the testing bug). Otherwise I'd not even file a bug for this but rather list this requirement in the test bug and submit the cl with the test bug in BUG=.
Summary: Make MediaNotification configurable (was: Use Class<?> instead of ClassName for media notification intents)
Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52ec59e6f64784544c395fba8c448fea01033de4

commit 52ec59e6f64784544c395fba8c448fea01033de4
Author: zqzhang <zqzhang@chromium.org>
Date: Wed Mar 29 15:26:25 2017

Make media notification classes configurable

This CL makes the media notification classes configurable in the
following ways:

* Using Class<?> instead of class names for simplicity.
* Having a static map in MediaNotificationManager to look up the service
  class, receiver class, notification group name for a given
  notification ID.

BUG= 705925 

Review-Url: https://codereview.chromium.org/2776243003
Cr-Commit-Position: refs/heads/master@{#460394}

[modify] https://crrev.com/52ec59e6f64784544c395fba8c448fea01033de4/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaButtonReceiver.java
[modify] https://crrev.com/52ec59e6f64784544c395fba8c448fea01033de4/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Status: Fixed (was: Assigned)
Blocking: -705919
Blockedon: 705919

Sign in to add a comment