New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705907 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Text on crash recovery bubble is not aligned properly

Project Member Reported by sc00335...@techmahindra.com, Mar 28 2017

Issue description

Chrome Version: 59.0.3053.3 dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome and type ABOUT:INDUCEBROWSERCRASHFORREALZ in omnibox to crash the browser manually.
(2)Now open chrome again and observe text on it

Expected: Text should be properly aligned.
Actual: Instead text is not properly aligned. 

Manual Bisect Info:

Good Build: 57.0.2977.0 dev
Bad Build: 57.0.2978.0 dev
 
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Win 10 and Ubuntu 14.04 using 59.0.3053.3.

Note: The layout is different for Mac recovery bubble, not applicable to Mac.
Attaching screenshots for reference..
Actual_restore bubble.png
157 KB View Download
Expected_restore bubble.png
130 KB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: kylixrd@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build:57.0.2977.0 (Revision:442447).
Bad build:57.0.2978.0 (Revision:442756).

You are probably looking for a change made after 442682 (known good), but no later than 442683 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/e5410705426f111d9ea78d121b70cb87ddf38187..44ec2a4fd5e1c052077575f84b5b5cbdb703cef6

From the CL above, assigning the issue to the concern owner

@kylixrd: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2571613002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Not in Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3053.3.
Just to Update, this issue is observed on Windows 10 with chrome canary #59.0.3063.0

kylixrd@ could you please look into it and provide the latest info.
Gentle ping, this issue is observed on Windows 10 with chrome canary #59.0.3068.1

kylixrd@ could you please look into it and provide the latest info.

These artifacts are coming about due to the current "Harmony" (Material Design) work for the UI. Once that effort is complete and the UI is switched to fully Material Design mode, these issues will go away.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d0f09e42f23950e3937e36e5bdc3a384f732330

commit 5d0f09e42f23950e3937e36e5bdc3a384f732330
Author: kylixrd <kylixrd@chromium.org>
Date: Wed Apr 19 16:45:10 2017

Restored Pre-Harmony Bubble title margin metrics

Added INSETS_BUBBLE_TITLE metric to distinguish from INSETS_DIALOG_TITLE

BUG= 711012 
BUG= 705907 

Review-Url: https://codereview.chromium.org/2819633002
Cr-Commit-Position: refs/heads/master@{#465635}

[modify] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
[modify] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[add] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
[modify] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
[modify] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/chrome/browser/ui/views/session_crashed_bubble_view.h
[add] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/chrome/browser/ui/views/session_crashed_bubble_view_browsertest.cc
[modify] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/chrome/test/BUILD.gn
[modify] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/5d0f09e42f23950e3937e36e5bdc3a384f732330/ui/views/layout/layout_provider.h

Status: Fixed (was: Assigned)

Sign in to add a comment