Test emits invalid GTest output |
||||||||
Issue descriptionhttps://uberchromegw.corp.google.com/i/internal.bling.main/builders/smoke/builds/14863/steps/components_unittests%20%28iPhone%205s%20iOS%2010.0%29%20on%20Mac The [ OK ] is not a the start of a line and is not recognized. This caused tree to be closed.
,
Mar 28 2017
Why is the [ OK ] not at the start of a line? We can only parse valid gtest format. Please fix. Here's the log: [----------] 4 tests from ClipboardRecentContentIOSTest [ RUN ] ClipboardRecentContentIOSTest.SchemeFiltering 2017-03-28 00:52:28.058 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected. 2017-03-28 00:52:28.064 components_unittests[25733:162572] PBItemCollectionServicer connection disconnected. 2017-03-28 00:52:28.070 components_unittests[25733:163299[ OK ] ] PBItemCollectionServicer connection disconnected. ClipboardRecentContentIOSTest.SchemeFiltering (35 ms) [ RUN ] ClipboardRecentContentIOSTest.PasteboardURLObsolescence 2017-03-28 00:52:28.296 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected. [ OK ] ClipboardRecentContentIOSTest.PasteboardURLObsolescence (7 ms) [ RUN ] ClipboardRecentContentIOSTest.SupressedPasteboard 2017-03-28 00:52:28.303 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected. 2017-03-28 00:52:28.310 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected. [ OK ] ClipboardRecentContentIOSTest.SupressedPasteboard (13 ms) [ RUN ] ClipboardRecentContentIOSTest.AddingNonStringRemovesCachedString 2017-03-28 00:52:28.318 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected. 2017-03-28 00:52:28.324 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected. 2017-03-28 00:52:28.332 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected. [ OK ] ClipboardRecentContentIOSTest.AddingNonStringRemovesCachedString (21 ms) [----------] 4 tests from ClipboardRecentContentIOSTest (299 ms total)
,
Mar 29 2017
+jif as this is clipboard test +baxley for gtest fix
,
Mar 29 2017
Gtest message and the iOS error message were interleaved: -gtest printf "[ OK ] " to stdout. -PBItemCollectionServicer printed its error message. -gtest printf the rest of the line. This issue is not ClipboardRecentContentIOSTest specific. Possible solutions: -locking stdout (with flockfile?)? -having gtest print the message with a single printf/write?
,
Nov 18 2017
,
Nov 19
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 23
This seems to not be fixed. Is this still an issue?
,
Nov 29
,
Nov 29
this doesn't appear to currently be affecting the smoke bot or components_unittests. please refile or reopen w/ references if you see it again. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sergeybe...@chromium.org
, Mar 28 2017