New issue
Advanced search Search tips

Issue 705894 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Test emits invalid GTest output

Project Member Reported by olivierrobin@chromium.org, Mar 28 2017

Issue description

Components: -Infra Infra>Client>iOS

Comment 2 by s...@google.com, Mar 28 2017

Cc: smut@chromium.org
Components: -Infra>Client>iOS Test>iOS
Labels: OS-iOS
Owner: ----
Status: Available (was: Assigned)
Summary: Test emits invalid GTest output (was: Test passed but marked failed)
Why is the [ OK ] not at the start of a line? We can only parse valid gtest format. Please fix.

Here's the log:

[----------] 4 tests from ClipboardRecentContentIOSTest
[ RUN      ] ClipboardRecentContentIOSTest.SchemeFiltering
2017-03-28 00:52:28.058 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected.
2017-03-28 00:52:28.064 components_unittests[25733:162572] PBItemCollectionServicer connection disconnected.
2017-03-28 00:52:28.070 components_unittests[25733:163299[       OK ] ] PBItemCollectionServicer connection disconnected.
ClipboardRecentContentIOSTest.SchemeFiltering (35 ms)
[ RUN      ] ClipboardRecentContentIOSTest.PasteboardURLObsolescence
2017-03-28 00:52:28.296 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected.
[       OK ] ClipboardRecentContentIOSTest.PasteboardURLObsolescence (7 ms)
[ RUN      ] ClipboardRecentContentIOSTest.SupressedPasteboard
2017-03-28 00:52:28.303 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected.
2017-03-28 00:52:28.310 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected.
[       OK ] ClipboardRecentContentIOSTest.SupressedPasteboard (13 ms)
[ RUN      ] ClipboardRecentContentIOSTest.AddingNonStringRemovesCachedString
2017-03-28 00:52:28.318 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected.
2017-03-28 00:52:28.324 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected.
2017-03-28 00:52:28.332 components_unittests[25733:163299] PBItemCollectionServicer connection disconnected.
[       OK ] ClipboardRecentContentIOSTest.AddingNonStringRemovesCachedString (21 ms)
[----------] 4 tests from ClipboardRecentContentIOSTest (299 ms total)
Cc: jif@chromium.org
Owner: baxley@chromium.org
+jif as this is clipboard test
+baxley for gtest fix

Comment 4 by jif@chromium.org, Mar 29 2017

Gtest message and the iOS error message were interleaved:

-gtest printf "[       OK ] " to stdout.
-PBItemCollectionServicer printed its error message.
-gtest printf the rest of the line.

This issue is not ClipboardRecentContentIOSTest specific. Possible solutions:
-locking stdout (with flockfile?)?
-having gtest print the message with a single printf/write?

Comment 5 by baxley@chromium.org, Nov 18 2017

Cc: baxley@chromium.org
Components: -Test>iOS Tests
Owner: ----
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 19

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -baxley@chromium.org -smut@chromium.org -jif@chromium.org linds...@chromium.org olivierrobin@chromium.org
Owner: jbudorick@chromium.org
This seems to not be fixed. Is this still an issue?
Status: Assigned (was: Untriaged)
Cc: jbudorick@chromium.org
Owner: ----
Status: WontFix (was: Assigned)
this doesn't appear to currently be affecting the smoke bot or components_unittests. please refile or reopen w/ references if you see it again.

Sign in to add a comment