M58 compilation failed |
|||||||||
Issue description
[60264/77006] CXX obj/ios/chrome/browser/reading_list/reading_list_remover/reading_list_remover_helper.o
FAILED: obj/ios/chrome/browser/reading_list/reading_list_remover/reading_list_remover_helper.o
export DEVELOPER_DIR=/b/build/slave/chrome-ios-official/build/src/build/ios_files/Xcode.app; clang++ -MMD -MF obj/ios/chrome/browser/reading_list/reading_list_remover/reading_list_remover_helper.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=\"296320-1\" -DCR_XCODE_VERSION=0821 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fcolor-diagnostics -arch arm64 -Wall -Werror -Wextra -Wundeclared-selector -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Os -gdwarf-2 -isysroot /b/build/slave/chrome-ios-official/build/src/build/ios_files/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.2.sdk -stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fvisibility-inlines-hidden -std=c++11 -fno-rtti -fno-exceptions -c ../../ios/chrome/browser/reading_list/reading_list_remover_helper.cc -o obj/ios/chrome/browser/reading_list/reading_list_remover/reading_list_remover_helper.o
In file included from ../../ios/chrome/browser/reading_list/reading_list_remover_helper.cc:9:
In file included from ../../ios/chrome/browser/reading_list/reading_list_download_service.h:11:
In file included from ../../ios/chrome/browser/reading_list/url_downloader.h:12:
In file included from ../../ios/chrome/browser/dom_distiller/distiller_viewer.h:12:
In file included from ../../components/dom_distiller/core/dom_distiller_request_view_base.h:14:
In file included from ../../components/dom_distiller/core/dom_distiller_service.h:17:
../../components/dom_distiller/core/distiller_page.h:15:10: fatal error: 'third_party/dom_distiller_js/dom_distiller.pb.h' file not found
#include "third_party/dom_distiller_js/dom_distiller.pb.h"
^
1 error generated.
,
Mar 28 2017
,
Mar 28 2017
Please add applicable OSs. Thanks.
,
Mar 29 2017
i to the OS
,
Mar 29 2017
This bug requires manual review: Less than 23 days to go before AppStore submit on M58 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 30 2017
,
Mar 30 2017
Issue 706425 has been merged into this issue.
,
Mar 30 2017
,
Apr 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5db9b7276b3d40ceda37b6c36ea96e9d4389bc6 commit c5db9b7276b3d40ceda37b6c36ea96e9d4389bc6 Author: Olivier Robin <olivierrobin@chromium.org> Date: Sat Apr 01 05:27:32 2017 Fix deps reading_list_remover_helper -> dom_distiller The dom_distiller export a protobuf header and must be declared as public deps. BUG= 705890 Review-Url: https://codereview.chromium.org/2772373004 Cr-Commit-Position: refs/heads/master@{#460073} (cherry picked from commit 03b5ef86dce1b086e2fb8b5434e523e0d9b473e3) Review-Url: https://codereview.chromium.org/2791863002 . Cr-Commit-Position: refs/branch-heads/3029@{#525} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/c5db9b7276b3d40ceda37b6c36ea96e9d4389bc6/ios/chrome/browser/reading_list/BUILD.gn
,
Apr 3 2017
Issue 706838 has been merged into this issue.
,
Apr 4 2017
Verified on M58, We have a New M58 build in pantheon. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 28 2017