New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705888 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
█ markusheintz@chromium.org
treib@chromium.org
fhorschig@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Provide Errors Details in ImageFetcher

Project Member Reported by fhorschig@chromium.org, Mar 28 2017 
The ImageDataFetcher currently promises two things for the callback that is invoked when image data fetches were no successful:

A. "In case of an error an empty string is passed to the callback."
B. "If an error prevented a http response,
    |request_metadata.response_code| will be RESPONSE_CODE_INVALID."

That means, users of ImageFetcher (which uses the ImageDataFetcher)
will receive empty images in any error case and the error reason is
lost.

We should provide users of this class with the possibility to react to
or record the different reasons why the returned image was empty.
e.g.
500 error --> retry later
404 error --> don't retry, look for alternative
Download limit exceeded --> request smaller images

Comment 1 by fhorschig@chromium.org, Mar 28 2017 

Side note: the class is heavily used by the NTP. If you find a
component where it fits better, please change it accordingly.

Also: can we label this a GoodFirstBug? Seems pretty decoupled ... at least as long as it isn't required somewhere else.

Comment 2 by fhorschig@chromium.org, Mar 28 2017

Labels: -OS-Linux

Comment 3 by treib@chromium.org, Mar 28 2017

Cc: fhorschig@chromium.org markusheintz@chromium.org
Labels: -Type-Bug Hotlist-GoodFirstBug Type-Feature
Owner: ----
Other image_fetcher bugs either don't have a component, or are tagged as NTP too (bug 624761,  bug 609127 ), so this is fine for now. We should maybe look into getting an image_fetcher component though.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by fhorschig@chromium.org, Apr 3 2018

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Still a good first bug.
►

Sign in to add a comment