Reading List item should not know the displayed cell |
||
Issue descriptionCurrently the ReadingListCollectionViewItem know the cell they are displaying and update them directly. This does not respect the philosophy behind the cell/item couple and will probably breaks when we use the autolayout layout. The item needs to be configured with the correct data then the cell must be reconfigured.
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eee1c04986aabbf73c763b913c33d0d538f3ad5f commit eee1c04986aabbf73c763b913c33d0d538f3ad5f Author: gambard <gambard@chromium.org> Date: Wed Mar 29 08:09:50 2017 Removes the displayed cell in the ReadingList item The Reading List item had a pointer to the cell displayed. This does not work with auto layout. BUG= 705881 Review-Url: https://codereview.chromium.org/2779893003 Cr-Commit-Position: refs/heads/master@{#460324} [modify] https://crrev.com/eee1c04986aabbf73c763b913c33d0d538f3ad5f/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [modify] https://crrev.com/eee1c04986aabbf73c763b913c33d0d538f3ad5f/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h [modify] https://crrev.com/eee1c04986aabbf73c763b913c33d0d538f3ad5f/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
,
Mar 29 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 29 2017