New issue
Advanced search Search tips

Issue 705873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 705872



Sign in to add a comment

Oilpan: Same thread heap DCHECK during marking isn't working

Project Member Reported by keishi@chromium.org, Mar 28 2017

Issue description

Comment 1 by horo@chromium.org, Mar 28 2017

Labels: Postmortem-Followup
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a93efbaa0146b717e42c78fd320074852822435a

commit a93efbaa0146b717e42c78fd320074852822435a
Author: keishi <keishi@chromium.org>
Date: Wed Apr 05 08:32:54 2017

Oilpan: isHeapObjectAlive should not return true for cross thread objects

isHeapObjectAlive was returning true for all cross thread objects. This was added in https://codereview.chromium.org/1909813002 because PersistentBase::checkPointer was calling isHeapObjectAlive with cross thread objects. The call to isHeapObjectAlive from PersistentBase::checkPointer was removed in https://codereview.chromium.org/2701273002 so this was no longer necessary.

isHeapObjectAlive was being used during marking which meant cross thread objects were not being marked, skipping the DCHECK in marking, causing crbug.com/702527 and  crbug.com/705872  to go undetected.

BUG= 705873 

Review-Url: https://codereview.chromium.org/2773013002
Cr-Commit-Position: refs/heads/master@{#462009}

[modify] https://crrev.com/a93efbaa0146b717e42c78fd320074852822435a/third_party/WebKit/Source/platform/heap/Heap.h

Status: Fixed (was: Started)
Going through open Prio=1 issues.

Sign in to add a comment